From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65E5CC6377C for ; Wed, 21 Jul 2021 20:51:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DC80C61009 for ; Wed, 21 Jul 2021 20:51:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC80C61009 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 74C7C6B0036; Wed, 21 Jul 2021 16:51:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6FC9B6B006C; Wed, 21 Jul 2021 16:51:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5ECA36B0070; Wed, 21 Jul 2021 16:51:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0224.hostedemail.com [216.40.44.224]) by kanga.kvack.org (Postfix) with ESMTP id 460B46B0036 for ; Wed, 21 Jul 2021 16:51:00 -0400 (EDT) Received: from smtpin32.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id E15D98248076 for ; Wed, 21 Jul 2021 20:50:59 +0000 (UTC) X-FDA: 78387789438.32.98F6344 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf25.hostedemail.com (Postfix) with ESMTP id 8FA66B01CF21 for ; Wed, 21 Jul 2021 20:50:59 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 2F76460FEA; Wed, 21 Jul 2021 20:50:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1626900658; bh=iPgc6ODsz4TxG0bpAFE63PzUmM0U3DXOBMd9a7IulMc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tuC7TNZ5RmKRaB07c88XWWZDEI4hetYXiE0Qb7/LwJPcIZEQjmJpI1w/Y8kgHJjNi 5wYMrf3nlLL4i22bJZXRHDfgvSGWmqflPgI7CFVY+fkPKsGB+P8IMp3/oSU1Qt2pP1 SqaL65gU1IP7oBK0HyD9zjPysNWnP/OqPWo9pZ+A= Date: Wed, 21 Jul 2021 13:50:56 -0700 From: Andrew Morton To: Suren Baghdasaryan Cc: David Hildenbrand , Michal Hocko , Michal Hocko , David Rientjes , Matthew Wilcox , Johannes Weiner , Roman Gushchin , Rik van Riel , Minchan Kim , Christian Brauner , Christoph Hellwig , Oleg Nesterov , Jann Horn , Shakeel Butt , Andy Lutomirski , Christian Brauner , Florian Weimer , Jan Engelhardt , Tim Murray , Linux API , linux-mm , LKML , kernel-team Subject: Re: [PATCH v2 1/3] mm, oom: move task_will_free_mem up in the file to be used in process_mrelease Message-Id: <20210721135056.84d12dd49c07adff7b0beffb@linux-foundation.org> In-Reply-To: References: <20210718214134.2619099-1-surenb@google.com> <7eb17da6-03a6-5eaf-16e6-97b53ba163d8@redhat.com> <20210720160707.2332738708948f7d865d67c1@linux-foundation.org> <0ee6775b-589c-3243-1c01-aafad5eecb73@redhat.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=tuC7TNZ5; spf=pass (imf25.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspamd-Server: rspam02 X-Stat-Signature: rn8pmax6pjgp3wngy7swnmczzy457rnc X-Rspamd-Queue-Id: 8FA66B01CF21 X-HE-Tag: 1626900659-442521 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 21 Jul 2021 13:19:35 -0700 Suren Baghdasaryan wrote: > > > This would not require moving other functions. > > > Would that be better than the current approach or the forward declaration? > > > > IMHO that could be an easy, possible alternative. > > Andrew, others? Should I follow this path instead? Whatever you prefer ;)