From: Alain Volmat <alain.volmat@foss.st.com>
To: kernel test robot <lkp@intel.com>
Cc: <kbuild-all@lists.01.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Mark Brown <broonie@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
<linux-spi@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] spi: stm32: fix excluded_middle.cocci warnings
Date: Mon, 26 Jul 2021 11:55:32 +0200 [thread overview]
Message-ID: <20210726095532.GA11839@gnbcxd0016.gnb.st.com> (raw)
In-Reply-To: <20210713191004.GA14729@5eb5c2cbef84>
Thanks.
Reviewed-by: Alain Volmat <alain.volmat@foss.st.com>
On Wed, Jul 14, 2021 at 03:10:04AM +0800, kernel test robot wrote:
> From: kernel test robot <lkp@intel.com>
>
> drivers/spi/spi-stm32.c:915:23-25: WARNING !A || A && B is equivalent to !A || B
>
>
> Condition !A || A && B is equivalent to !A || B.
>
> Generated by: scripts/coccinelle/misc/excluded_middle.cocci
>
> Fixes: 7ceb0b8a3ced ("spi: stm32: finalize message either on dma callback or EOT")
> CC: Alain Volmat <alain.volmat@foss.st.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: 8f0df15bafc1e1c92b6d96bf8ef24dd8be3aec7b
> commit: 7ceb0b8a3ceddc36ae4ef1cba6c25a0e28ed65fc [1012/1340] spi: stm32: finalize message either on dma callback or EOT
> :::::: branch date: 11 hours ago
> :::::: commit date: 2 days ago
>
> spi-stm32.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> --- a/drivers/spi/spi-stm32.c
> +++ b/drivers/spi/spi-stm32.c
> @@ -912,8 +912,7 @@ static irqreturn_t stm32h7_spi_irq_threa
> if (!spi->cur_usedma && (spi->rx_buf && (spi->rx_len > 0)))
> stm32h7_spi_read_rxfifo(spi);
> if (!spi->cur_usedma ||
> - (spi->cur_usedma && (spi->cur_comm == SPI_SIMPLEX_TX ||
> - spi->cur_comm == SPI_3WIRE_TX)))
> + (spi->cur_comm == SPI_SIMPLEX_TX || spi->cur_comm == SPI_3WIRE_TX))
> end = true;
> }
>
next prev parent reply other threads:[~2021-07-26 9:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 19:09 [linux-next:master 1012/1340] drivers/spi/spi-stm32.c:915:23-25: WARNING !A || A && B is equivalent to !A || B kernel test robot
2021-07-13 19:10 ` [PATCH] spi: stm32: fix excluded_middle.cocci warnings kernel test robot
2021-07-26 9:55 ` Alain Volmat [this message]
2021-08-20 14:39 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210726095532.GA11839@gnbcxd0016.gnb.st.com \
--to=alain.volmat@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=broonie@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=lkp@intel.com \
--cc=mcoquelin.stm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).