From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4076C4338F for ; Mon, 26 Jul 2021 12:45:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0D15060F4F for ; Mon, 26 Jul 2021 12:45:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0D15060F4F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 765BB6B0033; Mon, 26 Jul 2021 08:45:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 716448D0002; Mon, 26 Jul 2021 08:45:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B6EF8D0001; Mon, 26 Jul 2021 08:45:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0039.hostedemail.com [216.40.44.39]) by kanga.kvack.org (Postfix) with ESMTP id 3CA7F6B0033 for ; Mon, 26 Jul 2021 08:45:39 -0400 (EDT) Received: from smtpin33.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id CA451182321A0 for ; Mon, 26 Jul 2021 12:45:38 +0000 (UTC) X-FDA: 78404710356.33.52A5AD0 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf12.hostedemail.com (Postfix) with ESMTP id 2E708100F52C for ; Mon, 26 Jul 2021 12:45:38 +0000 (UTC) Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 16QCaiop032242; Mon, 26 Jul 2021 12:45:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2021-07-09; bh=7sklWt0fn2wGiqQ7A+47jeiqNuAfQ8+mqEic0mQT51I=; b=hQqNchR2TMybhpztdNSljn8sVKU1DA4JLSUv6JKvFbYamF7HG2ujSbWpFkuQAevAqXMp XEBgRIY8HSLmD5+15VQCZ0ZjHvWiBBEkXSsvcWyH7/dtz845xKSukFZsru2wDHjPFMCG p4DhPNKTsNGtucoE7ivsNzfbRsAR1VJM/ko87F0Hgawzb193PYlhUbzwykMKJNjfL5B+ 9iKUZYeVXIEun3NAUFoGlwoJPQXASjWf+TqZORwC0XlCxQw8CrvkzPU6HHT8WlDR8rEv VmtTaVP5QGUNQLif/KECwceq7cvqyAKf9NHfk6iWr/DsI8K8TVouJh8buGsmnSPBUtbL 0w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2020-01-29; bh=7sklWt0fn2wGiqQ7A+47jeiqNuAfQ8+mqEic0mQT51I=; b=VPQy8CrAfHpOv2bpoCCRZnXCScnywYQImFlvAe6JD7Gq8rpD/jsxxcjHxqu1vKRQVmfV huZJy2iDdN4LahwFDmz5H0slBBfa7ABVVDXu7t4/s1r+/gPIO5Lti2nHeQS6W/8Htcqv nH3wyG3Ge+PF2Rjfor/2gAKce+vV3+uyX882rQH3/JsSV0E0sx2GqVDPnz5wQ5FIanvH +U0dv/FiyjX8Y1dT2qNqRP+JWvd0EAACkEFBH1DddL7n1yLSI+vzVcx/SiR4+jqZlbHg PLRANgoKNqTK5NEjK4qzhquVTW3+IdpJWrFQ/SmdD3Z7M9qYWiDAU7qKISvmBV2BDsbL AQ== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 3a1cmb1c1t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 26 Jul 2021 12:45:36 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 16QCihfk035097; Mon, 26 Jul 2021 12:45:35 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2102.outbound.protection.outlook.com [104.47.55.102]) by userp3020.oracle.com with ESMTP id 3a0vmswqux-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 26 Jul 2021 12:45:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GAtkC4GYg91h5UNosnuppplBQryab5nQ4mPIfMYZ65VbABFx/fykqZJ+5RjDJDfB0j7sO/gUL+/Q/y49cahs4jlGwAIuUQS3Nqit7gBv5FR34MJMpJXB1g0PHcZ8FOvPvLh6TpYsFs4QnjLNYUXAxLtR5CDgCklBmkcOoB/YYpw3rKh1OoC2rDwTa7t+VnzkZ/vlJiYI89YUfJvQiK4Y9NupITkJV2DU6KqfthtNeCKscVv3rmwneURkaJ9alj0/vDXgmFq0b2NHtTxB8d7jWg5HspvBQhp72nUot51rBt3nwyGQ7KBAZg8ciSHuttGfBzrZ7m53MuR20xZ5OFfRRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7sklWt0fn2wGiqQ7A+47jeiqNuAfQ8+mqEic0mQT51I=; b=XbHYsnOwDOXBlzOVBhB0u6MFRuj9ATc5uefl2PtQVbnEIgsk/NCv5atkP98VvaHCgNQbSJLsvoaaOnXHrxbduI96Oo78BpM/EFTGfdfVKCedTp3phC6Yfw2MbvuMab0Hh+gXyhlCD/EgJuZf1Cpr19uzX6WCfDVnG9yV90+LufxIlg0x1sPrR8szl8JNyo9w/JZK9A0UWw4IfzX+9eRm8jK0PK4ykzelB2AAL3/bYFha0/DlKNYkvaAtz4iRDxvU+yWODiCagTe9jQUoRWdWXuLcLtMYJS+DAk2uQSBCzsMIl5CWxGRyNAQiMIr3wJK85dw2XWRT6l4SzOkWPEjDrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7sklWt0fn2wGiqQ7A+47jeiqNuAfQ8+mqEic0mQT51I=; b=jhqgvjxeNubHSA3OoW7QG6H1snBFVFDj1xla/bKz4B7Xl5JL8SfoTLZIRSBppg6FaSds8yl2kRNUn+AqABkLlpQpwq1jB8RSJ9q5CWNviPM8teLEXKGTTtqASkwHkBPOBo9t7+h3ZcWYkY+lHAon/JrxjxkeVZhfdmM+qcG9CO4= Received: from MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) by MWHPR10MB1997.namprd10.prod.outlook.com (2603:10b6:300:110::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.26; Mon, 26 Jul 2021 12:45:32 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::5820:e42b:73d7:4268]) by MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::5820:e42b:73d7:4268%7]) with mapi id 15.20.4352.031; Mon, 26 Jul 2021 12:45:32 +0000 Date: Mon, 26 Jul 2021 15:45:15 +0300 From: Dan Carpenter To: Takashi Iwai Cc: kbuild@lists.01.org, lkp@intel.com, kbuild-all@lists.01.org, Linux Memory Management List Subject: Re: [linux-next:master 1517/2389] sound/pci/als4000.c:930 snd_card_als4000_probe() warn: 'pci' not released on lines: 852,872. Message-ID: <20210726124515.GJ25548@kadam> References: <202107221413.qyIXVv60-lkp@intel.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-ClientProxiedBy: JNXP275CA0004.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:19::16) To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from kadam (102.222.70.252) by JNXP275CA0004.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:19::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.25 via Frontend Transport; Mon, 26 Jul 2021 12:45:28 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d2259e81-afb6-44db-c13f-08d950334173 X-MS-TrafficTypeDiagnostic: MWHPR10MB1997: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /GMlhdmqTpRbChn9SqAgW+INPjj5J8EoYvVhl9zfjU5KmNolmbi280U3rWkDqfQj71W33JF5+BFJvJTuVx4UVGs+Z905F/FJUdXDvA8gvMhWm+CHp3j6wf1E1XDK1GsWWXOImZ1YPHFAHKPSOFt4r0Xi3uq9+Fn87POjz8ZkHfuCYniRemLPFpwJGjlHCgiFv/Js9wQRyrS00cgAS0u1IzuwOcUdlwnKTNoeosXnYFpiFl7SQ0i5jcNdj3PNOVizkbf/0/wpRBn4Nh6dT8ij1k8fCOBKrQXP0OrKmOU5fkxZup9CR6CEU7cPGtkadn4+mtAqBxs8yWk2hk3Beq4cQXHoOvA7N7buSN2IxlsQ9pS15jKOAyk3WNvZbNjfYlmWvyMc+QBAY0mGJbnu22HaoHWV2hQw7iEF4yF0k/KuvN+SPdvVSLikVkLP3kWD4TopP0mgqghXpWjNOkMgHrh1gju9hCvt1gMEEK/sCBcF8tkCvthTKQ3GRxk3ZxR8tsbMDSgXUUGJrLW5JLq9vtIiuytKg/mnO3hcgdSdPQ157JkA5dNH0S4dde7moKU9CkgFt6o7/faFYDy3RjYyHGCsCS7ODDHaq5empL2NwP9iI/Fqld9w9bkIfMhV07UsaLmXNLP/1+ZS5624PWiMpRUybu6YdEoj5Dgxww3iI9CkafmlhqlspfXmRelzK/9ng2fCs3H+9m8nVbeYRmks/inDYA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(346002)(366004)(39860400002)(396003)(136003)(66946007)(6916009)(2906002)(5660300002)(186003)(8676002)(4326008)(1076003)(8936002)(316002)(956004)(9686003)(55016002)(478600001)(66476007)(9576002)(33716001)(66556008)(38100700002)(6666004)(83380400001)(86362001)(44832011)(52116002)(6496006)(38350700002)(33656002)(26005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/DEX4fXoZMKnVX6PuWJk9zG+3KvEBIVsNliwJCCZuOJv3oKe8grKTdBg8hxK?= =?us-ascii?Q?d5Fpz/ZtZ9cmR4FRqQDcPO7RPpGBxKhLRMYc4fKZ8C887V/ymoudnpfu246I?= =?us-ascii?Q?BoE8xbklgjgnBBwNF1VV9w7/yDFImZnoB6H8gyhYdMWcu9hSfJ5bPn5auOTM?= =?us-ascii?Q?y/XUS5lQShVGqxS+0A1VnxusjaAb+vQQTY9FlohfIk+DkYxvAMowRXzFdY8z?= =?us-ascii?Q?cQZ5MqiHFkx2rrcCM2zA5JXSIGMrJQRdXZUPunAjLzc+xuG4rLFaFl8FHwrI?= =?us-ascii?Q?+U3IrUSrQceun8dsu5HFHQnxRchDx+SVJp4YR7ZecdK8Kzrer/d1ohQojoUF?= =?us-ascii?Q?yuqx1bsMmt85PSfhFB29XSNwEcR/g2Y8NRxcHSdRXdnPeH8I2T6tO9l+WMUf?= =?us-ascii?Q?tDJs2yMOqLfMEFBZmtpGCerFqkZzJld+oupaOYvvJ6zeaGx74J5yAZljr+iC?= =?us-ascii?Q?V9lYEm5Hg/3T5fp4ypLBEExtbSdM/1Sn8clHWgBAxUVUnGvg6W/CyHMs+Sza?= =?us-ascii?Q?tARAeYNMkTz8rVki+emzjwmCVLp/71i7x1ZA7YTHNwhw+J+r/vmsv4setWlX?= =?us-ascii?Q?Nit06yuyYnS4TpC7QkVWBgX+/Sf1pxbfZPAiX9GmnxuW1kwUJJ4qVh/Z2mc1?= =?us-ascii?Q?OCd7s4m2PslgdeTf5VKwW/vbe4pDTLQLNiwxb4hurRJ/hsyEEO2JBo/W+mWs?= =?us-ascii?Q?xnU8Y3Pjwgu5HbqYbgM0o45NXwrFlKEzl9eG22B3/16VxvR9dri4FHSW6fLZ?= =?us-ascii?Q?qQwuqGvXrQzEtVAgglb4rAIibgYYhVlXpeH4PzY8sxa/oWUUAOzXf8rNeOPu?= =?us-ascii?Q?WnS21J08A77/I2xGewWGhgThwoo1bNWOz1izp4xZVjMLP2vo3msLi6GCDG8m?= =?us-ascii?Q?6ZHnBKAwon4HotjG4F5RrqX8N6wKbMr/eb+8OgV9WNvMZclV2m/SE/0wBIDe?= =?us-ascii?Q?/ZXnVjznnVwfQiKSW+ELOCB2fFw2+S08/evf2aGqorU7emLXqmTMJ0iRkujK?= =?us-ascii?Q?1/JpKmQZS35YStWSmP37uo7Y8E/nWe8vbWK/+T6qyl2QzWNCBLiTsr3vYl6E?= =?us-ascii?Q?nt4ln/7bs1F0QC5OisC8pVixNP41UqkbxoGfVQNy5zYVv+MnHO2dqIdKrAWT?= =?us-ascii?Q?rTs1FW7Mn4ZM5Yh/DMYF9C2X9ZMJtljm3SKrWUW/5pULxisfpbbl1DD6Ksnv?= =?us-ascii?Q?mJ3dwcOnmW6fQh1HX4csZbGQ9llakcyPP7uFtxZf0dmKt0mLzs047wDI9QwQ?= =?us-ascii?Q?PIgYiL6T+HMvCvbrZX+fL3vnvrrl1R4C0Mm8JcW28Wc0HB/8vuaqVp45on/Q?= =?us-ascii?Q?UuXjh0iVBKQ4gKnBmtBKdMJI?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: d2259e81-afb6-44db-c13f-08d950334173 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2021 12:45:32.6682 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XUCj5GKTY5eif3HjRz2uyrH5RMgceXqlO1OsrbSHmyU2c236HlrLY+CJPkg6P6blMQ7HG761klm7NeSXMC2gkJiukYLFN6qB0b4/S2aLN84= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1997 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=10056 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 suspectscore=0 adultscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2107260073 X-Proofpoint-GUID: 3J-zPOi_TNzLhyUj_AEMxmh-Ny9HuQJH X-Proofpoint-ORIG-GUID: 3J-zPOi_TNzLhyUj_AEMxmh-Ny9HuQJH X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 2E708100F52C Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=hQqNchR2; dkim=pass header.d=oracle.com header.s=corp-2020-01-29 header.b=VPQy8CrA; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=jhqgvjxe; dmarc=pass (policy=none) header.from=oracle.com; spf=none (imf12.hostedemail.com: domain of dan.carpenter@oracle.com has no SPF policy when checking 205.220.177.32) smtp.mailfrom=dan.carpenter@oracle.com X-Stat-Signature: m3yciw7pzzx7a6tbwhmd8nscyiamqrz3 X-HE-Tag: 1627303538-85889 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 22, 2021 at 06:19:19PM +0200, Takashi Iwai wrote: > > ^1da177e4c3f41 Linus Torvalds 2005-04-16 827 > > ^1da177e4c3f41 Linus Torvalds 2005-04-16 828 /* enable PCI device */ > > 0e175f665960c7 Takashi Iwai 2021-07-15 829 err = pcim_enable_device(pci); > > 61ea06e8a88163 Takashi Iwai 2021-06-08 830 if (err < 0) > > ^1da177e4c3f41 Linus Torvalds 2005-04-16 831 return err; > > 61ea06e8a88163 Takashi Iwai 2021-06-08 832 > > ^1da177e4c3f41 Linus Torvalds 2005-04-16 833 /* check, if we can restrict PCI DMA transfers to 24 bits */ > > 669f65eaeb969e Takashi Iwai 2021-01-14 834 if (dma_set_mask_and_coherent(&pci->dev, DMA_BIT_MASK(24))) { > > d85d878efb3047 Takashi Iwai 2014-02-25 835 dev_err(&pci->dev, "architecture does not support 24bit PCI busmaster DMA\n"); > > ^1da177e4c3f41 Linus Torvalds 2005-04-16 836 return -ENXIO; > > ^1da177e4c3f41 Linus Torvalds 2005-04-16 837 } > > ^1da177e4c3f41 Linus Torvalds 2005-04-16 838 > > 61ea06e8a88163 Takashi Iwai 2021-06-08 839 err = pci_request_regions(pci, "ALS4000"); > > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > 0e175f665960c7 Takashi Iwai 2021-07-15 840 if (err < 0) > > ^1da177e4c3f41 Linus Torvalds 2005-04-16 841 return err; > > c0874449849175 Andreas Mohr 2008-08-20 842 iobase = pci_resource_start(pci, 0); > > ^1da177e4c3f41 Linus Torvalds 2005-04-16 843 > > ^1da177e4c3f41 Linus Torvalds 2005-04-16 844 pci_read_config_word(pci, PCI_COMMAND, &word); > > ^1da177e4c3f41 Linus Torvalds 2005-04-16 845 pci_write_config_word(pci, PCI_COMMAND, word | PCI_COMMAND_IO); > > ^1da177e4c3f41 Linus Torvalds 2005-04-16 846 pci_set_master(pci); > > ^1da177e4c3f41 Linus Torvalds 2005-04-16 847 > > 0e175f665960c7 Takashi Iwai 2021-07-15 848 err = snd_devm_card_new(&pci->dev, index[dev], id[dev], THIS_MODULE, > > e58de7baf7de11 Takashi Iwai 2008-12-28 849 sizeof(*acard) /* private_data: acard */, > > e58de7baf7de11 Takashi Iwai 2008-12-28 850 &card); > > 0e175f665960c7 Takashi Iwai 2021-07-15 851 if (err < 0) > > e58de7baf7de11 Takashi Iwai 2008-12-28 852 return err; > > ^^^^^^^^^^ > > Smatch complains because there is no error handling. Maybe the other > > error paths use devm_ magic? Or more likely Smatch just isn't smart > > enough... > > I believe those are false-positive. > > When the PCI device is already managed via pcim_enable_device(), all > resources (even the ones without pcim_ or devm_) are freed > automagically. Thanks! I've marked everything after pcim_enable_device or pci_enable_device() as managed (will push later). regards, dan carpenter