From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9827EC4320A for ; Mon, 2 Aug 2021 20:41:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 258A760F93 for ; Mon, 2 Aug 2021 20:41:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 258A760F93 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id B0CDC6B0033; Mon, 2 Aug 2021 16:41:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ABD2B6B0036; Mon, 2 Aug 2021 16:41:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9AB7C6B005D; Mon, 2 Aug 2021 16:41:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0150.hostedemail.com [216.40.44.150]) by kanga.kvack.org (Postfix) with ESMTP id 7CE566B0033 for ; Mon, 2 Aug 2021 16:41:43 -0400 (EDT) Received: from smtpin39.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 2BA421813F575 for ; Mon, 2 Aug 2021 20:41:43 +0000 (UTC) X-FDA: 78431311686.39.3183356 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf18.hostedemail.com (Postfix) with ESMTP id CECF64003321 for ; Mon, 2 Aug 2021 20:41:42 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 9936260F35; Mon, 2 Aug 2021 20:41:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1627936902; bh=mD2GlJ7qH0mW1hEmSzx38bjvmcCI51oF/MKdQrW9HmU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=1JTdIkjiyweXRbNQAEN28NLpa5d8t+1ZUkAsnz3nmXFhOSTwSra+EzKTAU/8H0jqg L8vmi7MQk4/BZlCyXJkei2xPkwoMybAKXl1T4b/e9SroNjP/dc4bb/hiIUMlXO/UBm W0qE/aeML0YzE8KUtr+Ov3bF70Ndb/62dDcFyN3Y= Date: Mon, 2 Aug 2021 13:41:41 -0700 From: Andrew Morton To: Charan Teja Kalla Cc: Mike Rapoport , mcgrof@kernel.org, keescook@chromium.org, yzaikin@google.com, dave.hansen@linux.intel.com, vbabka@suse.cz, mgorman@techsingularity.net, nigupta@nvidia.com, corbet@lwn.net, khalid.aziz@oracle.com, rientjes@google.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, vinmenon@codeaurora.org Subject: Re: [PATCH V5] mm: compaction: support triggering of proactive compaction by user Message-Id: <20210802134141.dbff2d5f850bbe84f3bef4d5@linux-foundation.org> In-Reply-To: <1089d373-221e-7094-b778-ac260ca139a5@codeaurora.org> References: <1627653207-12317-1-git-send-email-charante@codeaurora.org> <1089d373-221e-7094-b778-ac260ca139a5@codeaurora.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=1JTdIkji; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: CECF64003321 X-Stat-Signature: 1bjr4aja81in7bmoxfbarkmhak8nw59p X-HE-Tag: 1627936902-767345 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 2 Aug 2021 17:30:16 +0530 Charan Teja Kalla wrote: > Thanks Mike for the review!! > > On 7/31/2021 1:01 AM, Mike Rapoport wrote: > >> diff --git a/Documentation/admin-guide/sysctl/vm.rst b/Documentation/admin-guide/sysctl/vm.rst > >> index 003d5cc..b526cf6 100644 > >> --- a/Documentation/admin-guide/sysctl/vm.rst > >> +++ b/Documentation/admin-guide/sysctl/vm.rst > >> @@ -118,7 +118,8 @@ compaction_proactiveness > >> > >> This tunable takes a value in the range [0, 100] with a default value of > >> 20. This tunable determines how aggressively compaction is done in the > >> -background. Setting it to 0 disables proactive compaction. > >> +background. On write of non zero value to this tunable will immediately > > Nit: I think "Write of non zero ..." > > Can Andrew change it while applying the patch ? I have done so, thanks.