From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1CDFC4338F for ; Mon, 2 Aug 2021 15:12:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 03FCE610FB for ; Mon, 2 Aug 2021 15:12:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 03FCE610FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 702696B005D; Mon, 2 Aug 2021 11:12:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B1A36B006C; Mon, 2 Aug 2021 11:12:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A01E6B0070; Mon, 2 Aug 2021 11:12:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0137.hostedemail.com [216.40.44.137]) by kanga.kvack.org (Postfix) with ESMTP id 3D2486B005D for ; Mon, 2 Aug 2021 11:12:55 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id EBE8A1E4F0 for ; Mon, 2 Aug 2021 15:12:54 +0000 (UTC) X-FDA: 78430483068.02.E4291EC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 9ED26D009340 for ; Mon, 2 Aug 2021 15:12:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627917174; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FlQM01HNtSla1rT64ZaWW6Fmv7bpSqm5nw3CEk/DlHw=; b=h/DZQPVsDZTSdIGrSj6m0G27LMSHabo+WuW7xhuKV98DIgKiwRJkcoq1OQGcdw0jEsoWLa IF8bouUbrlP45KJoZJL0bBmSP0ykZR2vZKvRptwtmUuRtD7aZIT8sPfxzjvbvgIo4kC+eK B29HOb1MV5ILWPZrhkUMDoX2qLR3YQY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-184-cmMN_Ut6P_aC9Fn1kCcweA-1; Mon, 02 Aug 2021 11:12:53 -0400 X-MC-Unique: cmMN_Ut6P_aC9Fn1kCcweA-1 Received: by mail-wm1-f71.google.com with SMTP id a197-20020a1c98ce0000b029025831695a2eso2138038wme.4 for ; Mon, 02 Aug 2021 08:12:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FlQM01HNtSla1rT64ZaWW6Fmv7bpSqm5nw3CEk/DlHw=; b=fzEF+YzMXIHSrSYJYCGa+RR0kkiuejoroXI7zn4mOLXVItrkX5UrgtHjyq7gjjPtJY 9AzAs/yvGd9kh/PeAYQx+F1MaxjE2JzB+hv7ekm18VtqHRhsB4P0/1XcpSORC1Yp9lZs ljp85rV3PxQTvWlRiga82J8+SX6L50JJzkp+Z50B8Ot2ZXzoxb5DI9fxZ378G3T6FHgs 5K4updH7J4odgNSrfmciftz5z/3yYiO9O3YlOOQ6r8v8WOzDgrOJL3DU4tVlzEBRB3Pv h6rom5++oXoZ17NkZ8SCdMXvYqLiYshZVXuURsxioLZa7hMKJ3gHsctAvIEyqzeAA/wI 6Z1w== X-Gm-Message-State: AOAM532TP6xpeh85x8Ehj8UDhum4uC3RHSA4WXJ5d9XdXLYYakioLmoY W88K9F39ir2fNks+6BeZF5pQxGpTO1AHWh2veGLsoF6UvZaU4WpdQCt0SXylN8FAohGEMSDkZdn J7Fs5c7n8Ww== X-Received: by 2002:adf:9d88:: with SMTP id p8mr18813284wre.409.1627917171941; Mon, 02 Aug 2021 08:12:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxER3KiFPE1LkWXXA8ZvTD5NMlwB/glpb57kT+jyibKqXepxR3M+pdxJqdmDMjGMOojTxDKGw== X-Received: by 2002:adf:9d88:: with SMTP id p8mr18813247wre.409.1627917171555; Mon, 02 Aug 2021 08:12:51 -0700 (PDT) Received: from localhost (79-67-181-135.dynamic.dsl.as9105.com. [79.67.181.135]) by smtp.gmail.com with ESMTPSA id j14sm11695291wru.58.2021.08.02.08.12.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Aug 2021 08:12:50 -0700 (PDT) Date: Mon, 2 Aug 2021 16:12:50 +0100 From: Aaron Tomlin To: Michal Hocko Cc: linux-mm@kvack.org, akpm@linux-foundation.org, penguin-kernel@i-love.sakura.ne.jp, rientjes@google.com, llong@redhat.com, neelx@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] mm/oom_kill: show oom eligibility when displaying the current memory state of all tasks Message-ID: <20210802151250.lqn5fu5pioygsry6@ava.usersys.com> X-PGP-Key: http://pgp.mit.edu/pks/lookup?search=atomlin%40redhat.com X-PGP-Fingerprint: 7906 84EB FA8A 9638 8D1E 6E9B E2DE 9658 19CC 77D6 References: <20210730162002.279678-1-atomlin@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="h/DZQPVs"; spf=none (imf21.hostedemail.com: domain of atomlin@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=atomlin@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 9ED26D009340 X-Stat-Signature: 6a8aoc5dg9onokcpf9h9qp89kypmoihj X-HE-Tag: 1627917174-604541 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 2021-08-02 08:34 +0200, Michal Hocko wrote: > If you really want/need to make any change here then I would propose to > either add E(eligible)/I(ligible) column without any specifics or > consistently skip over all tasks which are not eligible. How about the suggestion made by David i.e. exposing the value returned by oom_badness(), as if I understand correctly, this would provide a more complete picture with regard to the rationale used? Kind regards, -- Aaron Tomlin