From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9424EC4338F for ; Wed, 4 Aug 2021 14:27:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1DEEE60F58 for ; Wed, 4 Aug 2021 14:27:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1DEEE60F58 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 846158D0001; Wed, 4 Aug 2021 10:27:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F7798D0006; Wed, 4 Aug 2021 10:27:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6EF3A8D0001; Wed, 4 Aug 2021 10:27:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0092.hostedemail.com [216.40.44.92]) by kanga.kvack.org (Postfix) with ESMTP id 5449F8D0001 for ; Wed, 4 Aug 2021 10:27:28 -0400 (EDT) Received: from smtpin40.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D8562182321AE for ; Wed, 4 Aug 2021 14:27:27 +0000 (UTC) X-FDA: 78437626134.40.6590B43 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by imf15.hostedemail.com (Postfix) with ESMTP id 924F6D007483 for ; Wed, 4 Aug 2021 14:27:27 +0000 (UTC) Received: by mail-lf1-f42.google.com with SMTP id f42so4772602lfv.7 for ; Wed, 04 Aug 2021 07:27:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Fr1dlkP7aFQI9DYigYyNmGxFZWQyXPk3bpvn9aswro8=; b=iz9UcP0VtZwV4HRpoR3PmJs1KkVe84VAxO68pKZ56paLeYA9CTDEe/zYwQoWIeBD33 5C2dKTlCMuKWhM1PEISSKnBPM0776RaCfebEoJjtBvtX5WGrc7rYCsNcav2jkd3cilE1 LkMBrnc8YDcgK1f7vCTf7pMPFCpSZQYQDclSI6UyqSpQBrQhrpGZn7V7sMAzstPh25L6 oCK/mPOuAOdoLkcrQCE/gksXYd3bi3FyCayAVnrkyAVxo1H1zJxnnDTrCdGvwNek+Hot 8PVOKMXFNOoYsglcaHQXudaWQg5Nlq87s/796svBpfYIaXLlnyuQaAoZaUKX89XCR9z7 DhCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Fr1dlkP7aFQI9DYigYyNmGxFZWQyXPk3bpvn9aswro8=; b=RvWwEbeOc05diikDV/72ElxtXh/21eSdIX6HQ6n2lgVvkSFaMGiMqbzCs5VMTv7k/L tFwRDp3VPGURX7vNYvJVmApe8fgK95WNaeZyOJ4VUqhLiaXSFyzgnDfgzzBSI685pCNS 4fTgDKEhozSMVUo+//Ma2vTHQnjfNcH4WwVqyvpaSzYZg0f3+jpcNFM295Uyu9Rn8+WT WkaqOq7f2NyZ+S/1d1IXnzmGhSKELWk1ymb5MJh4RzLFyvLX00Y8sPikky9gY4kpChV0 acXLwbe6wOogpRxxU1zMYyo3qiXOJ7FWGVMgoRd4z/h9or3qlsd68pkieeJO4OdIwRAr 2Txw== X-Gm-Message-State: AOAM532JA8ds9greNMl4ptbV6NoolGq+qhrNfbTZnMZIXf/HEWrurRNQ QrKJfv2QF6qtm3oMo5yARdMI1g== X-Google-Smtp-Source: ABdhPJzEQAJa0G3rHllX/HPZXIaY9pF/05SryXj38Qjqy7g4DANEptyFwwi8wGn2BeiYxO2nEuwXhw== X-Received: by 2002:a05:6512:2291:: with SMTP id f17mr15294373lfu.593.1628087246346; Wed, 04 Aug 2021 07:27:26 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id r11sm182980ljp.135.2021.08.04.07.27.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Aug 2021 07:27:25 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id D0E11102BC1; Wed, 4 Aug 2021 17:27:29 +0300 (+03) Date: Wed, 4 Aug 2021 17:27:29 +0300 From: "Kirill A. Shutemov" To: Yu Zhao Cc: linux-mm@kvack.org, Andrew Morton , Hugh Dickins , "Kirill A . Shutemov" , Matthew Wilcox , Vlastimil Babka , Yang Shi , Zi Yan , linux-kernel@vger.kernel.org, Shuang Zhai Subject: Re: [PATCH 3/3] mm: don't remap clean subpages when splitting isolated thp Message-ID: <20210804142729.iqtslnn3utvqgec3@box.shutemov.name> References: <20210731063938.1391602-1-yuzhao@google.com> <20210731063938.1391602-4-yuzhao@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210731063938.1391602-4-yuzhao@google.com> Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=shutemov-name.20150623.gappssmtp.com header.s=20150623 header.b=iz9UcP0V; spf=none (imf15.hostedemail.com: domain of kirill@shutemov.name has no SPF policy when checking 209.85.167.42) smtp.mailfrom=kirill@shutemov.name; dmarc=none X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 924F6D007483 X-Stat-Signature: 8xqc6g4d4qy4nt9fb1wuxxhjk3gcxiea X-HE-Tag: 1628087247-579952 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jul 31, 2021 at 12:39:38AM -0600, Yu Zhao wrote: > @@ -267,13 +308,19 @@ static bool remove_migration_pte(struct page *page, struct vm_area_struct *vma, > * Get rid of all migration entries and replace them by > * references to the indicated page. > */ > -void remove_migration_ptes(struct page *old, struct page *new, bool locked) > +void remove_migration_ptes(struct page *old, struct page *new, bool locked, bool unmap_clean) > { > + struct rmap_walk_arg rmap_walk_arg = { > + .page = old, > + .unmap_clean = unmap_clean, > + }; > struct rmap_walk_control rwc = { > .rmap_one = remove_migration_pte, > - .arg = old, > + .arg = &rmap_walk_arg, > }; 'old' pointer has few low always-zero bit :P -- Kirill A. Shutemov