From: Nathan Chancellor <nathan@kernel.org>
To: feng.tang@intel.com
Cc: aarcange@redhat.com, ak@linux.intel.com,
akpm@linux-foundation.org, ben.widawsky@intel.com,
dan.j.williams@intel.com, dave.hansen@intel.com,
linux-api@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, mgorman@techsingularity.net, mhocko@suse.com,
mike.kravetz@oracle.com, rdunlap@infradead.org,
rientjes@google.com, vbabka@suse.cz, ying.huang@intel.com,
Nathan Chancellor <nathan@kernel.org>
Subject: [PATCH] mm/hugetlb: Initialize page to NULL in alloc_buddy_huge_page_with_mpol()
Date: Tue, 10 Aug 2021 13:06:32 -0700 [thread overview]
Message-ID: <20210810200632.3812797-1-nathan@kernel.org> (raw)
In-Reply-To: <20210809024430.GA46432@shbuild999.sh.intel.com>
Clang warns:
mm/hugetlb.c:2162:6: warning: variable 'page' is used uninitialized
whenever 'if' condition is false [-Wsometimes-uninitialized]
if (mpol_is_preferred_many(mpol)) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
mm/hugetlb.c:2172:7: note: uninitialized use occurs here
if (!page)
^~~~
mm/hugetlb.c:2162:2: note: remove the 'if' if its condition is always
true
if (mpol_is_preferred_many(mpol)) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
mm/hugetlb.c:2155:19: note: initialize the variable 'page' to silence
this warning
struct page *page;
^
= NULL
1 warning generated.
Initialize page to NULL like in dequeue_huge_page_vma() so that page is
not used uninitialized.
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
mm/hugetlb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 3d9cd2722ea5..604e2d6bd506 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -2152,7 +2152,7 @@ static
struct page *alloc_buddy_huge_page_with_mpol(struct hstate *h,
struct vm_area_struct *vma, unsigned long addr)
{
- struct page *page;
+ struct page *page = NULL;
struct mempolicy *mpol;
gfp_t gfp_mask = htlb_alloc_mask(h);
int nid;
base-commit: 18f73b217b4633e27a61832e1485ce927a8ee5c1
--
2.33.0.rc1
next prev parent reply other threads:[~2021-08-10 20:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 5:59 [PATCH v7 0/5] Introduce multi-preference mempolicy Feng Tang
2021-08-03 5:59 ` [PATCH v7 1/5] mm/mempolicy: Add MPOL_PREFERRED_MANY for multiple preferred nodes Feng Tang
2021-08-06 13:27 ` Michal Hocko
2021-08-06 13:28 ` Michal Hocko
2021-08-03 5:59 ` [PATCH v7 2/5] mm/memplicy: add page allocation function for MPOL_PREFERRED_MANY policy Feng Tang
2021-08-06 13:29 ` Michal Hocko
2021-08-03 5:59 ` [PATCH v7 3/5] mm/hugetlb: add support for mempolicy MPOL_PREFERRED_MANY Feng Tang
2021-08-06 13:35 ` Michal Hocko
2021-08-09 2:44 ` Feng Tang
2021-08-09 8:41 ` Michal Hocko
2021-08-09 12:37 ` Feng Tang
2021-08-09 13:19 ` Michal Hocko
2021-08-10 8:50 ` Feng Tang
2021-08-10 21:35 ` Hugh Dickins
2021-08-11 1:37 ` Feng Tang
2021-08-10 20:06 ` Nathan Chancellor [this message]
2021-08-11 1:21 ` [PATCH] mm/hugetlb: Initialize page to NULL in alloc_buddy_huge_page_with_mpol() Feng Tang
2021-08-03 5:59 ` [PATCH v7 4/5] mm/mempolicy: Advertise new MPOL_PREFERRED_MANY Feng Tang
2021-08-03 5:59 ` [PATCH v7 5/5] mm/mempolicy: unify the create() func for bind/interleave/prefer-many policies Feng Tang
2021-12-01 3:09 ` [PATCH v7 0/5] Introduce multi-preference mempolicy Gang Li
2021-12-01 5:33 ` Feng Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210810200632.3812797-1-nathan@kernel.org \
--to=nathan@kernel.org \
--cc=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=ben.widawsky@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@intel.com \
--cc=feng.tang@intel.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=mike.kravetz@oracle.com \
--cc=rdunlap@infradead.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).