From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E1EDC4320A for ; Tue, 17 Aug 2021 00:05:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E31CF60F55 for ; Tue, 17 Aug 2021 00:05:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E31CF60F55 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 57E026B0072; Mon, 16 Aug 2021 20:05:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 52DAE6B0073; Mon, 16 Aug 2021 20:05:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 443116B0074; Mon, 16 Aug 2021 20:05:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0044.hostedemail.com [216.40.44.44]) by kanga.kvack.org (Postfix) with ESMTP id 265E76B0072 for ; Mon, 16 Aug 2021 20:05:13 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B57B38249980 for ; Tue, 17 Aug 2021 00:05:12 +0000 (UTC) X-FDA: 78482627664.18.4CBF957 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf26.hostedemail.com (Postfix) with ESMTP id 46102201656B for ; Tue, 17 Aug 2021 00:05:12 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 2C6C760F22; Tue, 17 Aug 2021 00:05:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1629158711; bh=2OJ0LsoSrf538Q5c/S7qJehWhX5paGixgZ1CKl5616E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Fa5lZzolnJig0lmKA5WkVVmiGlNN0shn2RvzIKaY6XtOU8HF+5oMmf3sYKBt2IN0f aZVCWnWRF1M/bsSdXyBQhZREKKLzrG/kk3tdyGncsWfLoLtcyP/FKEQSK8oQjV/38L 7b3kJ6kQDoqgEwNqcfDmlK/nxaFLHSoENmdQtIJQ= Date: Mon, 16 Aug 2021 17:05:10 -0700 From: Andrew Morton To: Mike Rapoport Cc: Mike Rapoport , Peter Collingbourne , Steven Rostedt , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mmflags.h: add missing __GFP_ZEROTAGS and __GFP_SKIP_KASAN_POISON names Message-Id: <20210816170510.9d6afcd53c767397aba758ef@linux-foundation.org> In-Reply-To: <20210816133502.590-1-rppt@kernel.org> References: <20210816133502.590-1-rppt@kernel.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 46102201656B Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=Fa5lZzol; dmarc=none; spf=pass (imf26.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspamd-Server: rspam04 X-Stat-Signature: yjqha1kg7uprh69s3xyj9s4tp9w4egya X-HE-Tag: 1629158712-690395 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 16 Aug 2021 16:35:02 +0300 Mike Rapoport wrote: > From: Mike Rapoport > > Add missing names of __GFP_ZEROTAGS and __GFP_SKIP_KASAN_POISON flags to > __def_gfpflag_names. > > Fixes: 013bb59dbb7c ("arm64: mte: handle tags zeroing at page allocation time") > Fixes: c275c5c6d50a ("kasan: disable freed user page poisoning with HW tags") "fixes" in what way? ie, what problems were caused by the above commits? > --- a/include/trace/events/mmflags.h > +++ b/include/trace/events/mmflags.h > @@ -48,7 +48,9 @@ > {(unsigned long)__GFP_WRITE, "__GFP_WRITE"}, \ > {(unsigned long)__GFP_RECLAIM, "__GFP_RECLAIM"}, \ > {(unsigned long)__GFP_DIRECT_RECLAIM, "__GFP_DIRECT_RECLAIM"},\ > - {(unsigned long)__GFP_KSWAPD_RECLAIM, "__GFP_KSWAPD_RECLAIM"}\ > + {(unsigned long)__GFP_KSWAPD_RECLAIM, "__GFP_KSWAPD_RECLAIM"},\ > + {(unsigned long)__GFP_ZEROTAGS, "__GFP_ZEROTAGS"}, \ > + {(unsigned long)__GFP_SKIP_KASAN_POISON,"__GFP_SKIP_KASAN_POISON"}\ > > #define show_gfp_flags(flags) \ > (flags) ? __print_flags(flags, "|", \ I'm guessing that the tracing output was messed up in some fashion?