From: Pavel Machek <email@example.com> To: Evan Green <firstname.lastname@example.org> Cc: Andrew Morton <email@example.com>, David Hildenbrand <firstname.lastname@example.org>, Michal Hocko <email@example.com>, firstname.lastname@example.org, Alex Shi <email@example.com>, Alistair Popple <firstname.lastname@example.org>, Johannes Weiner <email@example.com>, Joonsoo Kim <firstname.lastname@example.org>, "Matthew Wilcox (Oracle)" <email@example.com>, Miaohe Lin <firstname.lastname@example.org>, Minchan Kim <email@example.com>, Suren Baghdasaryan <firstname.lastname@example.org>, Vlastimil Babka <email@example.com>, LKML <firstname.lastname@example.org>, email@example.com Subject: Re: [PATCH v4] mm: Enable suspend-only swap spaces Date: Tue, 17 Aug 2021 20:32:33 +0200 [thread overview] Message-ID: <20210817183233.GA14518@amd> (raw) In-Reply-To: <CAE=gft6LmTKx2JHAj7GBmph_1BrioXhmtn_xQEHtRhK+tPa6qw@mail.gmail.com> [-- Attachment #1: Type: text/plain, Size: 1458 bytes --] Hi! > > > > Pavel just mentioned uswsusp, and I wonder if it would be a possible > > > > alternative to this patch. > > > > > > I think you're right that it would be possible to isolate the > > > hibernate image with uswsusp if you avoid using the SNAPSHOT_*SWAP* > > > ioctls. But I'd expect performance to suffer noticeably, since now > > > every page is making a round trip out to usermode and back. I'd still > > > very much use the HIBERNATE_ONLY flag if it were accepted, I think > > > there's value to it. > > > > The uswsusp option makes your patch a performance optimization rather > > than a feature-add. And we do like to see quantitative testing results > > when considering a performance optimization. Especially when the > > performance optimization is a bit icky, putting special-case testing > > all over the place, maintenance cost, additional testing effort, etc. > > > > I do think that diligence demands that we quantify the difference. Is > > this a thing you can help with? > > I'm wrong about the performance. Uswsusp is just as fast, and possibly > faster in my use case than kernel-driven hibernate. What's more, > uswsusp also helps me solve several additional problems I hadn't > tackled yet that were looming in front of me. Thanks all for your > patience and thoughtful review on this. Great to see uswsusp being used :-). Thanks, Pavel -- http://www.livejournal.com/~pavelmachek [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2021-08-17 18:32 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-27 0:12 Evan Green 2021-07-27 9:48 ` David Hildenbrand 2021-07-27 12:21 ` David Hildenbrand 2021-07-27 16:31 ` Evan Green 2021-07-27 21:18 ` Andrew Morton 2021-08-03 18:00 ` Evan Green 2021-08-17 18:32 ` Pavel Machek [this message] 2021-07-30 13:15 ` Karel Zak
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210817183233.GA14518@amd \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH v4] mm: Enable suspend-only swap spaces' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).