From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0F95C432BE for ; Thu, 19 Aug 2021 16:31:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6F16561053 for ; Thu, 19 Aug 2021 16:31:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6F16561053 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id C4B4F6B0071; Thu, 19 Aug 2021 12:31:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BFB566B0072; Thu, 19 Aug 2021 12:31:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AEA368D0001; Thu, 19 Aug 2021 12:31:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0175.hostedemail.com [216.40.44.175]) by kanga.kvack.org (Postfix) with ESMTP id 94E7A6B0071 for ; Thu, 19 Aug 2021 12:31:21 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 402F5276E2 for ; Thu, 19 Aug 2021 16:31:21 +0000 (UTC) X-FDA: 78492370362.15.FCDF9A3 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by imf07.hostedemail.com (Postfix) with ESMTP id D5DC910000BD for ; Thu, 19 Aug 2021 16:31:20 +0000 (UTC) Received: from sequoia (162-237-133-238.lightspeed.rcsntx.sbcglobal.net [162.237.133.238]) by linux.microsoft.com (Postfix) with ESMTPSA id 9F73120C33AB; Thu, 19 Aug 2021 09:31:19 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 9F73120C33AB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1629390680; bh=eFnGA7aTFvV9qos28eC0ycF0DWMWjw0868jCFwuvfyY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pQ+oskSqprZNM1bxRvlrdH/ZXwPkpmM/0FqwBQIFHOOnXZ5MT1NZeyrIHWczzNDCG KgIkZx6hc116S8XuUkWThSry9PkVZRE7VNb92ea46J3aBPwDw6ZNCFtCzx9//F+mOM 6BHruu1p7NB22XyzF+jr1leb9WzzCyW2OafkKDAo= Date: Thu, 19 Aug 2021 11:31:17 -0500 From: Tyler Hicks To: Zhansaya Bagdauletkyzy Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, pasha.tatashin@soleen.com Subject: Re: [PATCH v3 2/2] selftests: vm: add COW time test for KSM pages Message-ID: <20210819163117.GO5469@sequoia> References: <1d03ee0d1b341959d4b61672c6401d498bff5652.1629386192.git.zhansayabagdaulet@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1d03ee0d1b341959d4b61672c6401d498bff5652.1629386192.git.zhansayabagdaulet@gmail.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: D5DC910000BD X-Stat-Signature: wttjsjn9dmoh47xnxisjrsetqaaw6x6g Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=linux.microsoft.com header.s=default header.b=pQ+oskSq; dmarc=pass (policy=none) header.from=linux.microsoft.com; spf=pass (imf07.hostedemail.com: domain of tyhicks@linux.microsoft.com designates 13.77.154.182 as permitted sender) smtp.mailfrom=tyhicks@linux.microsoft.com X-HE-Tag: 1629390680-699397 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2021-08-19 21:33:43, Zhansaya Bagdauletkyzy wrote: > Since merged pages are copied every time they need to be modified, > the write access time is different between shared and non-shared pages. > Add ksm_cow_time() function which evaluates latency of these COW > breaks. First, 4000 pages are allocated and the time, required to modify > 1 byte in every other page, is measured. After this, the pages are > merged into 2000 pairs and in each pair, 1 page is modified (i.e. they > are decoupled) to detect COW breaks. The time needed to break COW of > merged pages is then compared with performance of non-shared pages. > > The test is run as follows: ./ksm_tests -C > The output: > Total size: 15 MiB > > Not merged pages: > Total time: 0.002185489 s > Average speed: 3202.945 MiB/s > > Merged pages: > Total time: 0.004386872 s > Average speed: 1595.670 MiB/s > > Signed-off-by: Zhansaya Bagdauletkyzy > --- > v2 -> v3: > - address Tyler's feedback Thanks for incorporating my suggestions! I can confirm that my feedback was completely addressed. Reviewed-by: Tyler Hicks Tyler > > Tyler's comments: https://lkml.org/lkml/2021/8/16/931 > > v1 -> v2: > As suggested by Pavel, > - add baseline figures with non-shared pages > - instead of having all pages merged together, create pairs of > duplicated pages > > Pavel's comments: https://lkml.org/lkml/2021/8/3/1363 > > tools/testing/selftests/vm/ksm_tests.c | 86 +++++++++++++++++++++++++- > 1 file changed, 83 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/vm/ksm_tests.c b/tools/testing/selftests/vm/ksm_tests.c > index 432dfe615e50..c14927417759 100644 > --- a/tools/testing/selftests/vm/ksm_tests.c > +++ b/tools/testing/selftests/vm/ksm_tests.c > @@ -33,7 +33,8 @@ enum ksm_test_name { > CHECK_KSM_UNMERGE, > CHECK_KSM_ZERO_PAGE_MERGE, > CHECK_KSM_NUMA_MERGE, > - KSM_MERGE_TIME > + KSM_MERGE_TIME, > + KSM_COW_TIME > }; > > static int ksm_write_sysfs(const char *file_path, unsigned long val) > @@ -98,7 +99,8 @@ static void print_help(void) > " -U (page unmerging)\n" > " -P evaluate merging time and speed.\n" > " For this test, the size of duplicated memory area (in MiB)\n" > - " must be provided using -s option\n\n"); > + " must be provided using -s option\n" > + " -C evaluate the time required to break COW of merged pages.\n\n"); > > printf(" -a: specify the access protections of pages.\n" > " must be of the form [rwx].\n" > @@ -455,6 +457,77 @@ static int ksm_merge_time(int mapping, int prot, int timeout, size_t map_size) > return KSFT_FAIL; > } > > +static int ksm_cow_time(int mapping, int prot, int timeout, size_t page_size) > +{ > + void *map_ptr; > + struct timespec start_time, end_time; > + unsigned long cow_time_ns; > + > + /* page_count must be less than 2*page_size */ > + size_t page_count = 4000; > + > + map_ptr = allocate_memory(NULL, prot, mapping, '*', page_size * page_count); > + if (!map_ptr) > + return KSFT_FAIL; > + > + if (clock_gettime(CLOCK_MONOTONIC_RAW, &start_time)) { > + perror("clock_gettime"); > + return KSFT_FAIL; > + } > + for (size_t i = 0; i < page_count - 1; i = i + 2) > + memset(map_ptr + page_size * i, '-', 1); > + if (clock_gettime(CLOCK_MONOTONIC_RAW, &end_time)) { > + perror("clock_gettime"); > + return KSFT_FAIL; > + } > + > + cow_time_ns = (end_time.tv_sec - start_time.tv_sec) * NSEC_PER_SEC + > + (end_time.tv_nsec - start_time.tv_nsec); > + > + printf("Total size: %lu MiB\n\n", (page_size * page_count) / MB); > + printf("Not merged pages:\n"); > + printf("Total time: %ld.%09ld s\n", cow_time_ns / NSEC_PER_SEC, > + cow_time_ns % NSEC_PER_SEC); > + printf("Average speed: %.3f MiB/s\n\n", ((page_size * (page_count / 2)) / MB) / > + ((double)cow_time_ns / NSEC_PER_SEC)); > + > + /* Create 2000 pairs of duplicate pages */ > + for (size_t i = 0; i < page_count - 1; i = i + 2) { > + memset(map_ptr + page_size * i, '+', i / 2 + 1); > + memset(map_ptr + page_size * (i + 1), '+', i / 2 + 1); > + } > + if (ksm_merge_pages(map_ptr, page_size * page_count, start_time, timeout)) > + goto err_out; > + > + if (clock_gettime(CLOCK_MONOTONIC_RAW, &start_time)) { > + perror("clock_gettime"); > + goto err_out; > + } > + for (size_t i = 0; i < page_count - 1; i = i + 2) > + memset(map_ptr + page_size * i, '-', 1); > + if (clock_gettime(CLOCK_MONOTONIC_RAW, &end_time)) { > + perror("clock_gettime"); > + goto err_out; > + } > + > + cow_time_ns = (end_time.tv_sec - start_time.tv_sec) * NSEC_PER_SEC + > + (end_time.tv_nsec - start_time.tv_nsec); > + > + printf("Merged pages:\n"); > + printf("Total time: %ld.%09ld s\n", cow_time_ns / NSEC_PER_SEC, > + cow_time_ns % NSEC_PER_SEC); > + printf("Average speed: %.3f MiB/s\n", ((page_size * (page_count / 2)) / MB) / > + ((double)cow_time_ns / NSEC_PER_SEC)); > + > + munmap(map_ptr, page_size * page_count); > + return KSFT_PASS; > + > +err_out: > + printf("Not OK\n"); > + munmap(map_ptr, page_size * page_count); > + return KSFT_FAIL; > +} > + > int main(int argc, char *argv[]) > { > int ret, opt; > @@ -468,7 +541,7 @@ int main(int argc, char *argv[]) > bool merge_across_nodes = KSM_MERGE_ACROSS_NODES_DEFAULT; > long size_MB = 0; > > - while ((opt = getopt(argc, argv, "ha:p:l:z:m:s:MUZNP")) != -1) { > + while ((opt = getopt(argc, argv, "ha:p:l:z:m:s:MUZNPC")) != -1) { > switch (opt) { > case 'a': > prot = str_to_prot(optarg); > @@ -522,6 +595,9 @@ int main(int argc, char *argv[]) > case 'P': > test_name = KSM_MERGE_TIME; > break; > + case 'C': > + test_name = KSM_COW_TIME; > + break; > default: > return KSFT_FAIL; > } > @@ -571,6 +647,10 @@ int main(int argc, char *argv[]) > ret = ksm_merge_time(MAP_PRIVATE | MAP_ANONYMOUS, prot, ksm_scan_limit_sec, > size_MB); > break; > + case KSM_COW_TIME: > + ret = ksm_cow_time(MAP_PRIVATE | MAP_ANONYMOUS, prot, ksm_scan_limit_sec, > + page_size); > + break; > } > > if (ksm_restore(&ksm_sysfs_old)) { > -- > 2.25.1 >