From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DF75C4320E for ; Thu, 26 Aug 2021 00:59:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AEE056102A for ; Thu, 26 Aug 2021 00:59:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AEE056102A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 449896B006C; Wed, 25 Aug 2021 20:59:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FA106B0072; Wed, 25 Aug 2021 20:59:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E8A36B0073; Wed, 25 Aug 2021 20:59:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0192.hostedemail.com [216.40.44.192]) by kanga.kvack.org (Postfix) with ESMTP id 14C266B006C for ; Wed, 25 Aug 2021 20:59:16 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id BE514230FC for ; Thu, 26 Aug 2021 00:59:15 +0000 (UTC) X-FDA: 78515423070.21.6E19104 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf20.hostedemail.com (Postfix) with ESMTP id 61D46D0000AB for ; Thu, 26 Aug 2021 00:59:15 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 636B660F6F; Thu, 26 Aug 2021 00:59:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629939554; bh=EXrb+gVpKlIS/8zNJQMeoK/jfDFoPwPN7MIaRo88m5M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZalcFUQZA0ontYQPUcmHKUZnISqknge/El2n25Na0epoWdBEIgCMlcECF4n5nan5D 9rxjCAMiBuVX+E0WQvgvzkYNmSJjil/P515Ff1oLc0UrsnKXK6vEeIhzRCtIL4Ih0n PYAHN/bnaEGbTEeR/8+zIrlkWphfB0+M8INYGZOSmE/mJfeljMn0TAB8UX8pesIp9S ECB637/fIlSkPc5J/w+AG4bRJQ1CDut2VB6dQyOhOcka7jUovRM3EcPaUbmYU+p4QA tN2yfOSZVveKrHPJwqhuM7aPvub1htWL7NcS+OzmSrAxfRdZjcHEBSkf+fnpzmCWCW JhWIAXMDIApTw== Date: Wed, 25 Aug 2021 17:59:14 -0700 From: "Darrick J. Wong" To: Jeff Layton Cc: Christoph Hellwig , Theodore Ts'o , Matthew Wilcox , Linus Torvalds , David Howells , Johannes Weiner , Linux-MM , linux-fsdevel , Linux Kernel Mailing List , Andrew Morton Subject: Re: [GIT PULL] Memory folios for v5.15 Message-ID: <20210826005914.GG12597@magnolia> References: <1957060.1629820467@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 61D46D0000AB Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ZalcFUQZ; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of djwong@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=djwong@kernel.org X-Rspamd-Server: rspam01 X-Stat-Signature: f5b86x9on8h7mogix8a7cpxuq6crwt5q X-HE-Tag: 1629939555-721942 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 25, 2021 at 08:03:18AM -0400, Jeff Layton wrote: > On Wed, 2021-08-25 at 07:32 +0100, Christoph Hellwig wrote: > > On Tue, Aug 24, 2021 at 03:44:48PM -0400, Theodore Ts'o wrote: > > > The problem is whether we use struct head_page, or folio, or mempages, > > > we're going to be subsystem users' faces. And people who are using it > > > every day will eventually get used to anything, whether it's "folio" > > > or "xmoqax", we sould give a thought to newcomers to Linux file system > > > code. If they see things like "read_folio()", they are going to be > > > far more confused than "read_pages()" or "read_mempages()". > > > > Are they? It's not like page isn't some randomly made up term > > as well, just one that had a lot more time to spread. > > > > Absolutely. "folio" is no worse than "page", we've just had more time > to get used to "page". I /like/ the name 'folio'. My privileged education :P informed me (when Matthew talked to me the very first time about this patchset) that it's a wonderfully flexible word that describes both a collection of various pages and a single large sheet of paper folded in half. Or in the case of x86, folded in half nine times. That's *exactly* the usage that Matthew is proposing. English already had a word ready for us to use, so let's use it. --D (Well, ok, the one thing I dislike is that my brain keeps typing out 'fileio' instead of 'folio', but it's still better than struct xmoqax or remembering if we do camel_case or PotholeCase.) > > > So if someone sees "kmem_cache_alloc()", they can probably make a > > > guess what it means, and it's memorable once they learn it. > > > Similarly, something like "head_page", or "mempages" is going to a bit > > > more obvious to a kernel newbie. So if we can make a tiny gesture > > > towards comprehensibility, it would be good to do so while it's still > > > easier to change the name. > > > > All this sounds really weird to me. I doubt there is any name that > > nicely explains "structure used to manage arbitrary power of two > > units of memory in the kernel" very well. So I agree with willy here, > > let's pick something short and not clumsy. I initially found the folio > > name a little strange, but working with it I got used to it quickly. > > And all the other uggestions I've seen s far are significantly worse, > > especially all the odd compounds with page in it. > > Same here. Compound words are especially bad, as newbies will > continually have to look at whether it's "page_set" or "pageset". > > -- > Jeff Layton >