From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEC92C433F5 for ; Wed, 8 Sep 2021 22:40:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 710046113C for ; Wed, 8 Sep 2021 22:40:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 710046113C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id DD22C900002; Wed, 8 Sep 2021 18:40:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D80CA6B0072; Wed, 8 Sep 2021 18:40:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BFB94900002; Wed, 8 Sep 2021 18:40:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0125.hostedemail.com [216.40.44.125]) by kanga.kvack.org (Postfix) with ESMTP id A8A946B0071 for ; Wed, 8 Sep 2021 18:40:00 -0400 (EDT) Received: from smtpin36.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 5695A1843F4ED for ; Wed, 8 Sep 2021 22:40:00 +0000 (UTC) X-FDA: 78565875360.36.3CC9951 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf25.hostedemail.com (Postfix) with ESMTP id 0D697B000181 for ; Wed, 8 Sep 2021 22:39:59 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id DC66760F5E; Wed, 8 Sep 2021 22:39:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1631140799; bh=er5DLepHHVt09U5Jzu87DfzTI5uefgw4AGP2yz87GcA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WUH9mZ1NDWKr+ERPDRQ4E5IpMIeu1SZI5DD4e+lLjKaEnq0qefJOX5XHXDORxE5qb DRW75dfi/1Wa9wm/V8lhMbHFhdhO0/6/CiUcQJe/4Efp8Ew8gcwtNkdL7TVLz/6zm4 RKgw/gF7pBhyHI2VgfPd8fHLWuIA3RzwYn/Csuck= Date: Wed, 8 Sep 2021 15:39:58 -0700 From: Andrew Morton To: yangerkun Cc: , , , , , , Subject: Re: [PATCH] ramfs: fix mount source show for ramfs Message-Id: <20210908153958.19054d439ae59ee3a7e41519@linux-foundation.org> In-Reply-To: <720f6c7a-6745-98ad-5c71-7747857a7f01@huawei.com> References: <20210811122811.2288041-1-yangerkun@huawei.com> <720f6c7a-6745-98ad-5c71-7747857a7f01@huawei.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Stat-Signature: pnq5hm7xmwg15xmry7kbm1cwmw9pgybf Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=WUH9mZ1N; dmarc=none; spf=pass (imf25.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 0D697B000181 X-HE-Tag: 1631140799-837022 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 8 Sep 2021 16:56:25 +0800 yangerkun wrote: > =E5=9C=A8 2021/8/11 20:28, yangerkun =E5=86=99=E9=81=93: > > ramfs_parse_param does not parse key "source", and will convert > > -ENOPARAM to 0. This will skip vfs_parse_fs_param_source in > > vfs_parse_fs_param, which lead always "none" mount source for ramfs. = Fix > > it by parse "source" in ramfs_parse_param. > >=20 > > Signed-off-by: yangerkun > > --- > > fs/ramfs/inode.c | 4 ++++ > > 1 file changed, 4 insertions(+) > >=20 > > diff --git a/fs/ramfs/inode.c b/fs/ramfs/inode.c > > index 65e7e56005b8..0d7f5f655fd8 100644 > > --- a/fs/ramfs/inode.c > > +++ b/fs/ramfs/inode.c > > @@ -202,6 +202,10 @@ static int ramfs_parse_param(struct fs_context *= fc, struct fs_parameter *param) > > struct ramfs_fs_info *fsi =3D fc->s_fs_info; > > int opt; > > =20 > > + opt =3D vfs_parse_fs_param_source(fc, param); > > + if (opt !=3D -ENOPARAM) > > + return opt; > > + > > opt =3D fs_parse(fc, ramfs_fs_parameters, param, &result); > > if (opt < 0) { > > /* > >=20 (top-posting repaired) > Hi, this patch seems still leave in linux-next, should we pull it to > mainline? I was hoping for a comment from Al?