From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03EBFC433EF for ; Fri, 17 Sep 2021 20:57:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A7C9860FED for ; Fri, 17 Sep 2021 20:57:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A7C9860FED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 5113B6B0072; Fri, 17 Sep 2021 16:57:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 49A0D6B0073; Fri, 17 Sep 2021 16:57:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33BF2900002; Fri, 17 Sep 2021 16:57:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0212.hostedemail.com [216.40.44.212]) by kanga.kvack.org (Postfix) with ESMTP id 240246B0072 for ; Fri, 17 Sep 2021 16:57:40 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id D27878248076 for ; Fri, 17 Sep 2021 20:57:39 +0000 (UTC) X-FDA: 78598276638.02.7472A24 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf11.hostedemail.com (Postfix) with ESMTP id 8EBD3F000207 for ; Fri, 17 Sep 2021 20:57:39 +0000 (UTC) Received: by mail-lf1-f54.google.com with SMTP id x27so38058348lfu.5 for ; Fri, 17 Sep 2021 13:57:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=67xh3DmcBCGG+JgtqbeDJCPPKQGkafOab0xKjSMAcZA=; b=u/akYP8fIr5YX9VRdaEVJHYLd0LzSg00EpqVzqSwjM17eMmXVH4Vt7u55dJWa8zxUz NatucGpPSkbwSP36Zo8i0K+Tdv4MYgV0IB/C8Y1h8sVeFQfotq0CFjm9TF5uRAiK70nI e/zksaD+yvzB/to75omh0tw2JV236bxtkje3LEy0TifQzhUci5ZgWzfaeqgzT42/HlSj pcnjR+YcgyYj9PnIlzHCJsUWc5ZXad3h2vkzZ2KrVaIog3EvfIoCBxsAO0XU25Plpn6c iO6xIkbdg4nNSOTo5H8okK8vCt4llN9fyKMHGUuo3+1cwcSKm/oYiJ8xK7fgFfR8zrvk 3FdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=67xh3DmcBCGG+JgtqbeDJCPPKQGkafOab0xKjSMAcZA=; b=RarsphQuG0ECuuD8HQya8TEeCX65Y3ojz8nIgcAwrWObaGPsNvu/3Gv7a3PKAZyuRH kK+s+tuBk7kbkOONE0tfmVBMKlWROP8NIG1IMN3dUxltJwHf2WoN1hzSA5GJTOub+NlT s/vW9jy2eKGuyHg7Qi89vwBcrpHNOZpIhIS0Xwo+esK2dj1ywN+jVyqHIK9iu5Y0nPH/ S9mj5ScNPkEqHwBuLNWEiMSY9yDn2k+6QtwnjmAqLRoiA+7oZuDdcUUwE5nkBhlMpMbO SUl3A3j1u9zo6497S9ixW74fztVzFLIL8jo5UG+aR2c5wdF0akN5hTYp71MOt4J6D6A6 dTmA== X-Gm-Message-State: AOAM530A6ZJixtuynm/iWR2qi8PK1Zwrz3JEE+5r1zSoaeHjzUwNO3M0 GvGQW9YeWrvypa1wixTkwoS9uQ== X-Google-Smtp-Source: ABdhPJwzRLrammj1aWXBUhzKKoAy7/XvwF3BlowXLWGM9+36v2HXfgkOqKBJbRpX1iY07s9D7jGvhw== X-Received: by 2002:a2e:9903:: with SMTP id v3mr11033539lji.383.1631912257807; Fri, 17 Sep 2021 13:57:37 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id y14sm607162lfk.237.2021.09.17.13.57.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Sep 2021 13:57:36 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 4AFBE103041; Fri, 17 Sep 2021 23:57:35 +0300 (+03) Date: Fri, 17 Sep 2021 23:57:35 +0300 From: "Kirill A. Shutemov" To: Johannes Weiner Cc: Dave Chinner , "Darrick J. Wong" , Kent Overstreet , Matthew Wilcox , Linus Torvalds , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton , Christoph Hellwig , David Howells Subject: Re: Folio discussion recap Message-ID: <20210917205735.tistsacwwzkcdklx@box.shutemov.name> References: <20210916025854.GE34899@magnolia> <20210917052440.GJ1756565@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: 67qkugo3spn5hj4gdowxr5hyxkimxq9w Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=shutemov-name.20210112.gappssmtp.com header.s=20210112 header.b="u/akYP8f"; dmarc=none; spf=none (imf11.hostedemail.com: domain of kirill@shutemov.name has no SPF policy when checking 209.85.167.54) smtp.mailfrom=kirill@shutemov.name X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 8EBD3F000207 X-HE-Tag: 1631912259-460464 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 17, 2021 at 12:31:36PM -0400, Johannes Weiner wrote: > I didn't suggest to change what the folio currently already is for the > page cache. I asked to keep anon pages out of it (and in the future > potentially other random stuff that is using compound pages). It would mean that anon-THP cannot benefit from the work Willy did with folios. Anon-THP is the most active user of compound pages at the moment and it also suffers from the compound_head() plague. You ask to exclude anon-THP siting *possible* future benefits for pagecache. Sorry, but this doesn't sound fair to me. We already had similar experiment with PAGE_CACHE_SIZE. It was introduced with hope to have PAGE_CACHE_SIZE != PAGE_SIZE one day. It never happened and only caused confusion on the border between pagecache-specific code and generic code that handled both file and anon pages. If you want to limit usage of the new type to pagecache, the burden on you to prove that it is useful and not just a dead weight. -- Kirill A. Shutemov