From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3F89C433FE for ; Tue, 21 Sep 2021 19:01:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9989D60FDA for ; Tue, 21 Sep 2021 19:01:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9989D60FDA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id EBDEC940007; Tue, 21 Sep 2021 15:01:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E44FD900002; Tue, 21 Sep 2021 15:01:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C97C0940007; Tue, 21 Sep 2021 15:01:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0121.hostedemail.com [216.40.44.121]) by kanga.kvack.org (Postfix) with ESMTP id B3F51900002 for ; Tue, 21 Sep 2021 15:01:16 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 50DA782499A8 for ; Tue, 21 Sep 2021 19:01:16 +0000 (UTC) X-FDA: 78612498552.11.4B842BE Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by imf16.hostedemail.com (Postfix) with ESMTP id D791AF000097 for ; Tue, 21 Sep 2021 19:01:15 +0000 (UTC) Received: by mail-pg1-f171.google.com with SMTP id g184so36543pgc.6 for ; Tue, 21 Sep 2021 12:01:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=uUvwtgDvS9z+MmLCsIbndyuppV43gHnzlz5qvL6KeNg=; b=c9uP+rap/UfN7fREE6h8u3lsZij8/9nesp5oAq6rWx9xNnYvzMF9PP463fCmsUqDar kEwNNzzupFjl3iVssQImb8bF3h2/B/8MlMGNIDKsuMe9bchBPSyFkLc+uuhUiy9QTIMI 6UVxssDsqkegyngHCgoDjyvtGGXIsR18yy7Rg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=uUvwtgDvS9z+MmLCsIbndyuppV43gHnzlz5qvL6KeNg=; b=HGbMVG8VXtZayzMMvPX4bsDgvzJ/Ud+NhkrNhz482tmrklZq/mUl4HEuidEpr1N61c AmXHH2M5kbAn/Q/T5VjYfSp7HMKR6vWijAW7M2afHNouhhEEAcUDJJkBw0eXbGyt1XAq GyJaE9Sdws4eIToiX/8dE0garPIFccRaHoZnxx4saW/eF6bvP9ca8FcnKmehz0+B/c8W H8/TMh+BcSYNa4TJhrylwT/CWPG44/Yo7R++eNrXdph1WY458AbXON6M2ebI0D8s/wHu 3sd8nGXRRL6jjV2Mg88s01+R1bp3Pf6q4wvPRriYA53BTVpLRNT58MWjTyKUNr0ksn2A Gy3w== X-Gm-Message-State: AOAM530Tc3F0SlEkBudjhaZ4yYd24kuRJiGNUUfKH2q7Lq/JwPe49YuZ vpLlTDOOk849D7aOxaJoJEZk4A== X-Google-Smtp-Source: ABdhPJyhkEtFnUnBg+9qtMK4KmQYa6j/evLKD74iespv+jzZ07EoQOA7rlY7bUrm0t6g+7REwX8YJw== X-Received: by 2002:a63:2cce:: with SMTP id s197mr3869655pgs.45.1632250874538; Tue, 21 Sep 2021 12:01:14 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id t6sm3451285pjr.36.2021.09.21.12.01.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Sep 2021 12:01:13 -0700 (PDT) Date: Tue, 21 Sep 2021 12:01:12 -0700 From: Kees Cook To: Stephen Kitt Cc: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , James Morris , "Serge E . Hallyn" , linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] mm: Remove HARDENED_USERCOPY_FALLBACK Message-ID: <202109211200.14E421C@keescook> References: <20210921061149.1091163-1-steve@sk2.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210921061149.1091163-1-steve@sk2.org> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D791AF000097 X-Stat-Signature: qhzjnqod5powk6gxuoz8ay7hgbp7wm6x Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=c9uP+rap; spf=pass (imf16.hostedemail.com: domain of keescook@chromium.org designates 209.85.215.171 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org X-HE-Tag: 1632250875-279803 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 21, 2021 at 08:11:49AM +0200, Stephen Kitt wrote: > This has served its purpose and is no longer used. All usercopy > violations appear to have been handled by now, any remaining > instances (or new bugs) will cause copies to be rejected. > > This isn't a direct revert of commit 2d891fbc3bb6 ("usercopy: Allow > strict enforcement of whitelists"); since usercopy_fallback is > effectively 0, the fallback handling is removed too. > > This also removes the usercopy_fallback module parameter on > slab_common. > > Link: https://github.com/KSPP/linux/issues/153 > Signed-off-by: Stephen Kitt > Suggested-by: Kees Cook Thanks for doing this! Acked-by: Kees Cook -- Kees Cook