From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 643C0C433FE for ; Fri, 8 Oct 2021 13:54:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 19B8261073 for ; Fri, 8 Oct 2021 13:54:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 19B8261073 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=techsingularity.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id BAE6B6B0071; Fri, 8 Oct 2021 09:54:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B5EC46B007D; Fri, 8 Oct 2021 09:54:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A4DF46B007E; Fri, 8 Oct 2021 09:54:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0178.hostedemail.com [216.40.44.178]) by kanga.kvack.org (Postfix) with ESMTP id 973556B0071 for ; Fri, 8 Oct 2021 09:54:56 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5D01F28DA5 for ; Fri, 8 Oct 2021 13:54:56 +0000 (UTC) X-FDA: 78673416192.22.427B929 Received: from outbound-smtp19.blacknight.com (outbound-smtp19.blacknight.com [46.22.139.246]) by imf15.hostedemail.com (Postfix) with ESMTP id 06F73D0004AD for ; Fri, 8 Oct 2021 13:54:55 +0000 (UTC) Received: from mail.blacknight.com (pemlinmail06.blacknight.ie [81.17.255.152]) by outbound-smtp19.blacknight.com (Postfix) with ESMTPS id B7C091C3E6F for ; Fri, 8 Oct 2021 14:54:54 +0100 (IST) Received: (qmail 7895 invoked from network); 8 Oct 2021 13:54:54 -0000 Received: from unknown (HELO stampy.112glenside.lan) (mgorman@techsingularity.net@[84.203.17.29]) by 81.17.254.9 with ESMTPA; 8 Oct 2021 13:54:54 -0000 From: Mel Gorman To: Linux-MM Cc: NeilBrown , Theodore Ts'o , Andreas Dilger , "Darrick J . Wong" , Matthew Wilcox , Michal Hocko , Dave Chinner , Rik van Riel , Vlastimil Babka , Johannes Weiner , Jonathan Corbet , Linux-fsdevel , LKML , Mel Gorman Subject: [PATCH 7/8] mm/vmscan: Increase the timeout if page reclaim is not making progress Date: Fri, 8 Oct 2021 14:53:31 +0100 Message-Id: <20211008135332.19567-8-mgorman@techsingularity.net> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211008135332.19567-1-mgorman@techsingularity.net> References: <20211008135332.19567-1-mgorman@techsingularity.net> MIME-Version: 1.0 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 06F73D0004AD X-Stat-Signature: nuq65r7zbgfdphfsw8y4jx7sf1mwynws Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf15.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.139.246 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net X-HE-Tag: 1633701295-164567 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Tracing of the stutterp workload showed the following delays 1 usect_delayed=3D124000 reason=3DVMSCAN_THROTTLE_NOPROGRESS 1 usect_delayed=3D128000 reason=3DVMSCAN_THROTTLE_NOPROGRESS 1 usect_delayed=3D176000 reason=3DVMSCAN_THROTTLE_NOPROGRESS 1 usect_delayed=3D536000 reason=3DVMSCAN_THROTTLE_NOPROGRESS 1 usect_delayed=3D544000 reason=3DVMSCAN_THROTTLE_NOPROGRESS 1 usect_delayed=3D556000 reason=3DVMSCAN_THROTTLE_NOPROGRESS 1 usect_delayed=3D624000 reason=3DVMSCAN_THROTTLE_NOPROGRESS 1 usect_delayed=3D716000 reason=3DVMSCAN_THROTTLE_NOPROGRESS 1 usect_delayed=3D772000 reason=3DVMSCAN_THROTTLE_NOPROGRESS 2 usect_delayed=3D512000 reason=3DVMSCAN_THROTTLE_NOPROGRESS 16 usect_delayed=3D120000 reason=3DVMSCAN_THROTTLE_NOPROGRESS 53 usect_delayed=3D116000 reason=3DVMSCAN_THROTTLE_NOPROGRESS 116 usect_delayed=3D112000 reason=3DVMSCAN_THROTTLE_NOPROGRESS 5907 usect_delayed=3D108000 reason=3DVMSCAN_THROTTLE_NOPROGRESS 71741 usect_delayed=3D104000 reason=3DVMSCAN_THROTTLE_NOPROGRESS All the throttling hit the full timeout and then there was wakeup delays meaning that the wakeups are premature as no other reclaimer such as kswapd has made progress. This patch increases the maximum timeout. Signed-off-by: Mel Gorman --- mm/vmscan.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/vmscan.c b/mm/vmscan.c index e096e81dcbd8..7b54fec4072c 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1038,6 +1038,8 @@ void reclaim_throttle(pg_data_t *pgdat, enum vmscan= _throttle_state reason) */ switch(reason) { case VMSCAN_THROTTLE_NOPROGRESS: + timeout =3D HZ/2; + break; case VMSCAN_THROTTLE_WRITEBACK: timeout =3D HZ/10; break; --=20 2.31.1