From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D484C433EF for ; Mon, 11 Oct 2021 10:22:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F20E860E90 for ; Mon, 11 Oct 2021 10:22:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F20E860E90 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 3690D6B006C; Mon, 11 Oct 2021 06:22:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 317F0900002; Mon, 11 Oct 2021 06:22:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 206F56B0072; Mon, 11 Oct 2021 06:22:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0002.hostedemail.com [216.40.44.2]) by kanga.kvack.org (Postfix) with ESMTP id 1090C6B006C for ; Mon, 11 Oct 2021 06:22:15 -0400 (EDT) Received: from smtpin34.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id A2E6B8249980 for ; Mon, 11 Oct 2021 10:22:14 +0000 (UTC) X-FDA: 78683766588.34.04D5D73 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf27.hostedemail.com (Postfix) with ESMTP id 2251F7016DA7 for ; Mon, 11 Oct 2021 10:22:14 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id E7CCF22009; Mon, 11 Oct 2021 10:22:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1633947732; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vyQen1Zq8Tl+eNKk+7X6QbIZKCPE6MO8S+wIugEUo/Y=; b=potp4nGQcaQHBKM7WWeqOodSSb5zdnY6IobzXyt7Q2XK3u4AdvfJuDBKuQB7fo4dpIUqes 0fSdKZTs2FPHT5y6cmXCQktlYXBaH9g2XMdicci2uzDrDZ+hjvMWYIQ/XHJxaJ9KdOrolM WLL4DAyJhvZt9nY7y1i4CZI5TOdoIJ0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1633947732; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vyQen1Zq8Tl+eNKk+7X6QbIZKCPE6MO8S+wIugEUo/Y=; b=BlvExj7R/7/oeQZZ2IwIPtv2w1J982s6E+hU0B6frUfM7S54czD77QRen7Ev4mCO9VXXNF /4MICsoZ1wHC04AA== Received: from suse.de (unknown [10.163.43.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 3418DA3B88; Mon, 11 Oct 2021 10:22:12 +0000 (UTC) Date: Mon, 11 Oct 2021 11:22:10 +0100 From: Mel Gorman To: Eric Dumazet Cc: Andrew Morton , linux-kernel , linux-mm , Eric Dumazet , syzbot , "Huang, Ying" Subject: Re: [PATCH] mm/mempolicy: do not allow illegal MPOL_F_NUMA_BALANCING | MPOL_LOCAL in mbind() Message-ID: <20211011102210.GU3891@suse.de> References: <20211001174947.135123-1-eric.dumazet@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20211001174947.135123-1-eric.dumazet@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=potp4nGQ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=BlvExj7R; spf=pass (imf27.hostedemail.com: domain of mgorman@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=mgorman@suse.de; dmarc=pass (policy=none) header.from=suse.de X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 2251F7016DA7 X-Stat-Signature: itn6xfnynhsddqhqbbwhh83m19whrctx X-HE-Tag: 1633947734-172687 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 01, 2021 at 10:49:47AM -0700, Eric Dumazet wrote: > From: Eric Dumazet > > syzbot reported access to unitialized memory in mbind() [1] > > Issue came with commit bda420b98505 ("numa balancing: migrate on > fault among multiple bound nodes") > > This commit added a new bit in MPOL_MODE_FLAGS, but only checked > valid combination (MPOL_F_NUMA_BALANCING can only be used with MPOL_BIND) > in do_set_mempolicy() > > This patch moves the check in sanitize_mpol_flags() so that it > is also used by mbind() > > [1] > BUG: KMSAN: uninit-value in __mpol_equal+0x567/0x590 mm/mempolicy.c:2260 > __mpol_equal+0x567/0x590 mm/mempolicy.c:2260 > mpol_equal include/linux/mempolicy.h:105 [inline] > vma_merge+0x4a1/0x1e60 mm/mmap.c:1190 > mbind_range+0xcc8/0x1e80 mm/mempolicy.c:811 > do_mbind+0xf42/0x15f0 mm/mempolicy.c:1333 > kernel_mbind mm/mempolicy.c:1483 [inline] > __do_sys_mbind mm/mempolicy.c:1490 [inline] > __se_sys_mbind+0x437/0xb80 mm/mempolicy.c:1486 > __x64_sys_mbind+0x19d/0x200 mm/mempolicy.c:1486 > do_syscall_x64 arch/x86/entry/common.c:51 [inline] > do_syscall_64+0x54/0xd0 arch/x86/entry/common.c:82 > entry_SYSCALL_64_after_hwframe+0x44/0xae > > Uninit was created at: > slab_alloc_node mm/slub.c:3221 [inline] > slab_alloc mm/slub.c:3230 [inline] > kmem_cache_alloc+0x751/0xff0 mm/slub.c:3235 > mpol_new mm/mempolicy.c:293 [inline] > do_mbind+0x912/0x15f0 mm/mempolicy.c:1289 > kernel_mbind mm/mempolicy.c:1483 [inline] > __do_sys_mbind mm/mempolicy.c:1490 [inline] > __se_sys_mbind+0x437/0xb80 mm/mempolicy.c:1486 > __x64_sys_mbind+0x19d/0x200 mm/mempolicy.c:1486 > do_syscall_x64 arch/x86/entry/common.c:51 [inline] > do_syscall_64+0x54/0xd0 arch/x86/entry/common.c:82 > entry_SYSCALL_64_after_hwframe+0x44/0xae > ===================================================== > Kernel panic - not syncing: panic_on_kmsan set ... > CPU: 0 PID: 15049 Comm: syz-executor.0 Tainted: G B 5.15.0-rc2-syzkaller #0 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 > Call Trace: > __dump_stack lib/dump_stack.c:88 [inline] > dump_stack_lvl+0x1ff/0x28e lib/dump_stack.c:106 > dump_stack+0x25/0x28 lib/dump_stack.c:113 > panic+0x44f/0xdeb kernel/panic.c:232 > kmsan_report+0x2ee/0x300 mm/kmsan/report.c:186 > __msan_warning+0xd7/0x150 mm/kmsan/instrumentation.c:208 > __mpol_equal+0x567/0x590 mm/mempolicy.c:2260 > mpol_equal include/linux/mempolicy.h:105 [inline] > vma_merge+0x4a1/0x1e60 mm/mmap.c:1190 > mbind_range+0xcc8/0x1e80 mm/mempolicy.c:811 > do_mbind+0xf42/0x15f0 mm/mempolicy.c:1333 > kernel_mbind mm/mempolicy.c:1483 [inline] > __do_sys_mbind mm/mempolicy.c:1490 [inline] > __se_sys_mbind+0x437/0xb80 mm/mempolicy.c:1486 > __x64_sys_mbind+0x19d/0x200 mm/mempolicy.c:1486 > do_syscall_x64 arch/x86/entry/common.c:51 [inline] > do_syscall_64+0x54/0xd0 arch/x86/entry/common.c:82 > entry_SYSCALL_64_after_hwframe+0x44/0xae > RIP: 0033:0x7f4a41b2c709 > Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48 > RSP: 002b:00007f4a3f0a3188 EFLAGS: 00000246 ORIG_RAX: 00000000000000ed > RAX: ffffffffffffffda RBX: 00007f4a41c30f60 RCX: 00007f4a41b2c709 > RDX: 0000000000002001 RSI: 0000000000c00007 RDI: 0000000020012000 > RBP: 00007f4a41b86cb4 R08: 0000000000000000 R09: 0000010000000002 > R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 > R13: 00007f4a42164b2f R14: 00007f4a3f0a3300 R15: 0000000000022000 > > Fixes: bda420b98505 ("numa balancing: migrate on fault among multiple bound nodes") > Signed-off-by: Eric Dumazet > Reported-by: syzbot > Cc: "Huang, Ying" > Cc: Mel Gorman Acked-by: Mel Gorman -- Mel Gorman SUSE Labs