From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0624DC433EF for ; Tue, 12 Oct 2021 18:33:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A03A160C40 for ; Tue, 12 Oct 2021 18:33:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A03A160C40 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 3980E900004; Tue, 12 Oct 2021 14:33:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 34845900002; Tue, 12 Oct 2021 14:33:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 237B8900004; Tue, 12 Oct 2021 14:33:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0248.hostedemail.com [216.40.44.248]) by kanga.kvack.org (Postfix) with ESMTP id 11AAC900002 for ; Tue, 12 Oct 2021 14:33:58 -0400 (EDT) Received: from smtpin40.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id C391D39492 for ; Tue, 12 Oct 2021 18:33:57 +0000 (UTC) X-FDA: 78688634514.40.779B6EF Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf22.hostedemail.com (Postfix) with ESMTP id 89D781910 for ; Tue, 12 Oct 2021 18:33:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=hxuHUoytUuk4x4tbpoAi8hfD81lXg3HGcPsmGGD2qLs=; b=YySSYhUGcvD+8JyLmi3XreBEyB 2ixrqYgbktMbQ6TJTfGNAJ7vpSq+dvV9axQFW08wF2RrZGUzy08hFz8gLfIJC28a9CFMiigT0l8Li uC6I4AAYCTpkq8BUiypGEQHriP2AQWeBVjlguLRRwomgU0WuRfZyiKZcHEr3fK0S92Fh5KjTHLyyr lJBBw55RNQwFtHogVRyDS7jQQSE+PwkvShMh4DlrPUyrb4XnXQqADdUmnE1SME9VZGdLmrE3elwMs UvrnnHx1gPNdNh5kM/Nc/OWS5wY8gkYp9P83fcc5Df2no9UDkXzWCnOYAxqb52wDR6S12FYgkULy+ GtZjoPNQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1maMZL-006jux-IP; Tue, 12 Oct 2021 18:32:27 +0000 From: "Matthew Wilcox (Oracle)" To: Yafang Shao Cc: "Matthew Wilcox (Oracle)" , Sergey Senozhatsky , Petr Mladek , linux-mm@kvack.org, Vlastimil Babka , Rasmus Villemoes Subject: [PATCH 4/5] test_printf: Append '|' more efficiently Date: Tue, 12 Oct 2021 19:26:46 +0100 Message-Id: <20211012182647.1605095-5-willy@infradead.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20211012182647.1605095-1-willy@infradead.org> References: <20211012182647.1605095-1-willy@infradead.org> MIME-Version: 1.0 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 89D781910 X-Stat-Signature: ph9mt6qygohhhwetkrsj7ai3c1yuiyg4 Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=YySSYhUG; dmarc=none; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org X-HE-Tag: 1634063637-530068 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Instead of calling snprintf(), just append '|' by hand. Signed-off-by: Matthew Wilcox (Oracle) --- lib/test_printf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/test_printf.c b/lib/test_printf.c index 60cdf4ba991e..662c3785aa57 100644 --- a/lib/test_printf.c +++ b/lib/test_printf.c @@ -623,9 +623,9 @@ page_flags_test(int section, int node, int zone, int = last_cpupid, if (!pft[i].width) continue; =20 - if (append) { - snprintf(cmp_buf + size, BUF_SIZE - size, "|"); - size =3D strlen(cmp_buf); + if (append && size < BUF_SIZE) { + cmp_buf[size++] =3D '|'; + cmp_buf[size] =3D '\0'; } =20 page_flags |=3D (values[i] & pft[i].mask) << pft[i].shift; --=20 2.32.0