From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92A0AC433FE for ; Wed, 13 Oct 2021 16:01:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4378C61163 for ; Wed, 13 Oct 2021 16:01:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4378C61163 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id E17F794000A; Wed, 13 Oct 2021 12:01:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DC7EE940007; Wed, 13 Oct 2021 12:01:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8E1494000A; Wed, 13 Oct 2021 12:01:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0215.hostedemail.com [216.40.44.215]) by kanga.kvack.org (Postfix) with ESMTP id B8156940007 for ; Wed, 13 Oct 2021 12:01:01 -0400 (EDT) Received: from smtpin32.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 64DEC8249980 for ; Wed, 13 Oct 2021 16:01:01 +0000 (UTC) X-FDA: 78691877922.32.281F3DD Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) by imf22.hostedemail.com (Postfix) with ESMTP id 8851219BC for ; Wed, 13 Oct 2021 16:00:59 +0000 (UTC) Received: by mail-qt1-f179.google.com with SMTP id v17so3007641qtp.1 for ; Wed, 13 Oct 2021 09:00:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JqXrOW1sz81l7piXeJ6TmVlYLqW03X51G3JR7Qr/jYw=; b=mpN2Ljf6OWSB7Vva54RoUDfZ6Q3KNqIBKGRBHhpr6j0955npGcPr5zboDSUBt8+OMH EbZ15JvJ8T9M34AHEeXip3qHWrrwS+RDrwcbLh6ae9OehrnQuln0mj6XWCG8yRJggHON 0pj2mXcE83TZsXJ+XFyx2B5Ab/O3ZD3l+KemPRGhyWYRAb4xLaMriSsH93pgR9KJuZE9 yMiHo+XQJe1ULyeEfm3PFiC1JJH0+eqWGovjNWEmDK0d4rHzyZsOvvtoPEw+Bl+fEnGj T70aXIcDaPrG2hp+p06tgaDc78NMCEQ4yfI9X+tHBnhAr+cT+KfhdmpwvJXgtLkumthE OU0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JqXrOW1sz81l7piXeJ6TmVlYLqW03X51G3JR7Qr/jYw=; b=orN1oeUgbn/BodKVi22RnrBsmrPJpzf7Hv3tiArU4zd/CHhTFOchwlfO84o4oKyinT TUH45d3hOVK8EynfcUaoVjDVH4wfqXsUmF3KHKmXcODClzLfaACYA/zANME2dWwjNrHa Hs08iloQ2p0cneutAYpz/mEqPGIbZFkjOz1oJcJra5FqFd2ko9MZnv2HIFm6ccVsqiBg AxFMdYDv32XDOXCq3v/mBV/vJQY2lAxvSqA9jBbnwPijYzY1wGgng98PV9FQKTi4XlFy IseK45TUYS1gsTB3YLUXHedrlETXehfI7gXndRanYgCfgzY3RXsxl2FjrnbA/Y0iwKwP +OmA== X-Gm-Message-State: AOAM533bJ+cajX9CaHAyyVckeA1pltiK5KVCPZ2iThTeQwX/BKVxQ+Xa SYr/kTkFLMuGf+2Lxg4mbpMBtC18vLpe X-Google-Smtp-Source: ABdhPJx1ckUYAdslQAAfyG6CdVNk5O/7d27iKRx/bXp+Qol0mRi3VXuk+NUm3TZhT+H2RMTyLjJvOw== X-Received: by 2002:a05:622a:186:: with SMTP id s6mr58015qtw.323.1634140855563; Wed, 13 Oct 2021 09:00:55 -0700 (PDT) Received: from moria.home.lan (c-73-219-103-14.hsd1.vt.comcast.net. [73.219.103.14]) by smtp.gmail.com with ESMTPSA id w17sm20161qts.53.2021.10.13.09.00.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Oct 2021 09:00:54 -0700 (PDT) From: Kent Overstreet To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, linux-raid@vger.kernel.org, linux-block@vger.kernel.org, axboe@kernel.dk Cc: Kent Overstreet , alexander.h.duyck@linux.intel.com Subject: [PATCH 5/5] brd: Kill usage of page->index Date: Wed, 13 Oct 2021 12:00:34 -0400 Message-Id: <20211013160034.3472923-6-kent.overstreet@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211013160034.3472923-1-kent.overstreet@gmail.com> References: <20211013160034.3472923-1-kent.overstreet@gmail.com> MIME-Version: 1.0 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 8851219BC X-Stat-Signature: cpyy4c3a8qxycijkyzdsdapgpi81w87t Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=mpN2Ljf6; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of kent.overstreet@gmail.com designates 209.85.160.179 as permitted sender) smtp.mailfrom=kent.overstreet@gmail.com X-HE-Tag: 1634140859-698467 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: As part of the struct page cleanups underway, we want to remove as much usage of page->mapping and page->index as possible, as frequently they are known from context. In the brd code, we're never actually reading from page->index except in assertions, so references to it can be safely deleted. Signed-off-by: Kent Overstreet --- drivers/block/brd.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/block/brd.c b/drivers/block/brd.c index 58ec167aa0..0a55aed832 100644 --- a/drivers/block/brd.c +++ b/drivers/block/brd.c @@ -72,8 +72,6 @@ static struct page *brd_lookup_page(struct brd_device *= brd, sector_t sector) page =3D radix_tree_lookup(&brd->brd_pages, idx); rcu_read_unlock(); =20 - BUG_ON(page && page->index !=3D idx); - return page; } =20 @@ -108,12 +106,10 @@ static struct page *brd_insert_page(struct brd_devi= ce *brd, sector_t sector) =20 spin_lock(&brd->brd_lock); idx =3D sector >> PAGE_SECTORS_SHIFT; - page->index =3D idx; if (radix_tree_insert(&brd->brd_pages, idx, page)) { __free_page(page); page =3D radix_tree_lookup(&brd->brd_pages, idx); BUG_ON(!page); - BUG_ON(page->index !=3D idx); } else { brd->brd_nr_pages++; } --=20 2.33.0