From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D608DC433F5 for ; Thu, 14 Oct 2021 07:22:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9ABCC60E53 for ; Thu, 14 Oct 2021 07:22:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9ABCC60E53 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 35D15940020; Thu, 14 Oct 2021 03:22:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 30C5094001C; Thu, 14 Oct 2021 03:22:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 223DD940020; Thu, 14 Oct 2021 03:22:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0019.hostedemail.com [216.40.44.19]) by kanga.kvack.org (Postfix) with ESMTP id 1019894001C for ; Thu, 14 Oct 2021 03:22:07 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C3C4931E7C for ; Thu, 14 Oct 2021 07:22:06 +0000 (UTC) X-FDA: 78694199052.28.0B49EFB Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf28.hostedemail.com (Postfix) with ESMTP id 4ED0690000A4 for ; Thu, 14 Oct 2021 07:22:06 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id B048360E53; Thu, 14 Oct 2021 07:22:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1634196125; bh=vJAcCpXTn71678QsoXxMqqwnh49Gpqggsk823DPziYg=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=Z83luPCKh139KzgzE/6nz8jT79ovw/pI+OXKPM0jKsw21lsJbJv6Eiq/8TvhtoaeT LBQWd/56b1Gs7uIjywSBPzfLuNO4yRTrrRdnh4+7Bt2BDoMwjNDC8kk+WtTI/Y2/Io LvGqaLQM+SxKEdxJ69ue4o5vMjrDQcL6fY/AME+yPChsLQod/JEFMYi/ETaaQhDseB HbKeCYveItaZJTe64cjloeQiLdDQA0SOm0FjnuZiZ0ToURKU1y2pLIPKJHhakpKy1+ O+sM9SDWGTpYvcDplfE09Z9b3lqN3mVb2OuRMCTBh2Ofe/WNNeb1b+xP+eywW1sZp7 DLoiozZYKr7sg== From: SeongJae Park To: Rongwei Wang Cc: sj@kernel.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2] mm/damon/dbgfs: remove unnecessary variables Date: Thu, 14 Oct 2021 07:21:58 +0000 Message-Id: <20211014072158.35478-1-sj@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211014020333.10330-1-rongwei.wang@linux.alibaba.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 4ED0690000A4 X-Stat-Signature: 7r58jwbeid68dyhn6uiur6ipawyd4p1s Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Z83luPCK; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf28.hostedemail.com: domain of sj@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=sj@kernel.org X-HE-Tag: 1634196126-116002 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 14 Oct 2021 10:03:33 +0800 Rongwei Wang wrote: > In some functions, it's unnecessary to declare 'err' > and 'ret' variables at the same time. This patch mainly > to simplify the issue of such declarations by reusing > one variable. > > Signed-off-by: Rongwei Wang Looks good to me. However, this doesn't cleanly applicable on latest -mm tree. I will post a rebased version as a reply to this. Thanks, SJ [...]