From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC902C433EF for ; Wed, 27 Oct 2021 01:18:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 69892610EA for ; Wed, 27 Oct 2021 01:18:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 69892610EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.dev Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id EB32280007; Tue, 26 Oct 2021 21:18:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E62D5940007; Tue, 26 Oct 2021 21:18:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D510B80007; Tue, 26 Oct 2021 21:18:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0071.hostedemail.com [216.40.44.71]) by kanga.kvack.org (Postfix) with ESMTP id C2C55940007 for ; Tue, 26 Oct 2021 21:18:23 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 816B48249980 for ; Wed, 27 Oct 2021 01:18:23 +0000 (UTC) X-FDA: 78740456886.25.2D1F7CD Received: from out1.migadu.com (out1.migadu.com [91.121.223.63]) by imf22.hostedemail.com (Postfix) with ESMTP id B4F571904 for ; Wed, 27 Oct 2021 01:18:22 +0000 (UTC) Date: Wed, 27 Oct 2021 10:18:07 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1635297500; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eC+dtU9OfBZl1jqB8KdIpIwy9ri5TDG2MDVAjdUs+Ys=; b=cAYCzMBwv9VqDWnvD0vLA5VHCYkdjNeAT6fHU9ROOFTg4Ky6SNXhCIJ+Toyesv10mFB91/ 0FF2SdgO6HTYhiRFMdbS7VvQGr5vRpjqlM/Jecz+BOUfJx7b7Pc0bQco5DbBNkS0vyh8zE NRlMDqc88MFndSXeHzmcZrTMmigv+vA= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Naoya Horiguchi To: Yang Shi Cc: Linux MM , Andrew Morton , David Hildenbrand , Oscar Salvador , Michal Hocko , Ding Hui , Tony Luck , "Aneesh Kumar K.V" , Miaohe Lin , Peter Xu , Naoya Horiguchi , Linux Kernel Mailing List Subject: Re: [PATCH v2 2/4] mm/hwpoison: remove race consideration Message-ID: <20211027011807.GA2707645@u2004> References: <20211025230503.2650970-1-naoya.horiguchi@linux.dev> <20211025230503.2650970-3-naoya.horiguchi@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: naoya.horiguchi@linux.dev X-Stat-Signature: qc91mmedwpxgnqtyzzz1h86kzabqihgz X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: B4F571904 Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=cAYCzMBw; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf22.hostedemail.com: domain of naoya.horiguchi@linux.dev designates 91.121.223.63 as permitted sender) smtp.mailfrom=naoya.horiguchi@linux.dev X-HE-Tag: 1635297502-753800 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 26, 2021 at 06:04:13PM -0700, Yang Shi wrote: > On Mon, Oct 25, 2021 at 4:06 PM Naoya Horiguchi > wrote: > > > > From: Naoya Horiguchi > > > > Now memory_failure() and unpoison_memory() are protected by mf_mutex, > > so no need to explicitly check races between them. So remove them. > > It seems this patch could be folded into patch #1. Some "unlock_mutex" > were added by patch #1 then they were removed by this patch > immediately, it seems a bit of a waste and this patch is actually the > by-product of patch #1. OK, I'll do this in the next post. Thanks, Naoya Horiguchi