From: kernel test robot <lkp@intel.com>
To: Tong Zhang <ztong0001@gmail.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Eric Biederman <ebiederm@xmission.com>,
Kees Cook <keescook@chromium.org>,
Luis Chamberlain <mcgrof@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org,
Linux Memory Management List <linux-mm@kvack.org>,
Tong Zhang <ztong0001@gmail.com>
Subject: Re: [PATCH v1] binfmt_misc: fix crash when load/unload module
Date: Mon, 24 Jan 2022 20:14:26 +0800 [thread overview]
Message-ID: <202201242006.cqM8NznF-lkp@intel.com> (raw)
In-Reply-To: <20220124003342.1457437-1-ztong0001@gmail.com>
Hi Tong,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.17-rc1 next-20220124]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Tong-Zhang/binfmt_misc-fix-crash-when-load-unload-module/20220124-083500
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git dd81e1c7d5fb126e5fbc5c9e334d7b3ec29a16a0
config: arm-randconfig-c002-20220124 (https://download.01.org/0day-ci/archive/20220124/202201242006.cqM8NznF-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/d649008f3214eb4d94760873831ef5e53c292976
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Tong-Zhang/binfmt_misc-fix-crash-when-load-unload-module/20220124-083500
git checkout d649008f3214eb4d94760873831ef5e53c292976
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
fs/binfmt_misc.c: In function 'init_misc_binfmt':
>> fs/binfmt_misc.c:828:28: error: assignment to 'struct ctl_table_header *' from incompatible pointer type 'struct sysctl_header *' [-Werror=incompatible-pointer-types]
828 | binfmt_misc_header = register_sysctl_mount_point("fs/binfmt_misc");
| ^
cc1: some warnings being treated as errors
vim +828 fs/binfmt_misc.c
821
822 static int __init init_misc_binfmt(void)
823 {
824 int err = register_filesystem(&bm_fs_type);
825 if (!err)
826 insert_binfmt(&misc_format);
827
> 828 binfmt_misc_header = register_sysctl_mount_point("fs/binfmt_misc");
829 if (!binfmt_misc_header) {
830 pr_warn("Failed to create fs/binfmt_misc sysctl mount point");
831 return -ENOMEM;
832 }
833 return 0;
834 }
835
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
prev parent reply other threads:[~2022-01-24 12:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220124003342.1457437-1-ztong0001@gmail.com>
2022-01-24 11:40 ` [PATCH v1] binfmt_misc: fix crash when load/unload module kernel test robot
2022-01-24 23:16 ` Andrew Morton
2022-01-25 18:14 ` Luis Chamberlain
2022-01-26 5:04 ` Murphy Zhou
2022-01-26 5:23 ` Tong Zhang
2022-01-26 6:33 ` Tong Zhang
2022-01-29 0:25 ` Murphy Zhou
2022-01-24 12:14 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202201242006.cqM8NznF-lkp@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=kbuild-all@lists.01.org \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=ztong0001@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).