From: Naoya Horiguchi <naoya.horiguchi@linux.dev>
To: linux-mm@kvack.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mike Kravetz <mike.kravetz@oracle.com>,
Tony Luck <tony.luck@intel.com>,
Naoya Horiguchi <naoya.horiguchi@nec.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH v1] mm, hwpoison: remove obsolete comment
Date: Tue, 25 Jan 2022 11:56:01 +0900 [thread overview]
Message-ID: <20220125025601.3054511-1-naoya.horiguchi@linux.dev> (raw)
From: Naoya Horiguchi <naoya.horiguchi@nec.com>
With the introduction of mf_mutex, most of memory error handling
process is mutually exclusive, so the in-line comment about
subtlety about double-checking PageHWPoison is no more correct.
So remove it.
Suggested-by: Mike Kravetz <mike.kravetz@oracle.com>
Signed-off-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
---
mm/memory-failure.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/mm/memory-failure.c b/mm/memory-failure.c
index 4c9bd1d37301..a6a1e02759e7 100644
--- a/mm/memory-failure.c
+++ b/mm/memory-failure.c
@@ -2146,12 +2146,6 @@ static int __soft_offline_page(struct page *page)
.gfp_mask = GFP_USER | __GFP_MOVABLE | __GFP_RETRY_MAYFAIL,
};
- /*
- * Check PageHWPoison again inside page lock because PageHWPoison
- * is set by memory_failure() outside page lock. Note that
- * memory_failure() also double-checks PageHWPoison inside page lock,
- * so there's no race between soft_offline_page() and memory_failure().
- */
lock_page(page);
if (!PageHuge(page))
wait_on_page_writeback(page);
--
2.25.1
next reply other threads:[~2022-01-25 2:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 2:56 Naoya Horiguchi [this message]
2022-01-25 3:08 ` [PATCH v1] mm, hwpoison: remove obsolete comment Miaohe Lin
2022-01-25 5:44 ` Anshuman Khandual
2022-01-25 6:18 ` Oscar Salvador
2022-01-25 17:45 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220125025601.3054511-1-naoya.horiguchi@linux.dev \
--to=naoya.horiguchi@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=naoya.horiguchi@nec.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).