From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 244F8C433EF for ; Fri, 4 Feb 2022 19:59:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F18D66B007B; Fri, 4 Feb 2022 14:59:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 387C28D0015; Fri, 4 Feb 2022 14:59:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6410C6B0095; Fri, 4 Feb 2022 14:59:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0197.hostedemail.com [216.40.44.197]) by kanga.kvack.org (Postfix) with ESMTP id 9326A6B009A for ; Fri, 4 Feb 2022 14:59:08 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 57EBC824C424 for ; Fri, 4 Feb 2022 19:59:08 +0000 (UTC) X-FDA: 79106161176.13.FC305A2 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf22.hostedemail.com (Postfix) with ESMTP id 0E4CDC0005 for ; Fri, 4 Feb 2022 19:59:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=gH/HpEmYfLdrfRbpayNzunExyTfpHfZmR6mgqsHCuL8=; b=lGH9rzl2ESM3Q3dNOnt6VwuOVC 8AFCtiMUSFMDfuQWY84H7BB7UOgb+JtUvdVi7WWBzUay2+A2kp9xPrdVQgq2OMnou7ypFRQDtMitt lpOdYkgp8kYu4Tjal1LhNsif2pV9dWqqA4s1J2AvtiQive9tm6I0j0Vee7oQY5cIX3lhXr8K/npNF KFQ0k1msEU26yNkTxA6tZGxywWdHnIm2t2fKPctqhjoAEjS6iC+PYFvpJ9SwmQAQh+ITVX2GU48Dk BrxTfAgDOa/yDygKNWXKuUJUFGmfAUkXQDIUfkiyJ8r+rzhfhcRGuk5zFUR3FfSEW/tmvGrqei9on 2h1QlSDQ==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nG4ja-007Lps-Fu; Fri, 04 Feb 2022 19:59:06 +0000 From: "Matthew Wilcox (Oracle)" To: linux-mm@kvack.org Cc: "Matthew Wilcox (Oracle)" , linux-kernel@vger.kernel.org Subject: [PATCH 61/75] mm/vmscan: Free non-shmem folios without splitting them Date: Fri, 4 Feb 2022 19:58:38 +0000 Message-Id: <20220204195852.1751729-62-willy@infradead.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220204195852.1751729-1-willy@infradead.org> References: <20220204195852.1751729-1-willy@infradead.org> MIME-Version: 1.0 Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=lGH9rzl2; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Rspam-User: nil X-Rspamd-Queue-Id: 0E4CDC0005 X-Stat-Signature: hco6ssdufor14erdz87tkjza9453mtu4 X-Rspamd-Server: rspam12 X-HE-Tag: 1644004747-462893 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: We have to allocate memory in order to split a file-backed folio, so it's not a good idea to split them in the memory freeing path. It also doesn't work for XFS because pages have an extra reference count from page_has_private() and split_huge_page() expects that reference to have already been removed. Unfortunately, we still have to split shmem THPs because we can't handle swapping out an entire THP yet. Signed-off-by: Matthew Wilcox (Oracle) --- mm/vmscan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 2e94e0b15a76..794cba8511f1 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1732,8 +1732,8 @@ static unsigned int shrink_page_list(struct list_he= ad *page_list, /* Adding to swap updated mapping */ mapping =3D page_mapping(page); } - } else if (unlikely(PageTransHuge(page))) { - /* Split file THP */ + } else if (PageSwapBacked(page) && PageTransHuge(page)) { + /* Split shmem THP */ if (split_folio_to_list(folio, page_list)) goto keep_locked; } --=20 2.34.1