From: John Hubbard <jhubbard@nvidia.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Peter Xu <peterx@redhat.com>, Jason Gunthorpe <jgg@ziepe.ca>
Cc: David Hildenbrand <david@redhat.com>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
Christoph Hellwig <hch@infradead.org>,
Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.cz>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Alex Williamson <alex.williamson@redhat.com>,
Andrea Arcangeli <aarcange@redhat.com>,
LKML <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
John Hubbard <jhubbard@nvidia.com>
Subject: [PATCH v5 0/5] mm/gup: some cleanups
Date: Sun, 6 Feb 2022 22:22:08 -0800 [thread overview]
Message-ID: <20220207062213.235127-1-jhubbard@nvidia.com> (raw)
Hi,
Here's an update, mainly just collecting reviewed-by tags:
Changes since v4:
* Patch 1: reflowed the commit description to 72 columns.
* Added reviewed-by's from Christoph and Jan for remaining patches.
* Rebased onto 5.17-rc3.
Changes since v3:
* Patch 1: Commit log: removed a reference to an out of tree module,
and updated tags and added a short note to that effect.
* Patch 2: Fixed up do_move_pages(), to squash -EEXIST returns from
follow_page() into something that move_pages() allows: -EFAULT.
This is from reviews by Jan Kara, Matthew Wilcox, Jason Gunthorpe.
Removed all Reviewed-by tags for this patch, due to that update.
* Patch 4: Split into two patches, as recommended by Christoph
Hellwig. Left the Reviewed-by tags intact because no code changes
were required.
* Added Reviewed-by tags from Claudio Imbrenda.
Changes since v2:
* Patch 2: Removed an unnecessary line that was causing a
clang-analyzer complaint, as reported by Lukas Bulwahn
[1] (thanks!), and retested locally.
Jason: I've boldly left your Reviewed-by tag on this patch,
because I am predicting you'll agree with it...
* Added Reviewed-by tags from Jan Kara, Christoph Hellwig, and
Jason Gunthorpe that have collected since v2.
Changes since v1:
* Patch 4: changed from get_user_pages(), to get_user_pages_fast().
* Patch 4: Rewrote the commit description--thanks to Jan Kara for
that feedback.
* Patch 1: Removed Jerome's Cc from patch 1, due to a stale email
address.
* Added Reviewed-by's from David Hildenbrand and Jason Gunthorpe.
Original cover letter, updated as necessary:
I'm including Peter's patch as the first one in this tiny series. (The
commit description has my r-b tag in place of my Cc, and removes
Jerome's Cc because he is no longer at redhat.com) The second patch is
what I had in mind for a follow-up to that, when we were discussing that
fix [2].
Plus, a couple more small removals that I had queued up:
The third patch removes a completely unused routine:
pin_user_pages_locked().
The forth patch removes a similar routine, get_user_pages_locked(), that
only has one caller. It now calls get_user_pages_fast(), instead.
v1 of this patchset is here:
https://lore.kernel.org/all/20220131051752.447699-1-jhubbard@nvidia.com/
v2:
https://lore.kernel.org/r/20220201101108.306062-1-jhubbard@nvidia.com
v3:
https://lore.kernel.org/r/20220203093232.572380-1-jhubbard@nvidia.com
v4:
https://lore.kernel.org/r/20220204020010.68930-1-jhubbard@nvidia.com
[1] https://lore.kernel.org/r/CAKXUXMxFK9bo8jDoRZbQ0r2j-JwAGg3Xc5cpAcLaHfwHddJ7ew@mail.gmail.com
[2] https://lore.kernel.org/all/20220125033700.69705-1-peterx@redhat.com/
John Hubbard (4):
mm/gup: follow_pfn_pte(): -EEXIST cleanup
mm/gup: remove unused pin_user_pages_locked()
mm: change lookup_node() to use get_user_pages_fast()
mm/gup: remove unused get_user_pages_locked()
Peter Xu (1):
mm: Fix invalid page pointer returned with FOLL_PIN gups
include/linux/mm.h | 4 --
mm/gup.c | 101 ++++-----------------------------------------
mm/mempolicy.c | 21 ++++------
mm/migrate.c | 7 ++++
4 files changed, 24 insertions(+), 109 deletions(-)
base-commit: dfd42facf1e4ada021b939b4e19c935dcdd55566
--
2.35.1
next reply other threads:[~2022-02-07 6:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 6:22 John Hubbard [this message]
2022-02-07 6:22 ` [PATCH v5 1/5] mm: Fix invalid page pointer returned with FOLL_PIN gups John Hubbard
2022-02-07 6:22 ` [PATCH v5 2/5] mm/gup: follow_pfn_pte(): -EEXIST cleanup John Hubbard
2022-02-07 6:22 ` [PATCH v5 3/5] mm/gup: remove unused pin_user_pages_locked() John Hubbard
2022-02-07 6:22 ` [PATCH v5 4/5] mm: change lookup_node() to use get_user_pages_fast() John Hubbard
2022-02-07 6:22 ` [PATCH v5 5/5] mm/gup: remove unused get_user_pages_locked() John Hubbard
2022-02-12 0:24 ` [PATCH v5 0/5] mm/gup: some cleanups John Hubbard
2022-02-12 0:27 ` Andrew Morton
2022-02-12 0:30 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220207062213.235127-1-jhubbard@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alex.williamson@redhat.com \
--cc=david@redhat.com \
--cc=hch@infradead.org \
--cc=imbrenda@linux.ibm.com \
--cc=jack@suse.cz \
--cc=jgg@ziepe.ca \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lukas.bulwahn@gmail.com \
--cc=peterx@redhat.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).