From: Muchun Song <songmuchun@bytedance.com>
To: akpm@linux-foundation.org, zi.yan@cs.rutgers.edu,
kirill.shutemov@linux.intel.com, rientjes@google.com,
lars.persson@axis.com, mike.kravetz@oracle.com, ziy@nvidia.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
duanxiongchun@bytedance.com, fam.zheng@bytedance.com,
Muchun Song <songmuchun@bytedance.com>
Subject: [PATCH v5 7/7] mm: replace multiple dcache flush with flush_dcache_folio()
Date: Thu, 10 Feb 2022 20:30:58 +0800 [thread overview]
Message-ID: <20220210123058.79206-8-songmuchun@bytedance.com> (raw)
In-Reply-To: <20220210123058.79206-1-songmuchun@bytedance.com>
Simplify the code by using flush_dcache_folio().
Signed-off-by: Muchun Song <songmuchun@bytedance.com>
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
---
mm/migrate.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/mm/migrate.c b/mm/migrate.c
index c418e8d92b9c..daf2b3508670 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -933,12 +933,8 @@ static int move_to_new_page(struct page *newpage, struct page *page,
if (!PageMappingFlags(page))
page->mapping = NULL;
- if (likely(!is_zone_device_page(newpage))) {
- int i, nr = compound_nr(newpage);
-
- for (i = 0; i < nr; i++)
- flush_dcache_page(newpage + i);
- }
+ if (likely(!is_zone_device_page(newpage)))
+ flush_dcache_folio(page_folio(newpage));
}
out:
return rc;
--
2.11.0
prev parent reply other threads:[~2022-02-10 12:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 12:30 [PATCH v5 0/7] Fix some cache flush bugs Muchun Song
2022-02-10 12:30 ` [PATCH v5 1/7] mm: thp: fix wrong cache flush in remove_migration_pmd() Muchun Song
2022-02-10 12:30 ` [PATCH v5 2/7] mm: fix missing cache flush for all tail pages of compound page Muchun Song
2022-02-10 12:30 ` [PATCH v5 3/7] mm: hugetlb: fix missing cache flush in copy_huge_page_from_user() Muchun Song
2022-02-10 12:30 ` [PATCH v5 4/7] mm: hugetlb: fix missing cache flush in hugetlb_mcopy_atomic_pte() Muchun Song
2022-02-10 12:30 ` [PATCH v5 5/7] mm: shmem: fix missing cache flush in shmem_mfill_atomic_pte() Muchun Song
2022-02-15 19:11 ` Mike Kravetz
2022-02-16 6:16 ` Muchun Song
2022-02-10 12:30 ` [PATCH v5 6/7] mm: userfaultfd: fix missing cache flush in mcopy_atomic_pte() and __mcopy_atomic() Muchun Song
2022-02-15 19:13 ` Mike Kravetz
2022-02-10 12:30 ` Muchun Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220210123058.79206-8-songmuchun@bytedance.com \
--to=songmuchun@bytedance.com \
--cc=akpm@linux-foundation.org \
--cc=duanxiongchun@bytedance.com \
--cc=fam.zheng@bytedance.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=lars.persson@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=rientjes@google.com \
--cc=zi.yan@cs.rutgers.edu \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).