From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28719C433F5 for ; Fri, 11 Feb 2022 06:49:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 99F426B0075; Fri, 11 Feb 2022 01:49:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 94DA66B0078; Fri, 11 Feb 2022 01:49:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7EEF16B007B; Fri, 11 Feb 2022 01:49:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0242.hostedemail.com [216.40.44.242]) by kanga.kvack.org (Postfix) with ESMTP id 56F3E6B0075 for ; Fri, 11 Feb 2022 01:49:38 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id EC9AD181AC9C6 for ; Fri, 11 Feb 2022 06:49:37 +0000 (UTC) X-FDA: 79129573194.18.B0C4E4F Received: from mail-ot1-f73.google.com (mail-ot1-f73.google.com [209.85.210.73]) by imf28.hostedemail.com (Postfix) with ESMTP id 7BC5DC0002 for ; Fri, 11 Feb 2022 06:49:37 +0000 (UTC) Received: by mail-ot1-f73.google.com with SMTP id j2-20020a9d7d82000000b005a12a0fb4b0so4843344otn.5 for ; Thu, 10 Feb 2022 22:49:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=nDUa4nh0VfMB33PiEe/+b8nW+DWgiuCX8+o5RVf1oHI=; b=ThzYMOIDPOykUabiB3RlRAijrJSIHNXOSUgcmlKL4c2HDkyKp7qaJwrCrOB5Cj7/Sn b+6g0BlcsH3JRNO1HyBb0LIliKk840gqIqgFjHZyfba+0Rzygu2PqymxQgM8gR9yQfI2 UsYHiVjl75cre377AqUX4YDmZQbFTuUf3922omgktt3jvQUKmwr3eB7X7/Z19Ju1H4ex PjrES1T9lJwMXV5jyWjXRhmiR+2EhxtUnHDoQdtmgniawP0Vl+SgjVunv4BNLBp8DepV bZ7c1Ro3WZr7RdhwOGLkLCIGOQPDT8YXV3AJpris0GtceJxuIoOltOYgpfluZ3rotD5S G5vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=nDUa4nh0VfMB33PiEe/+b8nW+DWgiuCX8+o5RVf1oHI=; b=CWwXSfoqc+YU1EOn5wePtpTYt+bScOubweRWtEYwlSJtACuiYZQtVbxmPfLMoHZpNm WOVh5tb5d3y06Y1FRRTKzWTIGyCiMe7Q42bgo0ILtuhM4A222aiBifR30OUcDBW9fWbf 69Gd3/NX8Dg+fIcnwLsb1qhMis4wqdx1+lnatWCLdQ9eXVA09qca33RNEZ0fCUQTR1tM wMUj0HFuX99XC1U/xEAkYRrdVOQx6fg5koV8eT4XgyXVIG6WfpzceY66bAkCFfhR7oD9 HjT/KfI5dkF6lTcBUC1ax12iuTSADY2aKSl1puYwqqTDlqCe2FXE+OE+hCLfnUwA+eD3 z4dw== X-Gm-Message-State: AOAM531CFIRyigGvTh0j2xgKoM7IuPY2URW8k/SXr3lCIf3ewTq2coYV 6hcV54o+g3mH+UdhIG5JM38ru+BrXqkgVA== X-Google-Smtp-Source: ABdhPJx5gc39Is8agdmSFvKE0SI6NhFXD2uOpMQyKeFvk0V2rSxi71LnZdIohEe32baoaxn1gC4VmeeF0Z5JzQ== X-Received: from shakeelb.svl.corp.google.com ([2620:15c:2cd:202:9a07:ef1a:2fee:57f1]) (user=shakeelb job=sendgmr) by 2002:a05:6870:6288:: with SMTP id s8mr53946oan.269.1644562176594; Thu, 10 Feb 2022 22:49:36 -0800 (PST) Date: Thu, 10 Feb 2022 22:49:14 -0800 In-Reply-To: <20220211064917.2028469-1-shakeelb@google.com> Message-Id: <20220211064917.2028469-2-shakeelb@google.com> Mime-Version: 1.0 References: <20220211064917.2028469-1-shakeelb@google.com> X-Mailer: git-send-email 2.35.1.265.g69c8d7142f-goog Subject: [PATCH v2 1/4] memcg: refactor mem_cgroup_oom From: Shakeel Butt To: Johannes Weiner , Michal Hocko , Roman Gushchin Cc: Chris Down , Andrew Morton , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Shakeel Butt Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 7BC5DC0002 X-Rspam-User: Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=ThzYMOID; spf=pass (imf28.hostedemail.com: domain of 3AAcGYggKCD0rgZjddkafnnfkd.bnlkhmtw-lljuZbj.nqf@flex--shakeelb.bounces.google.com designates 209.85.210.73 as permitted sender) smtp.mailfrom=3AAcGYggKCD0rgZjddkafnnfkd.bnlkhmtw-lljuZbj.nqf@flex--shakeelb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: xm5zh5tyicaihsj87jopjrog918rne16 X-Rspamd-Server: rspam03 X-HE-Tag: 1644562177-513710 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The function mem_cgroup_oom returns enum which has four possible values but the caller does not care about such values and only cares if the return value is OOM_SUCCESS or not. So, remove the enum altogether and make mem_cgroup_oom returns a simple bool. Signed-off-by: Shakeel Butt Reviewed-by: Roman Gushchin --- Changes since v1: - Added comment for mem_cgroup_oom as suggested by Roman mm/memcontrol.c | 44 +++++++++++++++++--------------------------- 1 file changed, 17 insertions(+), 27 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index a0e9d9f12cf5..f12e489ba9b8 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -1795,20 +1795,16 @@ static void memcg_oom_recover(struct mem_cgroup *memcg) __wake_up(&memcg_oom_waitq, TASK_NORMAL, 0, memcg); } -enum oom_status { - OOM_SUCCESS, - OOM_FAILED, - OOM_ASYNC, - OOM_SKIPPED -}; - -static enum oom_status mem_cgroup_oom(struct mem_cgroup *memcg, gfp_t mask, int order) +/* + * Returns true if successfully killed one or more processes. Though in some + * corner cases it can return true even without killing any process. + */ +static bool mem_cgroup_oom(struct mem_cgroup *memcg, gfp_t mask, int order) { - enum oom_status ret; - bool locked; + bool locked, ret; if (order > PAGE_ALLOC_COSTLY_ORDER) - return OOM_SKIPPED; + return false; memcg_memory_event(memcg, MEMCG_OOM); @@ -1831,14 +1827,13 @@ static enum oom_status mem_cgroup_oom(struct mem_cgroup *memcg, gfp_t mask, int * victim and then we have to bail out from the charge path. */ if (memcg->oom_kill_disable) { - if (!current->in_user_fault) - return OOM_SKIPPED; - css_get(&memcg->css); - current->memcg_in_oom = memcg; - current->memcg_oom_gfp_mask = mask; - current->memcg_oom_order = order; - - return OOM_ASYNC; + if (current->in_user_fault) { + css_get(&memcg->css); + current->memcg_in_oom = memcg; + current->memcg_oom_gfp_mask = mask; + current->memcg_oom_order = order; + } + return false; } mem_cgroup_mark_under_oom(memcg); @@ -1849,10 +1844,7 @@ static enum oom_status mem_cgroup_oom(struct mem_cgroup *memcg, gfp_t mask, int mem_cgroup_oom_notify(memcg); mem_cgroup_unmark_under_oom(memcg); - if (mem_cgroup_out_of_memory(memcg, mask, order)) - ret = OOM_SUCCESS; - else - ret = OOM_FAILED; + ret = mem_cgroup_out_of_memory(memcg, mask, order); if (locked) mem_cgroup_oom_unlock(memcg); @@ -2545,7 +2537,6 @@ static int try_charge_memcg(struct mem_cgroup *memcg, gfp_t gfp_mask, int nr_retries = MAX_RECLAIM_RETRIES; struct mem_cgroup *mem_over_limit; struct page_counter *counter; - enum oom_status oom_status; unsigned long nr_reclaimed; bool passed_oom = false; bool may_swap = true; @@ -2648,9 +2639,8 @@ static int try_charge_memcg(struct mem_cgroup *memcg, gfp_t gfp_mask, * a forward progress or bypass the charge if the oom killer * couldn't make any progress. */ - oom_status = mem_cgroup_oom(mem_over_limit, gfp_mask, - get_order(nr_pages * PAGE_SIZE)); - if (oom_status == OOM_SUCCESS) { + if (mem_cgroup_oom(mem_over_limit, gfp_mask, + get_order(nr_pages * PAGE_SIZE))) { passed_oom = true; nr_retries = MAX_RECLAIM_RETRIES; goto retry; -- 2.35.1.265.g69c8d7142f-goog