From: Andrew Morton <akpm@linux-foundation.org>
To: Rik van Riel <riel@surriel.com>
Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com,
linux-mm@kvack.org, Miaohe Lin <linmiaohe@huawei.com>,
Mel Gorman <mgorman@suse.de>,
Johannes Weiner <hannes@cmpxchg.org>,
Matthew Wilcox <willy@infradead.org>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Naoya Horiguchi <naoya.horiguchi@nec.com>
Subject: Re: [PATCH v2] mm: clean up hwpoison page cache page in fault path
Date: Mon, 14 Feb 2022 15:24:07 -0800 [thread overview]
Message-ID: <20220214152407.67e0d7dd1a532252c9dd203e@linux-foundation.org> (raw)
In-Reply-To: <20220212213740.423efcea@imladris.surriel.com>
> Subject: [PATCH v2] mm: clean up hwpoison page cache page in fault path
At first scan I thought this was a code cleanup.
I think I'll do s/clean up/invalidate/.
On Sat, 12 Feb 2022 21:37:40 -0500 Rik van Riel <riel@surriel.com> wrote:
> Sometimes the page offlining code can leave behind a hwpoisoned clean
> page cache page.
Is this correct behaviour?
> This can lead to programs being killed over and over
> and over again as they fault in the hwpoisoned page, get killed, and
> then get re-spawned by whatever wanted to run them.
>
> This is particularly embarrassing when the page was offlined due to
> having too many corrected memory errors. Now we are killing tasks
> due to them trying to access memory that probably isn't even corrupted.
>
> This problem can be avoided by invalidating the page from the page
> fault handler, which already has a branch for dealing with these
> kinds of pages. With this patch we simply pretend the page fault
> was successful if the page was invalidated, return to userspace,
> incur another page fault, read in the file from disk (to a new
> memory page), and then everything works again.
Is this worth a cc:stable?
next prev parent reply other threads:[~2022-02-14 23:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-13 2:37 [PATCH v2] mm: clean up hwpoison page cache page in fault path Rik van Riel
2022-02-14 23:24 ` Andrew Morton [this message]
2022-02-15 1:37 ` Rik van Riel
2022-02-15 5:15 ` HORIGUCHI NAOYA(堀口 直也)
2022-02-15 11:22 ` David Hildenbrand
2022-02-15 15:01 ` Rik van Riel
2022-02-15 15:06 ` David Hildenbrand
2022-02-15 12:51 ` Oscar Salvador
2022-02-15 15:04 ` Rik van Riel
2022-02-16 2:13 ` Miaohe Lin
2022-02-21 12:54 ` Oscar Salvador
2022-02-21 13:19 ` Miaohe Lin
2022-02-21 12:55 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220214152407.67e0d7dd1a532252c9dd203e@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=naoya.horiguchi@nec.com \
--cc=riel@surriel.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).