From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2268C433EF for ; Mon, 14 Feb 2022 20:00:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 77CA76B007D; Mon, 14 Feb 2022 15:00:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 72A7F6B007E; Mon, 14 Feb 2022 15:00:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5CE9E6B0082; Mon, 14 Feb 2022 15:00:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0139.hostedemail.com [216.40.44.139]) by kanga.kvack.org (Postfix) with ESMTP id 31BF46B007E for ; Mon, 14 Feb 2022 15:00:23 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id DB5D6A3096 for ; Mon, 14 Feb 2022 20:00:22 +0000 (UTC) X-FDA: 79142452284.24.CD7F136 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id E8EDC1A0006 for ; Mon, 14 Feb 2022 20:00:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=pMmUPjORgDlTWoCIHyx1XACEheIw3KyZ8x3eCP/DL/c=; b=CZST60YHjYmI78xvxO0cAcvnMi e/s10L759y9ZqvQdld9dccxUESCCpqsiddGHWTBqdGL8YSlJGAzOPlz4k4h2I2FTwmBBH5i4wIFvG JbH2oUFEWpoi/HlwOhZR+GhQFpJC7rAuDaF19baH/305JWtw35Oe9ZR6wyYeoXkYx/bbGtzUsAWS6 pm5zNQu5YyvxbqlEM+gXCpG4QjPAaJWu+5oH/Lsfza0DBWEahfxLDlWSEh3uUNSYik/dEhdEpVlAe ESxlZk1Pa+lvA46eCAC+6lPZlrSy4tEOSc14i8XQ7Qlv4TaqusZsRMwjBZI2kLO0vNNYRRMyLIIYI zwIptykg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJhWF-00DDdg-Ud; Mon, 14 Feb 2022 20:00:19 +0000 From: "Matthew Wilcox (Oracle)" To: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Cc: "Matthew Wilcox (Oracle)" Subject: [PATCH 04/10] mm/truncate: Replace page_mapped() call in invalidate_inode_page() Date: Mon, 14 Feb 2022 20:00:11 +0000 Message-Id: <20220214200017.3150590-5-willy@infradead.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220214200017.3150590-1-willy@infradead.org> References: <20220214200017.3150590-1-willy@infradead.org> MIME-Version: 1.0 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: E8EDC1A0006 X-Stat-Signature: ebhhk6nw3ooa1aepobengr6gkijo1zpd X-Rspam-User: Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=CZST60YH; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-HE-Tag: 1644868821-280395 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: folio_mapped() is expensive because it has to check each page's mapcount field. A cheaper check is whether there are any extra references to the page, other than the one we own and the ones held by the page cache. The call to remove_mapping() will fail in any case if it cannot freeze the refcount, but failing here avoids cycling the i_pages spinlock. Signed-off-by: Matthew Wilcox (Oracle) --- mm/truncate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/truncate.c b/mm/truncate.c index b73c30c95cd0..d67fa8871b75 100644 --- a/mm/truncate.c +++ b/mm/truncate.c @@ -287,7 +287,7 @@ int invalidate_inode_page(struct page *page) return 0; if (folio_test_dirty(folio) || folio_test_writeback(folio)) return 0; - if (page_mapped(page)) + if (folio_ref_count(folio) > folio_nr_pages(folio) + 1) return 0; if (folio_has_private(folio) && !filemap_release_folio(folio, 0)) return 0; --=20 2.34.1