From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46D2BC433F5 for ; Tue, 15 Feb 2022 19:13:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B989D6B007B; Tue, 15 Feb 2022 14:13:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B1F5F6B007D; Tue, 15 Feb 2022 14:13:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 972F56B007E; Tue, 15 Feb 2022 14:13:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0046.hostedemail.com [216.40.44.46]) by kanga.kvack.org (Postfix) with ESMTP id 8582A6B007B for ; Tue, 15 Feb 2022 14:13:39 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 4E7C4181AC9C6 for ; Tue, 15 Feb 2022 19:13:39 +0000 (UTC) X-FDA: 79145963358.12.D47881C Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf19.hostedemail.com (Postfix) with ESMTP id C5C831A000D for ; Tue, 15 Feb 2022 19:13:38 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2784BB81C66; Tue, 15 Feb 2022 19:13:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA149C340EB; Tue, 15 Feb 2022 19:13:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644952415; bh=aWKfLj+OcuQ7ORm2NzKcSLdWPXwTMvCyCCSlhItZJdc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Pb9b+lIl3czsbILZx4JGaHKfxai5nhmkbafSdXIePkm1+42+PtZWRvtnxsIxieHjT 9ekyHuwvisvcr9fVX07+lClUNa2p0vhktIvKZSAjwuXs2gg0KwuzJxVI1eJwsCEsx9 QAqj6xuEKLMkpaRxHB9Jbh5UZNn3lhP/U/32rVpI9FJi1e5LJ0Z2HLVW0p7KctTIZB uH0ohVDX/Qm561zC5FzYDM+alYJWObfXnSGwWXg348TFcT9AqtFzE3U54RAksJmBj5 t03G17WjapCI9e95mge26r6O7cubp0cNepLCQdTnroGWEV76h8vqtZwzBmUYMX3S66 UcWCeciahTo0A== Date: Tue, 15 Feb 2022 13:21:10 -0600 From: "Gustavo A. R. Silva" To: Kees Cook Cc: GR-QLogic-Storage-Upstream@marvell.com, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, linux-crypto@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-omap@vger.kernel.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, mpi3mr-linuxdrv.pdl@broadcom.com, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, sparmaintainer@unisys.com, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-ext4@vger.kernel.org, linux-acpi@vger.kernel.org, devel@acpica.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, greybus-dev@lists.linaro.org, linux-i3c@lists.infradead.org, linux-rdma@vger.kernel.org, linux-bluetooth@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH][next] treewide: Replace zero-length arrays with flexible-array members Message-ID: <20220215192110.GA883653@embeddedor> References: <20220215174743.GA878920@embeddedor> <202202151016.C0471D6E@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <202202151016.C0471D6E@keescook> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: C5C831A000D X-Rspam-User: Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Pb9b+lIl; spf=pass (imf19.hostedemail.com: domain of gustavoars@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=gustavoars@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Stat-Signature: hbgapnuutuapb4s1147joekitdeybqax X-HE-Tag: 1644952418-124388 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 15, 2022 at 10:17:40AM -0800, Kees Cook wrote: > On Tue, Feb 15, 2022 at 11:47:43AM -0600, Gustavo A. R. Silva wrote: > > There is a regular need in the kernel to provide a way to declare > > having a dynamically sized set of trailing elements in a structure. > > Kernel code should always use =E2=80=9Cflexible array members=E2=80=9D= [1] for these > > cases. The older style of one-element or zero-length arrays should > > no longer be used[2]. > >=20 > > This code was transformed with the help of Coccinelle: > > (next-20220214$ spatch --jobs $(getconf _NPROCESSORS_ONLN) --sp-file = script.cocci --include-headers --dir . > output.patch) > >=20 > > @@ > > identifier S, member, array; > > type T1, T2; > > @@ > >=20 > > struct S { > > ... > > T1 member; > > T2 array[ > > - 0 > > ]; > > }; >=20 > These all look trivially correct to me. Only two didn't have the end of > the struct visible in the patch, and checking those showed them to be > trailing members as well, so: >=20 > Reviewed-by: Kees Cook I'll add this to my -next tree. Thanks! -- Gustavo