From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3289C433EF for ; Fri, 8 Apr 2022 23:07:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12D176B0071; Fri, 8 Apr 2022 19:07:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B5E26B0072; Fri, 8 Apr 2022 19:07:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E72096B0073; Fri, 8 Apr 2022 19:07:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id D28586B0071 for ; Fri, 8 Apr 2022 19:07:29 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id A75DD8052E for ; Fri, 8 Apr 2022 23:07:29 +0000 (UTC) X-FDA: 79335250218.02.6D1B2D7 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by imf05.hostedemail.com (Postfix) with ESMTP id 34F33100002 for ; Fri, 8 Apr 2022 23:07:29 +0000 (UTC) Received: by mail-ej1-f43.google.com with SMTP id bh17so20023942ejb.8 for ; Fri, 08 Apr 2022 16:07:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=hi0prdDkJImvmtLVbm8IK6k0nJ66jx1U/slepVZ3rHU=; b=G683hzUdY6do+0lKv+bxUx5UEEq19nh+dz3OkndRK2tmj+XvcVYVKoIlR/4cbXS1lt XphAjB3aBY+AxrRZPo94fPKLnxlNnMrzcbTrTVp0LFtUXH4/Oa1cX6z31dP8dNyvQomu I9EsBIpgiqi6GdLF0bljzVYpiRvOAlCh94L1QCBfJAJHgPqG4p4yUw+UQTp6H8JFGN9W ErevlIBghvIOUPibXDHwUtq9uzavElG+ydnd3G7GRr2vAXpRm8wfvunRdOUIH0Mbd9ub 5QtCEmgbmcop1aDYuRrdarasiiP1bk5wj3XRSh9TpblRtI7YPQsK5KwVCcmPYU/h8icC ZeQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=hi0prdDkJImvmtLVbm8IK6k0nJ66jx1U/slepVZ3rHU=; b=yHpqnVJTQjHEgsdI6WCd/Mt9xL5wXnKMO/hbMx7jzrEIA3X/e5Y+2NIIKZZqZcGE9l EPjwD5nJkSIXmd6ay6G9BR/hz82/IeWR16B/5wcbNo6+LQaxodNTE1eAVPKk0ywMuZ04 +BLNfrXItGFY0ivYLt+lC8LtiYT5OaTgs24zDA6LVc5qw2sWROxd/PybzfaMgEYpxhkG efR6BHYBW9puTomgKai/0uiasCdpYbu2QpBgR1S2cGubeWOUtpajnFiDFl1ewjkhpF54 BhJfvmzFhgGY797pcYn56IOp4btCvJCvrVujEaHsKlQZut2+FRehq/0HTOrzRGsbSd6h 9ykw== X-Gm-Message-State: AOAM533OGV+IjoSRaSm4fSOe1R3xWmzinBsv/e5j8/SHrA5Xoct6dXDt iaQ9sWIIZjBTXuDcLbQDUZ0= X-Google-Smtp-Source: ABdhPJxYVaasDuk2KFE27rk9Fl5mlSMtjvuv4M6bOtxYaCe4u6PYKveYz9Tt+YS60lBzHpfwupU6IA== X-Received: by 2002:a17:906:e4b:b0:6e4:8d29:6793 with SMTP id q11-20020a1709060e4b00b006e48d296793mr21715084eji.655.1649459247732; Fri, 08 Apr 2022 16:07:27 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id k19-20020a1709062a5300b006c75a94c587sm9125566eje.65.2022.04.08.16.07.27 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 08 Apr 2022 16:07:27 -0700 (PDT) Date: Fri, 8 Apr 2022 23:07:26 +0000 From: Wei Yang To: David Hildenbrand Cc: Wei Yang , akpm@linux-foundation.org, linux-mm@kvack.org, Vlastimil Babka , Oscar Salvador Subject: Re: [Patch v2 2/2] mm/page_alloc: not necessary to multiply MAX_NODE_LOAD Message-ID: <20220408230726.qjz7x5wvkxsurvgq@master> Reply-To: Wei Yang References: <20220408025947.1619-1-richard.weiyang@gmail.com> <20220408025947.1619-2-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 34F33100002 X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=G683hzUd; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com X-Stat-Signature: tthuepx1nmghc341rag1s8q7nwpwm8gy X-HE-Tag: 1649459249-248300 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000940, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 08, 2022 at 10:09:48AM +0200, David Hildenbrand wrote: >On 08.04.22 04:59, Wei Yang wrote: >> Since we just increase a constance of 1 to node penalty, it is not >> necessary to multiply MAX_NODE_LOAD for preference. >> >> This patch also remove the definition. >> >> [vbabka@suse.cz: suggests] >> >> Signed-off-by: Wei Yang >> CC: Vlastimil Babka >> CC: David Hildenbrand >> CC: Oscar Salvador >> --- >> mm/page_alloc.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/mm/page_alloc.c b/mm/page_alloc.c >> index 86b6573fbeb5..ca6a127bbc26 100644 >> --- a/mm/page_alloc.c >> +++ b/mm/page_alloc.c >> @@ -6170,7 +6170,6 @@ int numa_zonelist_order_handler(struct ctl_table *table, int write, >> } >> >> >> -#define MAX_NODE_LOAD (nr_online_nodes) >> static int node_load[MAX_NUMNODES]; >> >> /** >> @@ -6217,7 +6216,7 @@ int find_next_best_node(int node, nodemask_t *used_node_mask) >> val += PENALTY_FOR_NODE_WITH_CPUS; >> >> /* Slight preference for less loaded node */ >> - val *= (MAX_NODE_LOAD*MAX_NUMNODES); >> + val *= MAX_NUMNODES; >> val += node_load[n]; >> >> if (val < min_val) { > >I feel like this should be squashed into the previous patch. It has the >same effect of making this code independent of nr_online_nodes. And I >had to scratch my head a couple of times in patch #1 why the change in >patch #1 is fine with thus remaining in place. > > >Having that said, I consider this code highly unnecessary >over-complicated at first sight. Removing some of the magic most >certainly is very welcome. > >This semantics of the global variable node_load[] remains mostly >mysterious for me. > So the suggestion is a v3 with #1 and #2 squashed? >-- >Thanks, > >David / dhildenb -- Wei Yang Help you, Help me