From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55567C433F5 for ; Sun, 10 Apr 2022 17:48:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B95856B0071; Sun, 10 Apr 2022 13:48:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B46956B0073; Sun, 10 Apr 2022 13:48:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E7176B0074; Sun, 10 Apr 2022 13:48:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 8952F6B0071 for ; Sun, 10 Apr 2022 13:48:22 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4FBCA22B8D for ; Sun, 10 Apr 2022 17:48:22 +0000 (UTC) X-FDA: 79341703644.04.9DD8424 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by imf28.hostedemail.com (Postfix) with ESMTP id 697A8C0005 for ; Sun, 10 Apr 2022 17:48:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649612901; x=1681148901; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=YQpWhr3iY9RYZ/QQ7KsrLWIRBpUuvi7f5jvFQqObdc8=; b=O3OxjJwxXpMk/X7ZVxfpBsSPPzYkhQJQXGX4tARtjwjwAQbDatX+GHBI gNTX0VBmeQPlwsi6yvoCHgUP9amQ3HCAAwaczrVmV1KaSLruxsA88sjoc qvJtXPTEAVhxYAReRvhBbtuTNq9WNQfYEkfRFVFvavcf9IKLzHKTr7TM5 P/s89MDQQrrnWJDg43FpnC0JE66osiOqVBbtikaFLsRVvbQWljalwMTru Z9NoTM5ROXfDNDAxdT08kngLWCMiEgjOvruL8xq/HGmINhK+MRu/H5+/z MRprb5taj3kfYaxgtkeJjJEOckHmPiDDOo3EvwMsz5MyUePgMN/zRBn47 w==; X-IronPort-AV: E=McAfee;i="6400,9594,10313"; a="249265239" X-IronPort-AV: E=Sophos;i="5.90,250,1643702400"; d="scan'208";a="249265239" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2022 10:48:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,250,1643702400"; d="scan'208";a="589506145" Received: from lkp-server02.sh.intel.com (HELO d3fc50ef50de) ([10.239.97.151]) by orsmga001.jf.intel.com with ESMTP; 10 Apr 2022 10:48:13 -0700 Received: from kbuild by d3fc50ef50de with local (Exim 4.95) (envelope-from ) id 1ndbfY-0000zz-Co; Sun, 10 Apr 2022 17:48:12 +0000 Date: Mon, 11 Apr 2022 01:47:10 +0800 From: kernel test robot To: Zach O'Keefe , Alex Shi , David Hildenbrand , David Rientjes , Matthew Wilcox , Michal Hocko , Pasha Tatashin , SeongJae Park , Song Liu , Vlastimil Babka , Yang Shi , Zi Yan , linux-mm@kvack.org Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, Andrea Arcangeli , Andrew Morton , Linux Memory Management List , Arnd Bergmann , Axel Rasmussen , Chris Kennelly , Chris Zankel , Helge Deller , Hugh Dickins , Ivan Kokshaysky , "James E.J. Bottomley" , Jens Axboe , "Kirill A. Shutemov" , Matt Turner , Max Filippov , Miaohe Lin , Minchan Kim , Patrick Xia Subject: Re: [PATCH 03/12] mm/khugepaged: make hugepage allocation context-specific Message-ID: <202204110122.yKx76cVq-lkp@intel.com> References: <20220410135445.3897054-4-zokeefe@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220410135445.3897054-4-zokeefe@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Stat-Signature: zgcw81eqcq5uwtwbxysjtr7ska5s83ys Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=O3OxjJwx; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf28.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 134.134.136.20) smtp.mailfrom=lkp@intel.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 697A8C0005 X-HE-Tag: 1649612901-800065 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Zach, Thank you for the patch! Yet something to improve: [auto build test ERROR on hnaz-mm/master] url: https://github.com/intel-lab-lkp/linux/commits/Zach-O-Keefe/mm-userspace-hugepage-collapse/20220410-215722 base: https://github.com/hnaz/linux-mm master config: i386-randconfig-a002 (https://download.01.org/0day-ci/archive/20220411/202204110122.yKx76cVq-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 256c6b0ba14e8a7ab6373b61b7193ea8c0a3651c) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/93731be575c612b28ee4c7711ebab9e81960f213 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Zach-O-Keefe/mm-userspace-hugepage-collapse/20220410-215722 git checkout 93731be575c612b28ee4c7711ebab9e81960f213 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): mm/khugepaged.c:1006:8: warning: mixing declarations and code is incompatible with standards before C99 [-Wdeclaration-after-statement] pmd_t pmde; ^ >> mm/khugepaged.c:2339:18: error: incompatible function pointer types initializing 'struct page *(*)(struct collapse_control *, gfp_t, int)' (aka 'struct page *(*)(struct collapse_control *, unsigned int, int)') with an expression of type 'struct page *(*)(struct collapse_control *, gfp_t)' (aka 'struct page *(*)(struct collapse_control *, unsigned int)') [-Werror,-Wincompatible-function-pointer-types] .alloc_hpage = &khugepaged_alloc_page, ^~~~~~~~~~~~~~~~~~~~~~ 1 warning and 1 error generated. vim +2339 mm/khugepaged.c 2333 2334 static int khugepaged(void *none) 2335 { 2336 struct mm_slot *mm_slot; 2337 struct collapse_control cc = { 2338 .last_target_node = NUMA_NO_NODE, > 2339 .alloc_hpage = &khugepaged_alloc_page, 2340 }; 2341 2342 set_freezable(); 2343 set_user_nice(current, MAX_NICE); 2344 2345 while (!kthread_should_stop()) { 2346 khugepaged_do_scan(&cc); 2347 khugepaged_wait_work(); 2348 } 2349 2350 spin_lock(&khugepaged_mm_lock); 2351 mm_slot = khugepaged_scan.mm_slot; 2352 khugepaged_scan.mm_slot = NULL; 2353 if (mm_slot) 2354 collect_mm_slot(mm_slot); 2355 spin_unlock(&khugepaged_mm_lock); 2356 return 0; 2357 } 2358 -- 0-DAY CI Kernel Test Service https://01.org/lkp