From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39CCAC433EF for ; Sun, 10 Apr 2022 17:48:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A5E186B0073; Sun, 10 Apr 2022 13:48:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A0DFC6B0074; Sun, 10 Apr 2022 13:48:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C48B6B0075; Sun, 10 Apr 2022 13:48:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0129.hostedemail.com [216.40.44.129]) by kanga.kvack.org (Postfix) with ESMTP id 69A176B0073 for ; Sun, 10 Apr 2022 13:48:23 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 423E5A7C2C for ; Sun, 10 Apr 2022 17:48:21 +0000 (UTC) X-FDA: 79341703602.22.A0A431E Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by imf13.hostedemail.com (Postfix) with ESMTP id 073B720003 for ; Sun, 10 Apr 2022 17:48:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649612900; x=1681148900; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=NqkMIxqozkZQwo6dU7Cw/AumHH9kt1fNAIi/2JGLA5I=; b=ABIO0DBWUenJdUuadCWD00gcffBr6us+tqUa5hsaL+mSUelEipvii21i CdaD9aNjOQKtcY+CDPqnAMkWTgq9wdY/JC9a2GICXpQUKICLQyHmhlFjg zkm7E1uBEw0Cs5ulWi9dDM742joRtmI37uastyaQVqLsEValqU+f7kr/s dFn/cwtd9SkGbt9oqPj8jEuufNX3T7cPWsUvdRuf37ZuLnc5ZgDSi+w+s aVmoO3UgjWw8f+NjEgWe8ti8xnUdCP5SRU/VgprZuOj8UZfMoJ9wTOmUi fAUiwlJEPrx7VeGGcCSmFopuCn46AdujQ79avoK2EP5DDgLzq9uwVUUbl Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10313"; a="348421174" X-IronPort-AV: E=Sophos;i="5.90,250,1643702400"; d="scan'208";a="348421174" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2022 10:48:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,250,1643702400"; d="scan'208";a="558630760" Received: from lkp-server02.sh.intel.com (HELO d3fc50ef50de) ([10.239.97.151]) by fmsmga007.fm.intel.com with ESMTP; 10 Apr 2022 10:48:13 -0700 Received: from kbuild by d3fc50ef50de with local (Exim 4.95) (envelope-from ) id 1ndbfY-000103-Di; Sun, 10 Apr 2022 17:48:12 +0000 Date: Mon, 11 Apr 2022 01:47:14 +0800 From: kernel test robot To: Zach O'Keefe , Alex Shi , David Hildenbrand , David Rientjes , Matthew Wilcox , Michal Hocko , Pasha Tatashin , SeongJae Park , Song Liu , Vlastimil Babka , Yang Shi , Zi Yan , linux-mm@kvack.org Cc: kbuild-all@lists.01.org, Andrea Arcangeli , Andrew Morton , Linux Memory Management List , Arnd Bergmann , Axel Rasmussen , Chris Kennelly , Chris Zankel , Helge Deller , Hugh Dickins , Ivan Kokshaysky , "James E.J. Bottomley" , Jens Axboe , "Kirill A. Shutemov" , Matt Turner , Max Filippov , Miaohe Lin , Minchan Kim , Patrick Xia Subject: Re: [PATCH 03/12] mm/khugepaged: make hugepage allocation context-specific Message-ID: <202204110146.7vOFQ9VD-lkp@intel.com> References: <20220410135445.3897054-4-zokeefe@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220410135445.3897054-4-zokeefe@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Stat-Signature: exmxpood5woqfukc83ymkom9kbj68xp8 Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ABIO0DBW; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf13.hostedemail.com: domain of lkp@intel.com has no SPF policy when checking 192.55.52.43) smtp.mailfrom=lkp@intel.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 073B720003 X-HE-Tag: 1649612899-997978 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Zach, Thank you for the patch! Yet something to improve: [auto build test ERROR on hnaz-mm/master] url: https://github.com/intel-lab-lkp/linux/commits/Zach-O-Keefe/mm-userspace-hugepage-collapse/20220410-215722 base: https://github.com/hnaz/linux-mm master config: i386-randconfig-a001 (https://download.01.org/0day-ci/archive/20220411/202204110146.7vOFQ9VD-lkp@intel.com/config) compiler: gcc-11 (Debian 11.2.0-19) 11.2.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/93731be575c612b28ee4c7711ebab9e81960f213 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Zach-O-Keefe/mm-userspace-hugepage-collapse/20220410-215722 git checkout 93731be575c612b28ee4c7711ebab9e81960f213 # save the config file to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): mm/khugepaged.c: In function 'find_pmd_or_thp_or_none': mm/khugepaged.c:1006:9: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] 1006 | pmd_t pmde; | ^~~~~ mm/khugepaged.c: In function 'khugepaged': >> mm/khugepaged.c:2339:32: error: initialization of 'struct page * (*)(struct collapse_control *, gfp_t, int)' {aka 'struct page * (*)(struct collapse_control *, unsigned int, int)'} from incompatible pointer type 'struct page * (*)(struct collapse_control *, gfp_t)' {aka 'struct page * (*)(struct collapse_control *, unsigned int)'} [-Werror=incompatible-pointer-types] 2339 | .alloc_hpage = &khugepaged_alloc_page, | ^ mm/khugepaged.c:2339:32: note: (near initialization for 'cc.alloc_hpage') cc1: some warnings being treated as errors vim +2339 mm/khugepaged.c 2333 2334 static int khugepaged(void *none) 2335 { 2336 struct mm_slot *mm_slot; 2337 struct collapse_control cc = { 2338 .last_target_node = NUMA_NO_NODE, > 2339 .alloc_hpage = &khugepaged_alloc_page, 2340 }; 2341 2342 set_freezable(); 2343 set_user_nice(current, MAX_NICE); 2344 2345 while (!kthread_should_stop()) { 2346 khugepaged_do_scan(&cc); 2347 khugepaged_wait_work(); 2348 } 2349 2350 spin_lock(&khugepaged_mm_lock); 2351 mm_slot = khugepaged_scan.mm_slot; 2352 khugepaged_scan.mm_slot = NULL; 2353 if (mm_slot) 2354 collect_mm_slot(mm_slot); 2355 spin_unlock(&khugepaged_mm_lock); 2356 return 0; 2357 } 2358 -- 0-DAY CI Kernel Test Service https://01.org/lkp