From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18E82C433EF for ; Mon, 11 Apr 2022 15:33:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 939826B0073; Mon, 11 Apr 2022 11:33:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C1416B0074; Mon, 11 Apr 2022 11:33:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73BB16B0075; Mon, 11 Apr 2022 11:33:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0054.hostedemail.com [216.40.44.54]) by kanga.kvack.org (Postfix) with ESMTP id 6333E6B0073 for ; Mon, 11 Apr 2022 11:33:04 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 2BAE8A78F3 for ; Mon, 11 Apr 2022 15:33:04 +0000 (UTC) X-FDA: 79344991488.27.9D90F93 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by imf09.hostedemail.com (Postfix) with ESMTP id A67F3140006 for ; Mon, 11 Apr 2022 15:33:03 +0000 (UTC) Received: by mail-lj1-f171.google.com with SMTP id r2so5268013ljd.10 for ; Mon, 11 Apr 2022 08:33:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xnPakWPy2yT3pIDHfh65ar6g/dls1kfh8Fm485ETQ5M=; b=dQKM0d07whgvlC9oDhJtSUhDkTW4MoFSVg0vfgfBTGbnyj/vLpwIRlpTJbwhAy5wXy t4NvGLtrVnALpqzfCg7AJJXugL5G+gxtpmDu4P3kfUwP/PxlbMFsvAkSX6LdhPrmqMXT qiLuU+fH5rX1P4bRYOwwYVvuKX3ABpSSlgtg6Az3/bkGGCuw7OQsN/ELNNrrh8dksm+L jdUaWuAeAK2VUjv+c+38AFbQNMQ+BBRMEFHjUicyzn/UUqkyKZ+8hd7a357wBJLh/+Ai HUBjhhdQSdLifDKyLGXJgEw/B/MdcmTILkWCG50hI08mI+XNVGIswEXj19aZoHfNzVBJ crnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xnPakWPy2yT3pIDHfh65ar6g/dls1kfh8Fm485ETQ5M=; b=eiGvNTu+C32bieoegrdkN3yyjWjfp8EXluSpPFm8u+k2z5NeO/mUZ7rA+p/Vq+BMFw P8WU79NN/gDIyOT7+SEweDwzGGGoa1hVCHQoIpS2wpYxd5ycA0vqED+yhYggVsvp6BJS 9dvyp/BWKOse6oSfC1+iI6DghM3AOAlcziR/SwpCvywtD2aIPf5bAchqW/1vMFX4W6Xj fXxPoBrb8beWlrmfDNO2MT98wwaNrhlZ0VCt77v6WZoUi5JKJSKLnUxsLeiDgBKYuS0Y AYa+YUrknffIE/mAOMykysxb9pLgnttmvpCJoTCPUKRwovqpI08tLZKWfmnZ7tO8+oop K5SA== X-Gm-Message-State: AOAM532712dOV72es5UEvVKHHqcubaeA07AwyIoa6ACo9HAzi6a/0+HS NGwAAyDR3ZhcA4/jWbtWtjTawA== X-Google-Smtp-Source: ABdhPJznGRs4U58z6UmE7zKZGIORoorFbfftosrGPlCNHfF3AfxicsXpipbZkrEfC0QnRLsaSTmPLw== X-Received: by 2002:a2e:3a02:0:b0:24b:6120:1be4 with SMTP id h2-20020a2e3a02000000b0024b61201be4mr4554362lja.451.1649691181857; Mon, 11 Apr 2022 08:33:01 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id c25-20020a2e6819000000b00247de61d3fdsm3162062lja.113.2022.04.11.08.33.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Apr 2022 08:33:01 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id E5DD4103CE0; Mon, 11 Apr 2022 18:34:33 +0300 (+03) Date: Mon, 11 Apr 2022 18:34:33 +0300 From: "Kirill A. Shutemov" To: Chao Peng Cc: Sean Christopherson , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, qemu-devel@nongnu.org, Paolo Bonzini , Jonathan Corbet , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H . Peter Anvin" , Hugh Dickins , Jeff Layton , "J . Bruce Fields" , Andrew Morton , Mike Rapoport , Steven Price , "Maciej S . Szmigiero" , Vlastimil Babka , Vishal Annapurve , Yu Zhang , "Kirill A . Shutemov" , luto@kernel.org, jun.nakajima@intel.com, dave.hansen@intel.com, ak@linux.intel.com, david@redhat.com Subject: Re: [PATCH v5 04/13] mm/shmem: Restrict MFD_INACCESSIBLE memory against RLIMIT_MEMLOCK Message-ID: <20220411153433.6sqqqd6vzhyfjee6@box.shutemov.name> References: <20220310140911.50924-1-chao.p.peng@linux.intel.com> <20220310140911.50924-5-chao.p.peng@linux.intel.com> <20220408130254.GB57095@chaop.bj.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220408130254.GB57095@chaop.bj.intel.com> X-Stat-Signature: uydx7oy5ndo34hpf6gfw6tkbdph67t36 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A67F3140006 Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=shutemov-name.20210112.gappssmtp.com header.s=20210112 header.b=dQKM0d07; dmarc=none; spf=none (imf09.hostedemail.com: domain of kirill@shutemov.name has no SPF policy when checking 209.85.208.171) smtp.mailfrom=kirill@shutemov.name X-Rspam-User: X-HE-Tag: 1649691183-36077 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 08, 2022 at 09:02:54PM +0800, Chao Peng wrote: > > I think the correct approach is to not do the locking automatically for SHM_F_INACCESSIBLE, > > and instead require userspace to do shmctl(.., SHM_LOCK, ...) if userspace knows the > > consumers don't support migrate/swap. That'd require wrapping migrate_page() and then > > wiring up notifier hooks for migrate/swap, but IMO that's a good thing to get sorted > > out sooner than later. KVM isn't planning on support migrate/swap for TDX or SNP, > > but supporting at least migrate for a software-only implementation a la pKVM should > > be relatively straightforward. On the notifiee side, KVM can terminate the VM if it > > gets an unexpected migrate/swap, e.g. so that TDX/SEV VMs don't die later with > > exceptions and/or data corruption (pre-SNP SEV guests) in the guest. > > SHM_LOCK sounds like a good match. Emm, no. shmctl(2) and SHM_LOCK are SysV IPC thing. I don't see how they fit here. -- Kirill A. Shutemov