From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3587DC433F5 for ; Tue, 12 Apr 2022 00:02:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C006F6B0073; Mon, 11 Apr 2022 20:02:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BB0CE6B0074; Mon, 11 Apr 2022 20:02:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A51E16B0075; Mon, 11 Apr 2022 20:02:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0105.hostedemail.com [216.40.44.105]) by kanga.kvack.org (Postfix) with ESMTP id 95EF46B0073 for ; Mon, 11 Apr 2022 20:02:40 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4CA71A869E for ; Tue, 12 Apr 2022 00:02:40 +0000 (UTC) X-FDA: 79346275680.22.8F8B5F0 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by imf21.hostedemail.com (Postfix) with ESMTP id D5AE61C0005 for ; Tue, 12 Apr 2022 00:02:39 +0000 (UTC) Received: by mail-ed1-f46.google.com with SMTP id c64so8262159edf.11 for ; Mon, 11 Apr 2022 17:02:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jZOmNG9DTpBlSzEJHgyjnPhtjvqI7jsF/7DSvWZGWeU=; b=L7UsvpLqzTsCG/NvWXZH00B5eT9FyjS0ywQGxconEFsA4ILCeqydhR3j4m9lrbckEK uSpIEsJjt5NdGl1qaxI09JYk78US3ItYKNhgia3M1gjIzhKJN1C3x7zP1bf8JRHnfJZh orDGNzJOb3kv+u83HCLwjlNnFCG/haGPkq7/ItONCQfFAxqejQfhWoU3Ikt23lwHMGzO sWwK0kCfIU3SwaH+TbJiPGgoY8MLWI2Q/mn9ZEwp+0yT/MVSlYj0Ezb2PKAN89dP7OoM YjWk81d3CELy9AznvOsEeVg8QM/giS23BAtiGw9f2CkVE9HXkmyAjTL9JoDvBOg1g/QB k+Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=jZOmNG9DTpBlSzEJHgyjnPhtjvqI7jsF/7DSvWZGWeU=; b=rFXaLcrRQjCEWNgXIsr/46UwfEtqQHTbTW1h0qHohMve0vr06DzfTMM+sBZmde7PFH qbAK49ByLtyRqzfotOLZQa8enP5YN1FUDk0C3ZM+EHjWAO47MhBpQuen8GawYKzugXpZ sEUsOomxItDkwo5qkCNOr2z8yL0w9Dq/X53ulaH+JR52O/m7SxkyIaac0rAXkVdMAnBE cXgY5eGW4Wbw5uKuRtOItaPOGyLxDmRO0WNrpArHIeMPdND6JbjOrsTG/r70gGFJzw4B t0Sqf+JV5I7JPqUkHwmcG3MX+IA8JJML6m4EmRmdiP82YXYis/8wWAxdX8t5AlFkpaGf vFMA== X-Gm-Message-State: AOAM533zMAHoukfZu34kpYsrfd8VT7mtdQXKx0fly1EIv8MAI4N026c9 bN8zdPDXUb2bj8relOE55iY= X-Google-Smtp-Source: ABdhPJzANm2rofn40FL5+20TrC5ahYatPPFSqKtRYXBfR3mST6AuW0lyHMKOHaHvE7n9m1y1MPCpHQ== X-Received: by 2002:a05:6402:486:b0:413:bd00:4f3f with SMTP id k6-20020a056402048600b00413bd004f3fmr36269813edv.103.1649721758390; Mon, 11 Apr 2022 17:02:38 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id jw12-20020a17090776ac00b006e87137194esm3395719ejc.150.2022.04.11.17.02.37 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Apr 2022 17:02:37 -0700 (PDT) Date: Tue, 12 Apr 2022 00:02:37 +0000 From: Wei Yang To: Vlastimil Babka Cc: Wei Yang , David Hildenbrand , akpm@linux-foundation.org, linux-mm@kvack.org, Oscar Salvador Subject: Re: [Patch v2 2/2] mm/page_alloc: not necessary to multiply MAX_NODE_LOAD Message-ID: <20220412000237.wcs56fawkdro3jjg@master> Reply-To: Wei Yang References: <20220408025947.1619-1-richard.weiyang@gmail.com> <20220408025947.1619-2-richard.weiyang@gmail.com> <20220408230726.qjz7x5wvkxsurvgq@master> <39bd76b2-5e84-3b7e-c3d6-e8e834d96035@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <39bd76b2-5e84-3b7e-c3d6-e8e834d96035@suse.cz> User-Agent: NeoMutt/20170113 (1.7.2) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=L7UsvpLq; spf=pass (imf21.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: D5AE61C0005 X-Stat-Signature: qmkcz4smdo5ne7esy86ofzawbzpqe7zu X-HE-Tag: 1649721759-612158 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000586, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 11, 2022 at 12:52:33PM +0200, Vlastimil Babka wrote: >On 4/9/22 01:07, Wei Yang wrote: >> On Fri, Apr 08, 2022 at 10:09:48AM +0200, David Hildenbrand wrote: >>>On 08.04.22 04:59, Wei Yang wrote: >>>> Since we just increase a constance of 1 to node penalty, it is not >>>> necessary to multiply MAX_NODE_LOAD for preference. >>>> >>>> This patch also remove the definition. >>>> >>>> [vbabka@suse.cz: suggests] >>>> >>>> Signed-off-by: Wei Yang >>>> CC: Vlastimil Babka >>>> CC: David Hildenbrand >>>> CC: Oscar Salvador >>>> --- >>>> mm/page_alloc.c | 3 +-- >>>> 1 file changed, 1 insertion(+), 2 deletions(-) >>>> >>>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c >>>> index 86b6573fbeb5..ca6a127bbc26 100644 >>>> --- a/mm/page_alloc.c >>>> +++ b/mm/page_alloc.c >>>> @@ -6170,7 +6170,6 @@ int numa_zonelist_order_handler(struct ctl_table *table, int write, >>>> } >>>> >>>> >>>> -#define MAX_NODE_LOAD (nr_online_nodes) >>>> static int node_load[MAX_NUMNODES]; >>>> >>>> /** >>>> @@ -6217,7 +6216,7 @@ int find_next_best_node(int node, nodemask_t *used_node_mask) >>>> val += PENALTY_FOR_NODE_WITH_CPUS; >>>> >>>> /* Slight preference for less loaded node */ >>>> - val *= (MAX_NODE_LOAD*MAX_NUMNODES); >>>> + val *= MAX_NUMNODES; >>>> val += node_load[n]; >>>> >>>> if (val < min_val) { >>> >>>I feel like this should be squashed into the previous patch. It has the >>>same effect of making this code independent of nr_online_nodes. And I >>>had to scratch my head a couple of times in patch #1 why the change in >>>patch #1 is fine with thus remaining in place. >>> >>> >>>Having that said, I consider this code highly unnecessary >>>over-complicated at first sight. Removing some of the magic most >>>certainly is very welcome. >>> >>>This semantics of the global variable node_load[] remains mostly >>>mysterious for me. > >Looks like after this patch(es), it would be "how many times was this node >picked as the first fallback out of nodes with the same distance"? > >>> >> >> So the suggestion is a v3 with #1 and #2 squashed? > >Yes, and I agree with the suggestion. No problem. > >>>-- >>>Thanks, >>> >>>David / dhildenb >> -- Wei Yang Help you, Help me