From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96908C433FE for ; Thu, 14 Apr 2022 06:50:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ECEC16B0071; Thu, 14 Apr 2022 02:50:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E7EB16B0073; Thu, 14 Apr 2022 02:50:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D6EA36B0074; Thu, 14 Apr 2022 02:50:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id C8DA86B0071 for ; Thu, 14 Apr 2022 02:50:57 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9D06F2155A for ; Thu, 14 Apr 2022 06:50:57 +0000 (UTC) X-FDA: 79354562154.14.7C6CBE5 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf24.hostedemail.com (Postfix) with ESMTP id EBA54180005 for ; Thu, 14 Apr 2022 06:50:56 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 0E936CE285A; Thu, 14 Apr 2022 06:50:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50978C385A1; Thu, 14 Apr 2022 06:50:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1649919052; bh=cYbubK9AB57IFaxLKwKzOx65Ex6FmM9jG7A94onuncM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SCpkEhdDMNx5PuGypTqsLr6YhwAlVEb7wjTyEeJL92fkhiZipeCeD3RQhGJv2rA5Q TgduuJjGeTOoUK1jilZd+XvUvcsctqYVq9kds3qkbRtKeI4TfI+nac6amNyV9Vs8NQ yB+q+ZdF0snVRJsZYWo4tiXIvV2LVBYYQiM+LswE= Date: Wed, 13 Apr 2022 23:50:51 -0700 From: Andrew Morton To: Liam Howlett , Yu Zhao Cc: "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v7 00/70] Introducing the Maple Tree Message-Id: <20220413235051.3a4eb7c86d31656c7aea250c@linux-foundation.org> In-Reply-To: <20220404143501.2016403-1-Liam.Howlett@oracle.com> References: <20220404143501.2016403-1-Liam.Howlett@oracle.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=SCpkEhdD; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Stat-Signature: k11tw8zxqd55ua7fz8j17qkb9oyiyjw8 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: EBA54180005 X-HE-Tag: 1649919056-187408 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 4 Apr 2022 14:35:26 +0000 Liam Howlett wrote: > Please add this patch set to your branch. They are based on v5.18-rc1. Do we get a nice [0/n] cover letter telling us all about this? I have that all merged up and it compiles. https://lkml.kernel.org/r/20220402094550.129-1-lipeifeng@oppo.com and https://lkml.kernel.org/r/20220412081014.399-1-lipeifeng@oppo.com are disabled for now. Several patches were marked From: Liam Signed-off-by: Matthew Signed-off-by: Liam Which makes me wonder whether the attribution was correct. Please double-check. I made a lame attempt to fix up mglru's get_next_vma(), and it probably wants a revisit in the maple-tree world anyway. Please check this and send me a better version ;) --- a/mm/vmscan.c~mglru-vs-maple-tree +++ a/mm/vmscan.c @@ -3704,7 +3704,7 @@ static bool get_next_vma(struct mm_walk while (walk->vma) { if (next >= walk->vma->vm_end) { - walk->vma = walk->vma->vm_next; + walk->vma = find_vma(walk->mm, walk->vma->vm_end); continue; } @@ -3712,7 +3712,7 @@ static bool get_next_vma(struct mm_walk return false; if (should_skip_vma(walk->vma->vm_start, walk->vma->vm_end, walk)) { - walk->vma = walk->vma->vm_next; + walk->vma = find_vma(walk->mm, walk->vma->vm_end); continue; } @@ -4062,7 +4062,7 @@ static void walk_mm(struct lruvec *lruve /* the caller might be holding the lock for write */ if (mmap_read_trylock(mm)) { unsigned long start = walk->next_addr; - unsigned long end = mm->highest_vm_end; + unsigned long end = TASK_SIZE; err = walk_page_range(mm, start, end, &mm_walk_ops, walk); I flung a tree up at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mmtemp containing mglru and mapletree and a few other things. Could the mglru and mapletree people please runtime test it, send any fixes?