From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1BCEC433EF for ; Thu, 14 Apr 2022 19:19:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 42F156B0071; Thu, 14 Apr 2022 15:19:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3DCD56B0073; Thu, 14 Apr 2022 15:19:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A46C6B0074; Thu, 14 Apr 2022 15:19:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 1BB976B0071 for ; Thu, 14 Apr 2022 15:19:15 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id DDBFC27656 for ; Thu, 14 Apr 2022 19:19:14 +0000 (UTC) X-FDA: 79356447828.09.844B806 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id 3BCD118000A for ; Thu, 14 Apr 2022 19:19:14 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 67F0961D16; Thu, 14 Apr 2022 19:19:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 935BFC385A1; Thu, 14 Apr 2022 19:19:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1649963952; bh=cmAgQ34MO+zKNJP8+Cq8Gpyoo2RCaNKr3MAzw2HUJ2w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uStoVx8H5lW50rNMzzWX2S2ZVBnh3fnnjT5lB1YkF9/KUPzUKnZRZlSmQjm5+goRq s8Wu9eJEIbQvYk3mYx5yPKV8MaScCTvfcf8hdHAPiDpZtfhYP00GUXwRxyym5JgEaa cClrvy3ng13F94NHj5nE+taOEsZj9z4CRH+DZfrg= Date: Thu, 14 Apr 2022 12:19:11 -0700 From: Andrew Morton To: Liam Howlett Cc: Yu Zhao , "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v7 00/70] Introducing the Maple Tree Message-Id: <20220414121911.8bb89fc3681b13af1566d79c@linux-foundation.org> In-Reply-To: <20220414171521.bgdvrirumd4atjhs@revolver> References: <20220404143501.2016403-1-Liam.Howlett@oracle.com> <20220413235051.3a4eb7c86d31656c7aea250c@linux-foundation.org> <20220414135706.rcn7zr36s2hcd5re@revolver> <20220414171521.bgdvrirumd4atjhs@revolver> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 3BCD118000A X-Rspam-User: Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=uStoVx8H; dmarc=none; spf=pass (imf06.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Stat-Signature: tmq5cmbo8zx66mnwjkrciet3po9mwtdk X-HE-Tag: 1649963954-539190 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 14 Apr 2022 17:15:26 +0000 Liam Howlett wrote: > > Also I noticed, for the end address to walk_page_range(), Matthew used > > -1 and you used ULONG_MAX in the maple branch; Andrew used TASK_SIZE > > below. Having a single value throughout would be great. > > I think ULONG_MAX would be best, we should probably change the below to > ULONG_MAX. I switched it to ULONG_MAX/ > I don't see the code below in mglru-mapletree (62dd11ea8d). Am I on the > right branch/commit? oop, sorry, sleepy guy failed to include all the mglru patches! It should be fixed now (4e03b8e70232).