From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13776C433F5 for ; Thu, 21 Apr 2022 13:51:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A52BC6B0073; Thu, 21 Apr 2022 09:51:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A01616B0074; Thu, 21 Apr 2022 09:51:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 918B16B0075; Thu, 21 Apr 2022 09:51:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id 85A106B0073 for ; Thu, 21 Apr 2022 09:51:07 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6B880957 for ; Thu, 21 Apr 2022 13:51:07 +0000 (UTC) X-FDA: 79381022574.02.FACDD1E Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf06.hostedemail.com (Postfix) with ESMTP id 5316418002F for ; Thu, 21 Apr 2022 13:51:05 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Kkf7z4hZmzhXbZ; Thu, 21 Apr 2022 21:50:55 +0800 (CST) Received: from huawei.com (10.175.124.27) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 21 Apr 2022 21:51:02 +0800 From: Miaohe Lin To: , CC: , , Subject: [PATCH] mm/memory_hotplug: avoid consuming corrupted data when offline pages Date: Thu, 21 Apr 2022 21:51:28 +0800 Message-ID: <20220421135129.19767-1-linmiaohe@huawei.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.175.124.27] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 5316418002F X-Stat-Signature: rkpqnrrup99iqijggxm17f59xmdy5413 Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf06.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Rspam-User: X-HE-Tag: 1650549065-19928 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: When trying to offline pages, HWPoisoned hugepage is migrated without checking PageHWPoison first. So corrupted data could be consumed. Fix it by deferring isolate_huge_page until PageHWPoison is handled. Signed-off-by: Miaohe Lin --- mm/memory_hotplug.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 4c6065e5d274..093f85ec5c5c 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -1600,11 +1600,9 @@ do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) folio = page_folio(page); head = &folio->page; - if (PageHuge(page)) { + if (PageHuge(page)) pfn = page_to_pfn(head) + compound_nr(head) - 1; - isolate_huge_page(head, &source); - continue; - } else if (PageTransHuge(page)) + else if (PageTransHuge(page)) pfn = page_to_pfn(head) + thp_nr_pages(page) - 1; /* @@ -1622,6 +1620,11 @@ do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) continue; } + if (PageHuge(page)) { + isolate_huge_page(head, &source); + continue; + } + if (!get_page_unless_zero(page)) continue; /* -- 2.23.0