From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73415C4332F for ; Tue, 26 Apr 2022 18:37:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A1CC6B0073; Tue, 26 Apr 2022 14:37:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 74F946B0074; Tue, 26 Apr 2022 14:37:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F48D6B0075; Tue, 26 Apr 2022 14:37:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 525586B0073 for ; Tue, 26 Apr 2022 14:37:53 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 24D5220783 for ; Tue, 26 Apr 2022 18:37:53 +0000 (UTC) X-FDA: 79399889226.04.79A606C Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) by imf08.hostedemail.com (Postfix) with ESMTP id 403C316003F for ; Tue, 26 Apr 2022 18:37:47 +0000 (UTC) Received: by mail-qv1-f42.google.com with SMTP id js10so532591qvb.0 for ; Tue, 26 Apr 2022 11:37:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vCAdqtcSv+Uuvkd1gfYn6mJK/62p5uI0bhh5S33HH+o=; b=hKQNNTwMC0Pg+p4P7tiCPZm0cj9miN42hel47mSzB3H5BqCOYQKy7Zgic6zuztiAgp vHNLCSMVT1/3s+QBInq9vSSbcKTFlfOHgP508j701VpKAAWJgcj10GaL/8p4VPFl4tDm QwLt+xl51ubmMorzTvwDBSmQvMDAgJfDSrfg1XHY34ECBP4qmpYBZPKRrN8q4na8RHt1 UyScxb9ei5p4apSOlkbOpxhfSiehS+0Ke9bl9BrT6yKoml5Nl0Oj70D/X/ay8in9Wv/z mBdvrmnuSPeFggrdGJ5yQTR269+20YgTk/0BqFZfoLCwJTnSsHlEyTXjCRNOBzjBGkF4 kPCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vCAdqtcSv+Uuvkd1gfYn6mJK/62p5uI0bhh5S33HH+o=; b=DR7vcmdW0i6dPx5YZxwIl3C9WfykDSesQstx6tyNXcfJtMnaShaHsOoDGk0MTN2oc/ a2cafVArI8UMWdvXhfLAxenbTfCTNtd7w4JarC9+n6ObB+nAlzn6wXJwAWfkEV4NDzrR ZlNLe9Fmtdgay09Av8CI7HSQf8Vuy81N4B2lqc7TST3M4YQj9eQQIGF1VWkNxeanMRUp 2uySPnaKL4siWKNBfOOGNpsScHIm52uLaMeXF+zHl7szWuiIX14TxjKi1ozB6WD7W8kr S35Z/sqwpydH7oXqoWWhheqa3UXrL1ZYqg+dVjBiSlum1m+hCcCI+3Jh77b5zhbZIVN3 QWpA== X-Gm-Message-State: AOAM533RPCyuI+Jh8NXTTS+DmwYrg8/eJLgy7Yd64sV9Q4n0XMwDD6S1 49vvKJQiBwqUp/WiVsnZPw== X-Google-Smtp-Source: ABdhPJyiC6wP3gKNyX3AB8SQeHDh5fHSv3C77/OXChNe05LMyjEqMoULU+d8RGd7Dppfigq92I0ycw== X-Received: by 2002:ad4:576f:0:b0:451:b403:2c3e with SMTP id r15-20020ad4576f000000b00451b4032c3emr16176767qvx.83.1650998272081; Tue, 26 Apr 2022 11:37:52 -0700 (PDT) Received: from moria.home.lan (c-73-219-103-14.hsd1.vt.comcast.net. [73.219.103.14]) by smtp.gmail.com with ESMTPSA id x2-20020a379502000000b0069d14dabad6sm6851134qkd.79.2022.04.26.11.37.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:37:51 -0700 (PDT) Date: Tue, 26 Apr 2022 14:37:49 -0400 From: Kent Overstreet To: Roman Gushchin Cc: Dave Chinner , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yang Shi , Hillf Danton Subject: Re: [PATCH v2 0/7] mm: introduce shrinker debugfs interface Message-ID: <20220426183749.iumpdardzltpf23y@moria.home.lan> References: <20220422202644.799732-1-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 403C316003F X-Stat-Signature: p4nst6qr4n5efyr4ho9z8sx97e5hgece Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=hKQNNTwM; spf=pass (imf08.hostedemail.com: domain of kent.overstreet@gmail.com designates 209.85.219.42 as permitted sender) smtp.mailfrom=kent.overstreet@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1650998267-96262 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 26, 2022 at 09:41:34AM -0700, Roman Gushchin wrote: > My plan is to work on convert shrinkers API to bytes and experiment > with different LRU implementations. I find an ability to easily export > statistics and other data (which doesn't exist now) via debugfs useful > (and way more convenient than changing existing tracepoints), as well as > an ability to trigger scanning of individual shrinkers. If nobody else > seeing any value here, I'm fine to keep these patches private, no reason > to argue about the output format then. I don't think converting the shrinker API to bytes instead of object counts is such a great idea - that's going to introducing new rounding errors and new corner cases when we can't free the exact # of bytes requested. I was thinking along the lines of adding reporting for memory usage in bytes as either an additional thing the .count_objects reports, or a new callback.