From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 851ADC433F5 for ; Wed, 27 Apr 2022 17:10:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D1FDD6B0071; Wed, 27 Apr 2022 13:10:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CD2D16B0073; Wed, 27 Apr 2022 13:10:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B96BC6B0074; Wed, 27 Apr 2022 13:10:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id A9B916B0071 for ; Wed, 27 Apr 2022 13:10:44 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5D22F21523 for ; Wed, 27 Apr 2022 17:10:44 +0000 (UTC) X-FDA: 79403298408.20.4CFFC07 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id 07E40180059 for ; Wed, 27 Apr 2022 17:10:41 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 418E761E04; Wed, 27 Apr 2022 17:10:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6550FC385A7; Wed, 27 Apr 2022 17:10:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1651079441; bh=l8saX0DCGAYsIkk1Ixkvp/bP+VE4XtuTAfKwaVWt6eE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zU2f9OU9vNaGvbUQZABYEJIyDv0rbP4jQWq8LFn5FZq7Dw+LFamnG2tnxulkmfuml CKaNkOqoROiQdOY9ssBOvhnnTObaTy210EIDPYP7HrkfOYZ0T9VvTB26TOJMzdQh2m 1P9vBSidPcXS8wUWvWett4r2Tb3DlvNCcpvTz8zI= Date: Wed, 27 Apr 2022 10:10:40 -0700 From: Andrew Morton To: Kefeng Wang Cc: Catalin Marinas , Will Deacon , , , Subject: Re: [PATCH 1/4] mm: ioremap: Setup phys_addr of struct vm_struct Message-Id: <20220427101040.bd4532c8ef093b47b3dd9eb5@linux-foundation.org> In-Reply-To: <20220427121413.168468-2-wangkefeng.wang@huawei.com> References: <20220427121413.168468-1-wangkefeng.wang@huawei.com> <20220427121413.168468-2-wangkefeng.wang@huawei.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: etmk8gydnt5ffxf6d3c1w3pafykgwc4k Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=zU2f9OU9; spf=pass (imf06.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 07E40180059 X-HE-Tag: 1651079441-969489 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 27 Apr 2022 20:14:10 +0800 Kefeng Wang wrote: > Show physical address in /proc/vmallocinfo. > > Signed-off-by: Kefeng Wang > --- > mm/ioremap.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/ioremap.c b/mm/ioremap.c > index 5fe598ecd9b7..522ef899c35f 100644 > --- a/mm/ioremap.c > +++ b/mm/ioremap.c > @@ -32,6 +32,7 @@ void __iomem *ioremap_prot(phys_addr_t addr, size_t size, unsigned long prot) > if (!area) > return NULL; > vaddr = (unsigned long)area->addr; > + area->phys_addr = addr; > > if (ioremap_page_range(vaddr, vaddr + size, addr, __pgprot(prot))) { > free_vm_area(area); Acked-by: Andrew Morton I checked a bunch of arch-specific implementations of ioremap_prot() and they're already doing this. As far as I can tell, only csky and riscv actually use this file (CONFIG_GENERIC_IOREMAP=y). But you're ARM(?) so I'm wondering how come you're patching it? Someone should do s/addr/phys_addr/ in this function, like the rest of the world (sensibly) does.