From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A9D8C433F5 for ; Wed, 27 Apr 2022 13:53:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A54C86B0071; Wed, 27 Apr 2022 09:53:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A038A6B0072; Wed, 27 Apr 2022 09:53:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A3426B0073; Wed, 27 Apr 2022 09:53:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 76D206B0071 for ; Wed, 27 Apr 2022 09:53:28 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 43F9920B35 for ; Wed, 27 Apr 2022 13:53:28 +0000 (UTC) X-FDA: 79402801296.27.A1C3E3F Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf15.hostedemail.com (Postfix) with ESMTP id 763AAA0059 for ; Wed, 27 Apr 2022 13:53:22 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2D06321118; Wed, 27 Apr 2022 13:53:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1651067606; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z0VSn2vEXwWXMGAfap1HPPywpjqAc/nB4nW5xPcHwuA=; b=f/xNu/kDIRTMogOu0Uw02XT1TextwCqsKVU5GEime6fEx0GQmAShKNghzduSIpnAvkWvIl 4XLpd3AXnkkx71Us1FiykJTL38kwzzkcISvSZKWwnE24AiQJotbu2LNxhs2RA6jAzmKmeI YWMQC29ImtGt9spIXjuzKoHdmIYLXW0= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DF00713A39; Wed, 27 Apr 2022 13:53:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ehVtNdVKaWJvZgAAMHmgww (envelope-from ); Wed, 27 Apr 2022 13:53:25 +0000 Date: Wed, 27 Apr 2022 15:53:24 +0200 From: Michal =?iso-8859-1?Q?Koutn=FD?= To: Waiman Long Cc: Tejun Heo , Zefan Li , Johannes Weiner , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Feng Tang , Andrew Morton , Michal Hocko , Dave Hansen , ying.huang@intel.com, stable@vger.kernel.org Subject: Re: [PATCH v2] cgroup/cpuset: Remove cpus_allowed/mems_allowed setup in cpuset_init_smp() Message-ID: <20220427135324.GB9823@blackbody.suse.cz> References: <20220425155505.1292896-1-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220425155505.1292896-1-longman@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="f/xNu/kD"; spf=pass (imf15.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 763AAA0059 X-Stat-Signature: ja39hh5mgj85yftys8xdr71bhe4n8um9 X-HE-Tag: 1651067602-513063 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello. On Mon, Apr 25, 2022 at 11:55:05AM -0400, Waiman Long wrote: > smp_init() is called after the first two init functions. So we don't > have a complete list of active cpus and memory nodes until later in > cpuset_init_smp() which is the right time to set up effective_cpus > and effective_mems. Yes. setup_arch prefill_possible_map cpuset_init (1) cgroup_init cpuset_bind (2a) ... kernel_init kernel_init_freeable ... cpuset_init_smp (3) ... ... cpuset_bind (2b) > > diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c > index 9390bfd9f1cd..6bd8f5ef40fe 100644 > --- a/kernel/cgroup/cpuset.c > +++ b/kernel/cgroup/cpuset.c > @@ -3390,8 +3390,9 @@ static struct notifier_block cpuset_track_online_nodes_nb = { > */ > void __init cpuset_init_smp(void) > { > - cpumask_copy(top_cpuset.cpus_allowed, cpu_active_mask); > - top_cpuset.mems_allowed = node_states[N_MEMORY]; > + /* > + * cpus_allowd/mems_allowed will be properly set up in cpuset_bind(). > + */ IIUC, the comment should say > + * cpus_allowed/mems_allowed were (v2) or will be (v1) properly set up in cpuset_bind(). (nit) Reviewed-by: Michal Koutný