From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D10DC433F5 for ; Thu, 28 Apr 2022 12:33:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE5646B0078; Thu, 28 Apr 2022 08:33:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E94D36B007E; Thu, 28 Apr 2022 08:33:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0E3C6B0080; Thu, 28 Apr 2022 08:33:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.26]) by kanga.kvack.org (Postfix) with ESMTP id BCFCC6B0078 for ; Thu, 28 Apr 2022 08:33:15 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 919C082199 for ; Thu, 28 Apr 2022 12:33:15 +0000 (UTC) X-FDA: 79406227950.19.C642B70 Received: from alexa-out.qualcomm.com (alexa-out.qualcomm.com [129.46.98.28]) by imf25.hostedemail.com (Postfix) with ESMTP id 69120A0062 for ; Thu, 28 Apr 2022 12:33:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1651149195; x=1682685195; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Cqiwfsgz83HUrc2YamHpGLm5/CfzcmPlrOmDUNR+1D4=; b=VI08FZXd2C+jrPw2OIxd7LXuMWICc1Qu0xXAaAfanOZSmOqvfAo0Q9kZ ee0KjCN56p+C7s0N2ncc8f81rI4gqZzVckosdQvL+cCcrA/Z6pzzhre42 IplKDoIcBkuPb9IpXFl+LLtYLmg8n3tD7UV3GFD5e3VWIYpt04oXpB6E7 0=; Received: from ironmsg-lv-alpha.qualcomm.com ([10.47.202.13]) by alexa-out.qualcomm.com with ESMTP; 28 Apr 2022 05:33:13 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg-lv-alpha.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2022 05:33:12 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Thu, 28 Apr 2022 05:33:12 -0700 Received: from qian (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Thu, 28 Apr 2022 05:33:10 -0700 Date: Thu, 28 Apr 2022 08:33:08 -0400 From: Qian Cai To: Zi Yan CC: David Hildenbrand , , , , Vlastimil Babka , Mel Gorman , Eric Ren , Mike Rapoport , "Oscar Salvador" , Christophe Leroy , Andrew Morton Subject: Re: [PATCH v11 0/6] Use pageblock_order for cma and alloc_contig_range alignment. Message-ID: <20220428123308.GA71@qian> References: <20220425143118.2850746-1-zi.yan@sent.com> <20220426201855.GA1014@qian> <20220426210801.GA1038@qian> <2B9844C8-6D35-41E2-ACB2-9854E7A9C29F@nvidia.com> <20220427132720.GC71@qian> <1D88AE1B-4DFC-400F-A054-662E3824C9AF@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-Stat-Signature: 93ky57qer45ncafyiocpi3w6tat4guun X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 69120A0062 Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=quicinc.com header.s=qcdkim header.b=VI08FZXd; spf=pass (imf25.hostedemail.com: domain of quic_qiancai@quicinc.com designates 129.46.98.28 as permitted sender) smtp.mailfrom=quic_qiancai@quicinc.com; dmarc=pass (policy=none) header.from=quicinc.com X-Rspam-User: X-HE-Tag: 1651149186-792796 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 27, 2022 at 05:04:39PM -0400, Zi Yan wrote: > Do you mind checking if the patch below fixes the issue? It works > for me. > > The original code was trying to migrate non-migratible compound pages > (high-order slab pages from my tests) during isolation and caused > an infinite loop. The patch avoids non-migratible pages. > > I will update my patch series once we confirm the patch fixes > the bug. I am not able to apply it on today's linux-next tree. $ patch -Np1 --dry-run < ../patch/migrate.patch checking file mm/page_isolation.c Hunk #1 FAILED at 367. 1 out of 1 hunk FAILED