From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A12CC433F5 for ; Fri, 13 May 2022 17:42:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F09886B0080; Fri, 13 May 2022 13:42:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EB9D36B0081; Fri, 13 May 2022 13:42:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5AC96B0082; Fri, 13 May 2022 13:42:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C6AD96B0080 for ; Fri, 13 May 2022 13:42:14 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id 79EDA1204B6 for ; Fri, 13 May 2022 17:42:14 +0000 (UTC) X-FDA: 79461438588.07.03ED279 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) by imf02.hostedemail.com (Postfix) with ESMTP id C0398800C3 for ; Fri, 13 May 2022 17:42:05 +0000 (UTC) Received: by mail-qk1-f169.google.com with SMTP id n8so7555616qke.11 for ; Fri, 13 May 2022 10:42:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=97E4heSYwRBKYVRwXdi6vqHrNTq98nZhg9phqwxgAhQ=; b=6kYDXdS82NZvteVbhNjcwniGrQ4RnJeg36567888tof7EUAkKDlYJ+YEwjxRV4VrG8 d5IGcjxTh61zmD+wEyBSu/KnmdXn7o/K6hmJqQEsRCkqT+tPOgG24yjurqmZM0YftAb6 4Lx28hGScNQ9kDorsQ4f8q8wEftkum46HcovtD8TxvchjVloW172E2uNAjSwGXBNlYfB yOWwhyHXQgSfHrn8hmyU7AicyOriaVd2ixC68DWNRTaetHRFpoGyu6bqMWZxMac+tqhK 3Jw6jRij9gCxzUW8kG5GzJHGJ+c1hwiZ8I6dOedowIUxywNdLLhTS1eRbETkPSDGBYzU Igvg== X-Gm-Message-State: AOAM532upoPHG2zc+S/AXTdSQazuvkqaGSRB4B1rIjdw1HFvv7PLYd5l 74cjsKcU37PNIaft0OM5CPE= X-Google-Smtp-Source: ABdhPJw/SDz0dQHBIutw7pRAimO1JpJHMkuofuWyT/cEabDgF7Kn0Vimv3OrPdeEdfry+uEXmlkDpA== X-Received: by 2002:a37:98c4:0:b0:69a:e14:16a2 with SMTP id a187-20020a3798c4000000b0069a0e1416a2mr4538933qke.610.1652463733017; Fri, 13 May 2022 10:42:13 -0700 (PDT) Received: from dev0025.ash9.facebook.com (fwdproxy-ash-014.fbsv.net. [2a03:2880:20ff:e::face:b00c]) by smtp.gmail.com with ESMTPSA id u123-20020ae9d881000000b006a0462eb091sm1634970qkf.80.2022.05.13.10.42.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 May 2022 10:42:12 -0700 (PDT) Date: Fri, 13 May 2022 10:42:11 -0700 From: David Vernet To: Michal =?utf-8?Q?Koutn=C3=BD?= Cc: akpm@linux-foundation.org, cgroups@vger.kernel.org, hannes@cmpxchg.org, kernel-team@fb.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, tj@kernel.org, Richard Palethorpe Subject: Re: [PATCH 2/4] selftests: memcg: Expect no low events in unprotected sibling Message-ID: <20220513174211.uv5yxzt5sochmwal@dev0025.ash9.facebook.com> References: <20220512174452.tr34tuh4k5jm6qjs@dev0025.ash9.facebook.com> <20220513171811.730-1-mkoutny@suse.com> <20220513171811.730-3-mkoutny@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220513171811.730-3-mkoutny@suse.com> User-Agent: NeoMutt/20211029 X-Stat-Signature: ph18k5ya6hh3xohjh5tk5oxbctisn9mc Authentication-Results: imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of dcvernet@gmail.com designates 209.85.222.169 as permitted sender) smtp.mailfrom=dcvernet@gmail.com; dmarc=none X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: C0398800C3 X-HE-Tag: 1652463725-754157 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 13, 2022 at 07:18:09PM +0200, Michal Koutný wrote: > This is effectively a revert of commit cdc69458a5f3 ("cgroup: account > for memory_recursiveprot in test_memcg_low()"). The case test_memcg_low > will fail with memory_recursiveprot until resolved in reclaim > code. > However, this patch preserves the existing helpers and variables for > later uses. > > Signed-off-by: Michal Koutný > --- > tools/testing/selftests/cgroup/test_memcontrol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/cgroup/test_memcontrol.c b/tools/testing/selftests/cgroup/test_memcontrol.c > index 4958b42201a9..eba252fa64ac 100644 > --- a/tools/testing/selftests/cgroup/test_memcontrol.c > +++ b/tools/testing/selftests/cgroup/test_memcontrol.c > @@ -528,7 +528,7 @@ static int test_memcg_low(const char *root) > } > > for (i = 0; i < ARRAY_SIZE(children); i++) { > - int no_low_events_index = has_recursiveprot ? 2 : 1; > + int no_low_events_index = 1; > > oom = cg_read_key_long(children[i], "memory.events", "oom "); > low = cg_read_key_long(children[i], "memory.events", "low "); > -- > 2.35.3 > Reviewed-by: David Vernet