From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22411CCA47B for ; Wed, 15 Jun 2022 17:29:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B1F556B0074; Wed, 15 Jun 2022 13:29:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ACEAF6B0075; Wed, 15 Jun 2022 13:29:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9700F6B0078; Wed, 15 Jun 2022 13:29:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8803D6B0074 for ; Wed, 15 Jun 2022 13:29:39 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 6A5A0601E8 for ; Wed, 15 Jun 2022 17:29:39 +0000 (UTC) X-FDA: 79581157278.04.DF37076 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by imf26.hostedemail.com (Postfix) with ESMTP id A222314009E for ; Wed, 15 Jun 2022 17:29:38 +0000 (UTC) Received: by mail-pj1-f54.google.com with SMTP id e9so11831550pju.5 for ; Wed, 15 Jun 2022 10:29:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WrF836BhqYoAAQYNFMJen23eOl+F6zz51fEhzRe3ck4=; b=jNiMa1EClCZmNoxHFwK9zkQt71WNj8eQXx1AtJzkARohOhJSxbNe9g9wKpdtMdMiFM JUylBaxwrEsHZe9FDtW/ty8pZHqkoiXrCVnIf4XeVJdT7glhN+11Co4GX3RF1sUTcydf V3HfSNZro9f+AcdFfuHK+L4B6g8H28LVBK/7P7o1JiWQR01uO+wBiMM/9HiCPM6SAMQx d2a2Sz0T524tVIKdzfkdECmzkPJH8aXQXrXRWCyPKVJHg489kISeCmxjam/lwp9uY3TL eupQy8+iv/QTL3N+W5Rklt4NRIJ/YA5TCnZRDnOfKJw5G4UK28mGTOs/faVfewTqkG2c Oztw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WrF836BhqYoAAQYNFMJen23eOl+F6zz51fEhzRe3ck4=; b=PVbcqXdRC5D2I16mjH9bM50OPaO2sHHaC5969+yx8rwy2ayY7wmBzlBnMng0I6v4Xa fNMbacKnAlaO/o6GY/LBcv02pmjqyn20Yf/2jM1JJ2+vnSPJ01bsQ15fxejXOWDJSsS8 lbyIi5pS+HHET3vG6WksSBP8gh5N7sTkI39sfRtJ8dPSntBVQ97xCJbXRNWzVA/CaCCQ /4c3TOGg7JtozxXoAS62yxeQNLhT0vtEBIrP2I/k7equcphLnSVdElHvxCQKE4Y1+lcm 6Mf7eDPG8aomsBEl86YsAcr3BnOE0XcIgmmM04JmFuMe9zhqqExWhJJW6+U5cFJVtmax 7N3A== X-Gm-Message-State: AJIora9sbX3uqZVMeHAVJK20CviiYBlrRVWE84naSLZI+FAKgaFknq7D QxGZwF/LVMeWSqaMARFqQJY= X-Google-Smtp-Source: AGRyM1vRDq5qAc7St9qdLuZS57haehWUHZEdEiVLV8l2rTbRMydreLZ77f4O354sxk37OOZMcG9tJw== X-Received: by 2002:a17:90b:4c4c:b0:1e8:6f9a:b642 with SMTP id np12-20020a17090b4c4c00b001e86f9ab642mr11434299pjb.21.1655314177666; Wed, 15 Jun 2022 10:29:37 -0700 (PDT) Received: from localhost.localdomain (c-67-174-241-145.hsd1.ca.comcast.net. [67.174.241.145]) by smtp.gmail.com with ESMTPSA id w14-20020a1709029a8e00b001676f87473fsm9552244plp.302.2022.06.15.10.29.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jun 2022 10:29:37 -0700 (PDT) From: Yang Shi To: vbabka@suse.cz, kirill.shutemov@linux.intel.com, willy@infradead.org, zokeefe@google.com, linmiaohe@huawei.com, akpm@linux-foundation.org Cc: shy828301@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [v4 PATCH 3/7] mm: khugepaged: better comments for anon vma check in hugepage_vma_revalidate Date: Wed, 15 Jun 2022 10:29:22 -0700 Message-Id: <20220615172926.546974-4-shy828301@gmail.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20220615172926.546974-1-shy828301@gmail.com> References: <20220615172926.546974-1-shy828301@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655314178; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WrF836BhqYoAAQYNFMJen23eOl+F6zz51fEhzRe3ck4=; b=f7pFRNWHkP0X6lZJNR8/GJtOlDInt2hBlc5VtQtD/oRhsw4EwnnNpzVCD0GJDT54T0hZtk cy/xAmiEpsIb7f8mB8N1ANK8/XE1i1Kuqx8iK3i3JX+jeKiMGq3z9Z7VFnYyP+lvKJjLui P32iEwd0kFN5nLYZuzTuhkFdRjrlLHY= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=jNiMa1EC; spf=pass (imf26.hostedemail.com: domain of shy828301@gmail.com designates 209.85.216.54 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655314178; a=rsa-sha256; cv=none; b=zfbNgXp9NOSxMNC8IxLa4WPyhhEd8siLM8a5mg+QmiDC1ed7IwYMYUDF+B2j2k2zOsScH0 kHy/u5UF8PbWMhRokhAA9gKIm6poc+/2fqjQqUpJPhqtqVfzsA6/EVGOrcIolzbX2PGA85 nJoj3/g8cTulelKgWoGhn5PiQRI3SwQ= X-Stat-Signature: sx7atwrra5s6fdsrn51rkp79h9j8h64q X-Rspamd-Queue-Id: A222314009E X-Rspamd-Server: rspam11 X-Rspam-User: Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=jNiMa1EC; spf=pass (imf26.hostedemail.com: domain of shy828301@gmail.com designates 209.85.216.54 as permitted sender) smtp.mailfrom=shy828301@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1655314178-283401 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The hugepage_vma_revalidate() needs to check if the vma is still anonymous vma or not since the address may be unmapped then remapped to file before khugepaged reaquired the mmap_lock. The old comment is not quite helpful, elaborate this with better comment. Signed-off-by: Yang Shi --- mm/khugepaged.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/mm/khugepaged.c b/mm/khugepaged.c index db0b334a7d1f..5baa394e34c8 100644 --- a/mm/khugepaged.c +++ b/mm/khugepaged.c @@ -960,7 +960,13 @@ static int hugepage_vma_revalidate(struct mm_struct *mm, unsigned long address, return SCAN_ADDRESS_RANGE; if (!hugepage_vma_check(vma, vma->vm_flags)) return SCAN_VMA_CHECK; - /* Anon VMA expected */ + /* + * Anon VMA expected, the address may be unmapped then + * remapped to file after khugepaged reaquired the mmap_lock. + * + * hugepage_vma_check may return true for qualified file + * vmas. + */ if (!vma->anon_vma || !vma_is_anonymous(vma)) return SCAN_VMA_CHECK; return 0; -- 2.26.3