From: Andrew Morton <akpm@linux-foundation.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH 0/5] mm: Pass pointers to page accessors
Date: Fri, 1 Jul 2022 16:00:04 -0700 [thread overview]
Message-ID: <20220701160004.2ffff4e5ab59a55499f4c736@linux-foundation.org> (raw)
In-Reply-To: <20220630084124.691207-1-linus.walleij@linaro.org>
On Thu, 30 Jun 2022 10:41:19 +0200 Linus Walleij <linus.walleij@linaro.org> wrote:
> In a recent change to the Arm architecture with the end goal
> of removing highmem we need to convert virt_to_phys() and
> virt_to_pfn() to static inline functions.
>
> This will make them strongly typed.
>
> However since virt_to_* is always implemented as macros they
> have become polymorphic and accept both (void *) and
> e.g. unsigned long as arguments.
>
> Other functions such as virt_to_page() simply wrap
> virt_to_pfn() and get affected indirectly.
>
> To be able to proceed, patch mm to use (void *) as argument
> to affected functions in all instances.
It would be nice if someone were to teach x86 and others to use static
inlines. Get rid of those stupid macros and improve coverage for your
changes.
next prev parent reply other threads:[~2022-07-01 23:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 8:41 [PATCH 0/5] mm: Pass pointers to page accessors Linus Walleij
2022-06-30 8:41 ` [PATCH 1/5] lib/test_free_pages.c: Pass a pointer to virt_to_page() Linus Walleij
2022-06-30 8:41 ` [PATCH 2/5] mm/highmem: " Linus Walleij
2022-06-30 8:41 ` [PATCH 3/5] mm: kfence: " Linus Walleij
2022-06-30 9:23 ` Marco Elver
2022-06-30 8:41 ` [PATCH 4/5] mm: gup: " Linus Walleij
2022-07-01 0:29 ` Jason Gunthorpe
2022-07-01 9:11 ` Linus Walleij
2022-06-30 8:41 ` [PATCH 5/5] mm: nommu: " Linus Walleij
2022-07-01 23:00 ` Andrew Morton [this message]
2022-07-03 13:28 ` [PATCH 0/5] mm: Pass pointers to page accessors Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220701160004.2ffff4e5ab59a55499f4c736@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).