linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Liam Howlett <liam.howlett@oracle.com>
To: "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Liam Howlett <liam.howlett@oracle.com>, Vlastimil Babka <vbabka@suse.cz>
Subject: [PATCH v13 69/70] mm/mmap: drop range_has_overlap() function
Date: Mon, 22 Aug 2022 15:06:34 +0000	[thread overview]
Message-ID: <20220822150128.1562046-70-Liam.Howlett@oracle.com> (raw)
In-Reply-To: <20220822150128.1562046-1-Liam.Howlett@oracle.com>

From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>

Since there is no longer a linked list, the range_has_overlap() function
is identical to the find_vma_intersection() function.

Signed-off-by: Liam R. Howlett <Liam.Howlett@Oracle.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
---
 mm/mmap.c | 27 +--------------------------
 1 file changed, 1 insertion(+), 26 deletions(-)

diff --git a/mm/mmap.c b/mm/mmap.c
index 4441f7ed197a..5070af64b99d 100644
--- a/mm/mmap.c
+++ b/mm/mmap.c
@@ -390,30 +390,6 @@ anon_vma_interval_tree_post_update_vma(struct vm_area_struct *vma)
 		anon_vma_interval_tree_insert(avc, &avc->anon_vma->rb_root);
 }
 
-/*
- * range_has_overlap() - Check the @start - @end range for overlapping VMAs and
- * sets up a pointer to the previous VMA
- * @mm: the mm struct
- * @start: the start address of the range
- * @end: the end address of the range
- * @pprev: the pointer to the pointer of the previous VMA
- *
- * Returns: True if there is an overlapping VMA, false otherwise
- */
-static inline
-bool range_has_overlap(struct mm_struct *mm, unsigned long start,
-		       unsigned long end, struct vm_area_struct **pprev)
-{
-	struct vm_area_struct *existing;
-
-	MA_STATE(mas, &mm->mm_mt, start, start);
-	rcu_read_lock();
-	existing = mas_find(&mas, end - 1);
-	*pprev = mas_prev(&mas, 0);
-	rcu_read_unlock();
-	return existing ? true : false;
-}
-
 static unsigned long count_vma_pages_range(struct mm_struct *mm,
 		unsigned long addr, unsigned long end)
 {
@@ -3178,11 +3154,10 @@ void exit_mmap(struct mm_struct *mm)
  */
 int insert_vm_struct(struct mm_struct *mm, struct vm_area_struct *vma)
 {
-	struct vm_area_struct *prev;
 	unsigned long charged = vma_pages(vma);
 
 
-	if (range_has_overlap(mm, vma->vm_start, vma->vm_end, &prev))
+	if (find_vma_intersection(mm, vma->vm_start, vma->vm_end))
 		return -ENOMEM;
 
 	if ((vma->vm_flags & VM_ACCOUNT) &&
-- 
2.35.1


      parent reply	other threads:[~2022-08-22 15:09 UTC|newest]

Thread overview: 104+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-22 15:01 [PATCH v13 00/70] Introducing the Maple Tree Liam Howlett
2022-08-22 15:02 ` [PATCH v13 01/70] Maple Tree: add new data structure Liam Howlett
2022-08-22 15:02 ` [PATCH v13 02/70] radix tree test suite: add pr_err define Liam Howlett
2022-08-22 15:02 ` [PATCH v13 03/70] radix tree test suite: add kmem_cache_set_non_kernel() Liam Howlett
2022-08-22 15:02 ` [PATCH v13 04/70] radix tree test suite: add allocation counts and size to kmem_cache Liam Howlett
2022-08-22 15:02 ` [PATCH v13 05/70] radix tree test suite: add support for slab bulk APIs Liam Howlett
2022-08-22 15:02 ` [PATCH v13 06/70] radix tree test suite: add lockdep_is_held to header Liam Howlett
2022-08-22 15:02 ` [PATCH v13 07/70] lib/test_maple_tree: add testing for maple tree Liam Howlett
2022-08-31  1:54   ` [PATCH v13 7/70] " Davidlohr Bueso
2022-08-22 15:02 ` [PATCH v13 08/70] mm: start tracking VMAs with " Liam Howlett
2022-08-22 15:02 ` [PATCH v13 09/70] mm: add VMA iterator Liam Howlett
2022-08-23 17:05   ` [PATCH v13 9/70] " Davidlohr Bueso
2022-08-22 15:02 ` [PATCH v13 10/70] mmap: use the VMA iterator in count_vma_pages_range() Liam Howlett
2022-08-31  1:38   ` Davidlohr Bueso
2022-08-22 15:03 ` [PATCH v13 11/70] mm/mmap: use the maple tree in find_vma() instead of the rbtree Liam Howlett
2022-08-22 15:03 ` [PATCH v13 12/70] mm/mmap: use the maple tree for find_vma_prev() " Liam Howlett
2022-08-22 15:03 ` [PATCH v13 13/70] mm/mmap: use maple tree for unmapped_area{_topdown} Liam Howlett
2022-08-22 15:03 ` [PATCH v13 14/70] kernel/fork: use maple tree for dup_mmap() during forking Liam Howlett
2022-08-22 15:03 ` [PATCH v13 15/70] damon: convert __damon_va_three_regions to use the VMA iterator Liam Howlett
2022-08-22 15:03 ` [PATCH v13 16/70] proc: remove VMA rbtree use from nommu Liam Howlett
2022-08-31  1:27   ` Davidlohr Bueso
2022-08-22 15:03 ` [PATCH v13 17/70] mm: remove rb tree Liam Howlett
2022-08-22 15:04 ` [PATCH v13 18/70] mmap: change zeroing of maple tree in __vma_adjust() Liam Howlett
2022-08-22 15:04 ` [PATCH v13 19/70] xen: use vma_lookup() in privcmd_ioctl_mmap() Liam Howlett
2022-08-22 15:04 ` [PATCH v13 20/70] mm: optimize find_exact_vma() to use vma_lookup() Liam Howlett
2022-08-22 15:04 ` [PATCH v13 21/70] mm/khugepaged: optimize collapse_pte_mapped_thp() by using vma_lookup() Liam Howlett
2022-08-22 15:05 ` [PATCH v13 22/70] mm/mmap: change do_brk_flags() to expand existing VMA and add do_brk_munmap() Liam Howlett
2022-08-22 15:05 ` [PATCH v13 23/70] mm: use maple tree operations for find_vma_intersection() Liam Howlett
2022-08-22 15:05 ` [PATCH v13 24/70] mm/mmap: use advanced maple tree API for mmap_region() Liam Howlett
2022-08-22 15:05 ` [PATCH v13 25/70] mm: remove vmacache Liam Howlett
2022-08-22 15:05 ` [PATCH v13 26/70] mm: convert vma_lookup() to use mtree_load() Liam Howlett
2022-08-22 15:05 ` [PATCH v13 27/70] mm/mmap: move mmap_region() below do_munmap() Liam Howlett
2022-08-22 15:05 ` [PATCH v13 28/70] mm/mmap: reorganize munmap to use maple states Liam Howlett
2022-08-22 15:05 ` [PATCH v13 29/70] mm/mmap: change do_brk_munmap() to use do_mas_align_munmap() Liam Howlett
2022-08-22 15:05 ` [PATCH v13 30/70] arm64: remove mmap linked list from vdso Liam Howlett
2022-08-23 18:44   ` Davidlohr Bueso
2022-08-22 15:05 ` [PATCH v13 31/70] arm64: Change elfcore for_each_mte_vma() to use VMA iterator Liam Howlett
2022-08-23 22:27   ` Davidlohr Bueso
2022-08-22 15:05 ` [PATCH v13 32/70] parisc: remove mmap linked list from cache handling Liam Howlett
2022-08-23 19:07   ` Davidlohr Bueso
2022-08-22 15:05 ` [PATCH v13 33/70] powerpc: remove mmap linked list walks Liam Howlett
2022-08-23 18:51   ` Davidlohr Bueso
2022-08-22 15:06 ` [PATCH v13 34/70] s390: remove vma " Liam Howlett
2022-08-23 18:34   ` Davidlohr Bueso
2022-08-22 15:06 ` [PATCH v13 35/70] x86: " Liam Howlett
2022-08-23 17:58   ` Davidlohr Bueso
2022-08-22 15:06 ` [PATCH v13 36/70] xtensa: " Liam Howlett
2022-08-25 15:48   ` Davidlohr Bueso
2022-08-22 15:06 ` [PATCH v13 39/70] um: remove vma linked list walk Liam Howlett
2022-08-23 18:00   ` Davidlohr Bueso
2022-08-22 15:06 ` [PATCH v13 37/70] cxl: " Liam Howlett
2022-08-22 15:06 ` [PATCH v13 38/70] optee: " Liam Howlett
2022-08-24  1:31   ` Davidlohr Bueso
2022-08-22 15:06 ` [PATCH v13 43/70] fs/proc/task_mmu: stop using linked list and highest_vm_end Liam Howlett
2022-08-22 15:06 ` [PATCH v13 40/70] coredump: remove vma linked list walk Liam Howlett
2022-08-22 15:06 ` [PATCH v13 41/70] exec: use VMA iterator instead of linked list Liam Howlett
2022-08-22 15:06 ` [PATCH v13 42/70] fs/proc/base: use maple tree iterators in place " Liam Howlett
2022-08-24  1:21   ` Davidlohr Bueso
2022-08-24 15:12     ` [PATCH] " Liam Howlett
2022-08-25 16:01       ` Davidlohr Bueso
2022-08-25 16:58         ` Liam Howlett
2022-08-22 15:06 ` [PATCH v13 46/70] acct: use VMA iterator instead " Liam Howlett
2022-08-23 18:39   ` Davidlohr Bueso
2022-08-22 15:06 ` [PATCH v13 44/70] userfaultfd: use maple tree iterator to iterate VMAs Liam Howlett
2022-08-22 15:06 ` [PATCH v13 45/70] ipc/shm: use VMA iterator instead of linked list Liam Howlett
2022-08-22 15:06 ` [PATCH v13 48/70] sched: use maple tree iterator to walk VMAs Liam Howlett
2022-08-22 15:06 ` [PATCH v13 47/70] perf: use VMA iterator Liam Howlett
2022-08-23 17:44   ` Davidlohr Bueso
2022-08-22 15:06 ` [PATCH v13 49/70] fork: " Liam Howlett
2022-08-23 18:32   ` Davidlohr Bueso
2022-08-22 15:06 ` [PATCH v13 51/70] mm/gup: use maple tree navigation instead of linked list Liam Howlett
2022-09-06 16:44   ` Davidlohr Bueso
2022-08-22 15:06 ` [PATCH v13 52/70] mm/khugepaged: stop using vma " Liam Howlett
2022-09-06 16:51   ` Davidlohr Bueso
2022-08-22 15:06 ` [PATCH v13 50/70] bpf: remove VMA " Liam Howlett
2022-08-22 15:06 ` [PATCH v13 54/70] mm/madvise: use vma_find() instead of vma " Liam Howlett
2022-09-06 16:54   ` Davidlohr Bueso
2022-08-22 15:06 ` [PATCH v13 53/70] mm/ksm: use vma iterators " Liam Howlett
2022-09-06 17:24   ` Davidlohr Bueso
2022-08-22 15:06 ` [PATCH v13 55/70] mm/memcontrol: stop using mm->highest_vm_end Liam Howlett
2022-08-22 15:06 ` [PATCH v13 58/70] mm/mprotect: use maple tree navigation instead of vma linked list Liam Howlett
2022-08-22 15:06 ` [PATCH v13 57/70] mm/mlock: use vma iterator and maple state " Liam Howlett
2022-08-25  0:34   ` Mark Brown
2022-08-25 13:21     ` Liam Howlett
2022-08-25 15:20       ` Catalin Marinas
2022-08-25 20:21         ` Liam Howlett
2022-08-22 15:06 ` [PATCH v13 56/70] mm/mempolicy: use vma iterator & " Liam Howlett
2022-08-22 15:06 ` [PATCH v13 60/70] mm/msync: use vma_find() " Liam Howlett
2022-08-31  2:55   ` Davidlohr Bueso
2022-08-22 15:06 ` [PATCH v13 61/70] mm/oom_kill: use maple tree iterators " Liam Howlett
2022-08-31  1:59   ` Davidlohr Bueso
2022-08-22 15:06 ` [PATCH v13 59/70] mm/mremap: use vma_find_intersection() " Liam Howlett
2022-09-06 18:04   ` Davidlohr Bueso
2022-08-22 15:06 ` [PATCH v13 62/70] mm/pagewalk: use vma_find() " Liam Howlett
2022-08-22 15:06 ` [PATCH v13 64/70] i915: use the VMA iterator Liam Howlett
2022-08-22 15:06 ` [PATCH v13 63/70] mm/swapfile: use vma iterator instead of vma linked list Liam Howlett
2022-08-31  2:07   ` Davidlohr Bueso
2022-08-22 15:06 ` [PATCH v13 65/70] nommu: remove uses of VMA " Liam Howlett
2022-08-22 15:06 ` [PATCH v13 67/70] mm/vmscan: Use vma iterator instead of vm_next Liam Howlett
2022-08-22 15:06 ` [PATCH v13 68/70] mm: remove the vma linked list Liam Howlett
2022-08-22 15:06 ` [PATCH v13 66/70] riscv: use vma iterator for vdso Liam Howlett
2022-08-31  1:43   ` Davidlohr Bueso
2022-08-22 15:06 ` [PATCH v13 70/70] mm/mmap.c: pass in mapping to __vma_link_file() Liam Howlett
2022-08-22 15:06 ` Liam Howlett [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220822150128.1562046-70-Liam.Howlett@oracle.com \
    --to=liam.howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=maple-tree@lists.infradead.org \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).