From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2088ECAAA1 for ; Mon, 5 Sep 2022 03:29:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 083E580199; Sun, 4 Sep 2022 23:29:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 032A58019D; Sun, 4 Sep 2022 23:29:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E153180199; Sun, 4 Sep 2022 23:29:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CC9BD8D0031 for ; Sun, 4 Sep 2022 23:29:40 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9960D120222 for ; Mon, 5 Sep 2022 03:29:40 +0000 (UTC) X-FDA: 79876602120.20.9F572F5 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf26.hostedemail.com (Postfix) with ESMTP id DB481140084 for ; Mon, 5 Sep 2022 03:29:39 +0000 (UTC) Received: from dggpemm500024.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4MLYnV6M6vz1N7v4; Mon, 5 Sep 2022 11:25:50 +0800 (CST) Received: from dggpemm500014.china.huawei.com (7.185.36.153) by dggpemm500024.china.huawei.com (7.185.36.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 5 Sep 2022 11:29:36 +0800 Received: from localhost.localdomain (10.175.112.125) by dggpemm500014.china.huawei.com (7.185.36.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 5 Sep 2022 11:29:35 +0800 From: Wupeng Ma To: , , , , CC: , , , , , , , , , , , , , , Subject: [PATCH -next v3 1/2] mm: Cap zone movable's min wmark to small value Date: Mon, 5 Sep 2022 11:28:57 +0800 Message-ID: <20220905032858.1462927-2-mawupeng1@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220905032858.1462927-1-mawupeng1@huawei.com> References: <20220905032858.1462927-1-mawupeng1@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.175.112.125] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm500014.china.huawei.com (7.185.36.153) X-CFilter-Loop: Reflected ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662348580; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hNCwcaQOwL5QZ+wqWtn7myGnm/r9RkPUDiOcSigpq8o=; b=uByKukpU2pdmzNKtrkzaosA1JIWF+E44IRy0P9spPyy1MPYGgPvQjR1WU26zqDZvwQcZGc jolUFbU9CQN/M7Hi5nZIdtFGQ84wlx5gvBx8B3njAzeb43CUglYgmiDPPnK+jlrAEG4xef TG1pOmkvVpAmQ9Z6zlEakB+x9KT9u1I= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of mawupeng1@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=mawupeng1@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662348580; a=rsa-sha256; cv=none; b=SeQZu0nA4Ge6IeN6GtAPonaQxFzXTHefH6PVbXM0NsTc+zfdmY82Wqnn9QoQ3Xhz/Wdm1o wqSATlZkLiXQtg/0T+Gt9DJpuJVLwg+cYh9iVHkkP/07ZWerrj72YxUaV/g7GaDHbZ4qDJ LvQAMtiA4Rx4SvoLbSN37gvFEV99624= X-Rspam-User: X-Stat-Signature: 73mp6i1bj6zjbcbwoutkp5nxgobaai59 X-Rspamd-Queue-Id: DB481140084 Authentication-Results: imf26.hostedemail.com; dkim=none; spf=pass (imf26.hostedemail.com: domain of mawupeng1@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=mawupeng1@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspamd-Server: rspam04 X-HE-Tag: 1662348579-897412 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Ma Wupeng Since min_free_kbytes is based on gfp_zone(GFP_USER) which does not include zone movable. However zone movable will get its min share in __setup_per_zone_wmarks() which does not make any sense. And like highmem pages, __GFP_HIGH and PF_MEMALLOC allocations usually don't need movable pages, so there is no need to assign min pages for zone movable. Let's cap pages_min for zone movable to a small value here just link highmem pages. Signed-off-by: Ma Wupeng --- mm/page_alloc.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index e5486d47406e..f1e4474879f1 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -8636,9 +8636,9 @@ static void __setup_per_zone_wmarks(void) struct zone *zone; unsigned long flags; - /* Calculate total number of !ZONE_HIGHMEM pages */ + /* Calculate total number of none highmem/movable pages */ for_each_zone(zone) { - if (!is_highmem(zone)) + if (!is_highmem(zone) && zone_idx(zone) != ZONE_MOVABLE) lowmem_pages += zone_managed_pages(zone); } @@ -8648,15 +8648,15 @@ static void __setup_per_zone_wmarks(void) spin_lock_irqsave(&zone->lock, flags); tmp = (u64)pages_min * zone_managed_pages(zone); do_div(tmp, lowmem_pages); - if (is_highmem(zone)) { + if (is_highmem(zone) || zone_idx(zone) == ZONE_MOVABLE) { /* * __GFP_HIGH and PF_MEMALLOC allocations usually don't - * need highmem pages, so cap pages_min to a small - * value here. + * need highmem/movable pages, so cap pages_min to a + * small value here. * * The WMARK_HIGH-WMARK_LOW and (WMARK_LOW-WMARK_MIN) * deltas control async page reclaim, and so should - * not be capped for highmem. + * not be capped for highmem/movable zone. */ unsigned long min_pages; -- 2.25.1