From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93084ECAAA1 for ; Wed, 7 Sep 2022 00:10:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EF8CA8D0002; Tue, 6 Sep 2022 20:10:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EA7736B0073; Tue, 6 Sep 2022 20:10:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D96058D0002; Tue, 6 Sep 2022 20:10:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C98CE6B0072 for ; Tue, 6 Sep 2022 20:10:52 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9B7951A0257 for ; Wed, 7 Sep 2022 00:10:52 +0000 (UTC) X-FDA: 79883358744.06.435588D Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf13.hostedemail.com (Postfix) with ESMTP id 2747320071 for ; Wed, 7 Sep 2022 00:10:52 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AFA42B81AAA; Wed, 7 Sep 2022 00:10:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A3F9C433D6; Wed, 7 Sep 2022 00:10:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1662509449; bh=EHSJp+ae8REEPQ3Px3yhok9m5oIog6h9LNiUxvHSGd0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=1bemAhIhg3JdZaj5tYJq15ketgTqOMnWrsxVHkWnnjJMB/1LFjjdBsf/wgehvekGb gPfZtnhOCqYp2EgYXr7JvbsXTFKrVopvV/XHWdoRZ6PPje+xgkqxxal0uQTv7ULj99 0tptLnKljV+dI7l/zLpeWN4qGosqmKctp9QqxD9w= Date: Tue, 6 Sep 2022 17:10:48 -0700 From: Andrew Morton To: Mike Kravetz Cc: Cheng Li , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm: use mem_map_offset instead of mem_map_next Message-Id: <20220906171048.1cd24a27b71ded17f89ddb00@linux-foundation.org> In-Reply-To: References: <1662358159-22780-1-git-send-email-lic121@chinatelecom.cn> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662509452; a=rsa-sha256; cv=none; b=Uy+Z1NUuorKQ1+xoZjiwN2/axWs3hrq/snubRuyTY2gDYxoUdQw3zZsMHKgg71pEjeeCLV TpgsX0JD7AuxBSC6u4GLyLV7LqSAJ1MlITN9nvfZPEJC8Ct3pivYR3NkxDXJ/2M8JzjHzb WtO1r4H24W3+Oz47CloJlKexcgKv/AU= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=1bemAhIh; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662509452; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PZL/5RMRzb3okr8mZOQwG8hMK3JOdWh8OAV1VQutz6s=; b=umibsCy3ySFDB4YflR+N0qHx8cidfewMKiSbwr3sSv0XgIrQZOLYxJL6/nlftC2Si3ptmc iKsM80L8IBo40duGemTIF14V1iv3Ka63HIREDLFLiXbHfFFHvmhThFFjw93b0s9tK+4cs+ ATL360+Zu1/GK2pddlJLKN/nZ3ObMaU= X-Stat-Signature: 3kosyuquzu65cpee88c68mxd6qs36nc4 X-Rspamd-Queue-Id: 2747320071 Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=1bemAhIh; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspamd-Server: rspam11 X-Rspam-User: X-HE-Tag: 1662509451-259517 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 6 Sep 2022 10:07:03 -0700 Mike Kravetz wrote: > On 09/05/22 06:09, Cheng Li wrote: > > To handle discontiguity case, mem_map_next() has a parameter named > > `offset`. As a function caller, one would be confused why "get > > next entry" needs a parameter named "offset". The other drawback of > > mem_map_next() is that the callers must take care of the map between > > parameter "iter" and "offset", otherwise we may get an hole or > > duplication during iteration. So we use mem_map_offset instead of > > mem_map_next. > > > > Signed-off-by: Cheng Li > > Fixes: 69d177c2fc70 ("hugetlbfs: handle pages higher order than MAX_ORDER") > > The Fixes tag implies there is a user visible bug. I do not believe this is > the case here. Is there a user visible bug? A Fixes: with a cc:stable would indicate a user-visible bug. But IMO a bare Fixes: is simply a when-to-stop guide to backporters - a convenience. And, I suppose, it has some documentation benefit. And if people are really that interested, they can read the dang changelog ;)