From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F4C7ECAAA1 for ; Tue, 6 Sep 2022 18:23:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB4B26B0073; Tue, 6 Sep 2022 14:23:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D627C8D0002; Tue, 6 Sep 2022 14:23:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C04CB8D0001; Tue, 6 Sep 2022 14:23:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AE0916B0073 for ; Tue, 6 Sep 2022 14:23:17 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 75D8DAB6B5 for ; Tue, 6 Sep 2022 18:23:17 +0000 (UTC) X-FDA: 79882482834.07.565A6A7 Received: from iguana.tulip.relay.mailchannels.net (iguana.tulip.relay.mailchannels.net [23.83.218.253]) by imf06.hostedemail.com (Postfix) with ESMTP id 9F671180061 for ; Tue, 6 Sep 2022 18:23:14 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 7C52B22246; Tue, 6 Sep 2022 18:23:12 +0000 (UTC) Received: from pdx1-sub0-mail-a297.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 06907223F8; Tue, 6 Sep 2022 18:23:11 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1662488592; a=rsa-sha256; cv=none; b=YGeGrjdf7lPx1ysO2ryuqeG8oQlJeh64+uQlc9AqH75eSE2X2SNKiVsUIGrMIFEzRf2TYB Yk6AmOMHFVYLf9tHRvzhKqUabh9MnmIe3T+2cUjSwIqyMgIduYxozHLqNvo4u3a45Ksls3 fW/8uPlN0dcMzSIKpyG3/3hmabT5KZ00UYB+X6Xj+xrk7KKuImkkWwAmPYRR8b6/1gP0jX Y4s07ysn59n9kqn+uSfmCkkfuk5S0JmvypE34u816dm1yPoWB4FfnlcKGEhAEAyzqW7VyG OwrpupZK4aypwqpV5yzYr/YxiX0EoweKzae/GOOT3GjLSrOJKdrDCg0NLLzF0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1662488592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XA617++Zv+kvhwOfHvoq94h2T85fV366jfZIsfdI8V0=; b=TySZ0TQY5AUAtfpt3dmnUnKAHQzoTVGkupR0llPrtjVcA2UMGMPHncd5p1vVptzz/qW+AJ 9im4qTcILhEm5cWksOrlhrPOogAwmSUKhS2yA6TfHDTMLSBt/aSa0GvuNr1AZJCMNLNfoz +Q0AXVvjTVEg5tgVj+Q5RF7W64MDQhlOeSV6DfwQyKp7cx9FjU9FyJQykmzVb1X2HS4S9J nB68Hw1hJ7tz4uSMFYjsuyZHu+bqQFrWFzOWVQf//AGN9vYtrH+YztdiZ92dBl+yLm8AQj aUoxRvQjIzwfanXOCLIEIcKILlRyM1iBcMgIfrOlRj+I/fHP/WojIdzKLThn4Q== ARC-Authentication-Results: i=1; rspamd-686945db84-p8v2v; auth=pass smtp.auth=dreamhost smtp.mailfrom=dave@stgolabs.net X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|dave@stgolabs.net X-MailChannels-Auth-Id: dreamhost X-Abaft-Whispering: 660cc1d453c6b917_1662488592320_3961185797 X-MC-Loop-Signature: 1662488592320:3984289857 X-MC-Ingress-Time: 1662488592320 Received: from pdx1-sub0-mail-a297.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.124.238.66 (trex/6.7.1); Tue, 06 Sep 2022 18:23:12 +0000 Received: from offworld (unknown [104.36.31.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dave@stgolabs.net) by pdx1-sub0-mail-a297.dreamhost.com (Postfix) with ESMTPSA id 4MMYfQ5PbBz76; Tue, 6 Sep 2022 11:23:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stgolabs.net; s=dreamhost; t=1662488591; bh=XA617++Zv+kvhwOfHvoq94h2T85fV366jfZIsfdI8V0=; h=Date:From:To:Cc:Subject:Content-Type; b=jfJeRT3lGeWdDzpZT88wsgsmB8V4RtaS/fam4EVS7+1rAEjtnnhTWRjNGo+wHUTdy 7r6ntfwUYFjHwwicXjSpC8TpiLX766u1sJVPSp8l1P4JN30jFerWMazR+GwPa5V2Vr 7UGldKlzEXMIOro293icBPLVhlVKacYomPz8HXVnSmPIemsmGE2VX1zz2JMmFu0lT1 BRmEepqo7Lcb7lqSKyZvP2AJMtQXiptF0YtFpMQBvfcViEYvRBnr9drR8wErWoTbtB qi9BHY49kld9rj1W4w4aFjtnDXjcxS5U6lSoSpcMttN1d30/NYt75D3LgB8/QwAfrl 3o+vtUaP00fGQ== Date: Tue, 6 Sep 2022 11:04:19 -0700 From: Davidlohr Bueso To: Liam Howlett Cc: "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton , Vlastimil Babka Subject: Re: [PATCH v13 59/70] mm/mremap: use vma_find_intersection() instead of vma linked list Message-ID: <20220906180419.as2j5mfg4dzx2ssm@offworld> Mail-Followup-To: Liam Howlett , "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton , Vlastimil Babka References: <20220822150128.1562046-1-Liam.Howlett@oracle.com> <20220822150128.1562046-60-Liam.Howlett@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20220822150128.1562046-60-Liam.Howlett@oracle.com> User-Agent: NeoMutt/20220429 ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662488596; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XA617++Zv+kvhwOfHvoq94h2T85fV366jfZIsfdI8V0=; b=sbmcdyiCPNF4wBxqHky6qSgWYIr9aJWeqiH8EuGuJECoyY7s5n25e7WjYqCTQGdN/tIJJg AaxVCWhVj4sXs2vIoX7ZhLSLdA2FijH3yA19G4y059WqSHarvQBIGXmCW4sjey3Uk60UGR lRbWh0jUYaR9330DoK9ZdsQ/G5mlwQ4= ARC-Authentication-Results: i=2; imf06.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=jfJeRT3l; arc=pass ("mailchannels.net:s=arc-2022:i=1"); spf=pass (imf06.hostedemail.com: domain of dave@stgolabs.net designates 23.83.218.253 as permitted sender) smtp.mailfrom=dave@stgolabs.net; dmarc=none ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1662488596; a=rsa-sha256; cv=pass; b=cOhArFz2y4vqRHGmLJEcgk8lqamwRTUbXuybzOdqVWw9oAkf3yVSXcsXRL0BAwFg2SqCqi Dro2r2uFyqHjCHp0gdjjjLRu2ch2xqSqbAd/8xpAH/tEUq4yVdgkt6e188Fxhcw6j3nfUR Q74OwnjObPbU3NVwQS7YLWNtzKCKD2k= X-Rspamd-Queue-Id: 9F671180061 Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=jfJeRT3l; arc=pass ("mailchannels.net:s=arc-2022:i=1"); spf=pass (imf06.hostedemail.com: domain of dave@stgolabs.net designates 23.83.218.253 as permitted sender) smtp.mailfrom=dave@stgolabs.net; dmarc=none X-Rspamd-Server: rspam02 X-Rspam-User: X-Stat-Signature: dgfptxrdwmief4cfqo4eindkik5mexo3 X-HE-Tag: 1662488594-453222 X-Bogosity: Ham, tests=bogofilter, spamicity=0.002044, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 22 Aug 2022, Liam Howlett wrote: >From: "Liam R. Howlett" -ENOCHANGELOG > >Signed-off-by: Liam R. Howlett >Acked-by: Vlastimil Babka Reviewed-by: Davidlohr Bueso >--- > mm/mremap.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/mm/mremap.c b/mm/mremap.c >index e0fba9004246..8644ff278f02 100644 >--- a/mm/mremap.c >+++ b/mm/mremap.c >@@ -716,7 +716,7 @@ static unsigned long move_vma(struct vm_area_struct *vma, > if (excess) { > vma->vm_flags |= VM_ACCOUNT; > if (split) >- vma->vm_next->vm_flags |= VM_ACCOUNT; >+ find_vma(mm, vma->vm_end)->vm_flags |= VM_ACCOUNT; > } > > return new_addr; >@@ -866,9 +866,10 @@ static unsigned long mremap_to(unsigned long addr, unsigned long old_len, > static int vma_expandable(struct vm_area_struct *vma, unsigned long delta) > { > unsigned long end = vma->vm_end + delta; >+ > if (end < vma->vm_end) /* overflow */ > return 0; >- if (vma->vm_next && vma->vm_next->vm_start < end) /* intersection */ >+ if (find_vma_intersection(vma->vm_mm, vma->vm_end, end)) > return 0; > if (get_unmapped_area(NULL, vma->vm_start, end - vma->vm_start, > 0, MAP_FIXED) & ~PAGE_MASK) > >-- >2.35.1 >