From: kernel test robot <lkp@intel.com>
To: Sidhartha Kumar <sidhartha.kumar@oracle.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: kbuild-all@lists.01.org, akpm@linux-foundation.org,
songmuchun@bytedance.com, mike.kravetz@oracle.com,
willy@infradead.org, vbabka@suse.cz,
william.kucharski@oracle.com, dhowells@redhat.com,
peterx@redhat.com, arnd@arndb.de, ccross@google.com,
hughd@google.com, ebiederm@xmission.com,
Sidhartha Kumar <sidhartha.kumar@oracle.com>
Subject: Re: [PATCH v2 6/6] mm/hugetlb add folio_hstate()
Date: Wed, 7 Sep 2022 12:01:13 +0800 [thread overview]
Message-ID: <202209071158.3gw6CkuN-lkp@intel.com> (raw)
In-Reply-To: <20220906165445.146913-7-sidhartha.kumar@oracle.com>
Hi Sidhartha,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on akpm-mm/mm-everything]
[also build test ERROR on next-20220906]
[cannot apply to soc/for-next linus/master v6.0-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Sidhartha-Kumar/begin-converting-hugetlb-code-to-folios/20220907-005803
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
config: openrisc-randconfig-r033-20220906 (https://download.01.org/0day-ci/archive/20220907/202209071158.3gw6CkuN-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/4f02eaa12cd159c40269d80d357809de3be5518a
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Sidhartha-Kumar/begin-converting-hugetlb-code-to-folios/20220907-005803
git checkout 4f02eaa12cd159c40269d80d357809de3be5518a
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=openrisc SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All error/warnings (new ones prefixed by >>):
mm/migrate.c: In function 'alloc_migration_target':
>> mm/migrate.c:1610:36: error: implicit declaration of function 'folio_hstate'; did you mean 'folio_activate'? [-Werror=implicit-function-declaration]
1610 | struct hstate *h = folio_hstate(folio);
| ^~~~~~~~~~~~
| folio_activate
>> mm/migrate.c:1610:36: warning: initialization of 'struct hstate *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
cc1: some warnings being treated as errors
vim +1610 mm/migrate.c
1592
1593 struct page *alloc_migration_target(struct page *page, unsigned long private)
1594 {
1595 struct folio *folio = page_folio(page);
1596 struct migration_target_control *mtc;
1597 gfp_t gfp_mask;
1598 unsigned int order = 0;
1599 struct folio *new_folio = NULL;
1600 int nid;
1601 int zidx;
1602
1603 mtc = (struct migration_target_control *)private;
1604 gfp_mask = mtc->gfp_mask;
1605 nid = mtc->nid;
1606 if (nid == NUMA_NO_NODE)
1607 nid = folio_nid(folio);
1608
1609 if (folio_test_hugetlb(folio)) {
> 1610 struct hstate *h = folio_hstate(folio);
1611
1612 gfp_mask = htlb_modify_alloc_mask(h, gfp_mask);
1613 return alloc_huge_page_nodemask(h, nid, mtc->nmask, gfp_mask);
1614 }
1615
1616 if (folio_test_large(folio)) {
1617 /*
1618 * clear __GFP_RECLAIM to make the migration callback
1619 * consistent with regular THP allocations.
1620 */
1621 gfp_mask &= ~__GFP_RECLAIM;
1622 gfp_mask |= GFP_TRANSHUGE;
1623 order = folio_order(folio);
1624 }
1625 zidx = zone_idx(folio_zone(folio));
1626 if (is_highmem_idx(zidx) || zidx == ZONE_MOVABLE)
1627 gfp_mask |= __GFP_HIGHMEM;
1628
1629 new_folio = __folio_alloc(gfp_mask, order, nid, mtc->nmask);
1630
1631 return &new_folio->page;
1632 }
1633
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-09-07 4:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 16:54 [PATCH v2 0/6] begin converting hugetlb code to folios Sidhartha Kumar
2022-09-06 16:54 ` [PATCH v2 1/6] mm/hugetlb: add folio support to hugetlb specific flag macros Sidhartha Kumar
2022-09-06 16:54 ` [PATCH v2 2/6] mm: add private field of first tail to struct page and struct folio Sidhartha Kumar
2022-09-06 16:54 ` [PATCH v2 3/6] mm/hugetlb: add hugetlb_folio_subpool() helper Sidhartha Kumar
2022-09-06 16:54 ` [PATCH v2 4/6] mm/hugetlb: add hugetlb_set_folio_subpool() helper Sidhartha Kumar
2022-09-06 16:54 ` [PATCH v2 5/6] hugetlbfs: convert hugetlb_delete_from_page_cache() to use folios Sidhartha Kumar
2022-09-06 16:54 ` [PATCH v2 6/6] mm/hugetlb add folio_hstate() Sidhartha Kumar
2022-09-07 4:01 ` kernel test robot [this message]
2022-09-07 5:23 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202209071158.3gw6CkuN-lkp@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=ccross@google.com \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=hughd@google.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=peterx@redhat.com \
--cc=sidhartha.kumar@oracle.com \
--cc=songmuchun@bytedance.com \
--cc=vbabka@suse.cz \
--cc=william.kucharski@oracle.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).