From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C639C38145 for ; Wed, 7 Sep 2022 17:27:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E23E6B0072; Wed, 7 Sep 2022 13:27:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 491736B0073; Wed, 7 Sep 2022 13:27:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 359788D0002; Wed, 7 Sep 2022 13:27:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 256516B0072 for ; Wed, 7 Sep 2022 13:27:19 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E7D1F40252 for ; Wed, 7 Sep 2022 17:27:18 +0000 (UTC) X-FDA: 79885970556.01.7868AA3 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf14.hostedemail.com (Postfix) with ESMTP id 6CA3A100077 for ; Wed, 7 Sep 2022 17:27:17 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 12E2DB81116; Wed, 7 Sep 2022 17:27:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35BD7C433D6; Wed, 7 Sep 2022 17:27:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662571634; bh=zQkxLyJV/ZVaWJTNUJCn3/hQDVgwS2Dscv1v7/418+g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rJ2FCz5VATBfWjyd4ZkKYP3xEhQpP5RAzoammBnR5HpmUbjvheKTclq95QrbLUz3n G8/jCyxsTTSwJP+kor8EG5PvtumauQ2SVcwcPZCfWW+kKE+d9BC5JZWBaOBvkk2YzQ wXkLr+Gm0UN4mg54vbbUqALxG/ZdKeM/bA29zFU9fzcF5fbNq5QfFG5hQAsWlJF08q 8Ga6VuUN71JnCoulwKPfvEraMvHCALDrVrHTW3krAKipY92jNOvrFf4ANDDqqe5hC0 Op4Qk7Va1aXOspXYNmvDaEfBXii2DLjDQqiS12wgCIE3T9aPE8ZJtocmG9azsQ22kx f+zBB7fHI7Q8A== From: SeongJae Park To: Cc: sj@kernel.org, akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, xhao@linux.alibaba.com Subject: Re: [PATCH] mm/damon: Remove duplicate get_monitoring_region() definitions Date: Wed, 7 Sep 2022 17:27:12 +0000 Message-Id: <20220907172712.61006-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220907112924.65546-1-xhao@linux.alibaba.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rJ2FCz5V; spf=pass (imf14.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662571637; a=rsa-sha256; cv=none; b=qSWCtQMxW8GjthcvGA9JcBUMYYw4YD/dzvLWLUhPgwyHbWv04A/In6qAcgLAJ/1H7I/XFG zOHSHB+6YrT+2bQIalfj7Wah3QypGHkRA9/r/2+AVNqwru5wamW9QJmGEXagCquIV0JmVd ayD8cdssI4uUoq7g8mvv+gBaGQaP86E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662571637; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1tQ3XmU6QfjpR3wXE7YcOx2srHTfNU2yE98NfrbImzU=; b=AM4jXfECs0LiQtuHkyMq/izHGajDuQup9kKyZL0pA0Ef1uArWS9CDuyA2hbeIZP1Kj01mB 75v2fteTTGFNXdiQY39B++TXN7nrOZH1a+sQPOc+fHOgy/NESVvIpZguIXB9G2lklRyeAQ 1kM1EEQWpaF7Rtl+2ZkQ6XKm+zI6K1g= Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=rJ2FCz5V; spf=pass (imf14.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspam-User: X-Rspamd-Queue-Id: 6CA3A100077 X-Rspamd-Server: rspam05 X-Stat-Signature: db6krqx3k74p6eicewgudc6g5mkfas61 X-HE-Tag: 1662571637-545073 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Xin, > In lru_sort.c and reclaim.c, they are all define get_monitoring_region() s/define/defining/ > function, there is no need to define it separately. Good point! > > BTW, this patch remove tow struct 'damon_lru_sort_ram_walk_arg' and s/remove/removes/ s/tow/two/ > 'damon_reclaim_ram_walk_arg', though the two struct are removed, if we > want to add more fields to these struct for other purposes later, it will s/struct/structs/ > not too late for us to use them again. > For example: > struct damon_reclaim_ram_walk_arg { > struct damon_addr_range raw_walk; > xxx A; > xxx B; > } > struct damon_lru_sort_ram_walk_arg { > struct damon_addr_range raw_walk; > xxx A; > xxx B; > } I haven't read the below part yet, but seems you're gonna use 'struct damon_addr_range' instead of 'struct damon_{reclai,lru_sort}_ram_walk_arg'. And I think we have already discussed about this before: https://lore.kernel.org/damon/20220818172322.51705-1-sj@kernel.org/ My point is, we might add some more fileds to 'struct damon_addr_range' in a future, though it seems very unlikely at the moment. Sorry for not making my opinion clear enough. > > Signed-off-by: Xin Hao > --- > mm/damon/lru_sort.c | 35 ++--------------------------------- > mm/damon/ops-common.c | 28 ++++++++++++++++++++++++++++ > mm/damon/ops-common.h | 1 + > mm/damon/reclaim.c | 35 ++--------------------------------- > 4 files changed, 33 insertions(+), 66 deletions(-) > > diff --git a/mm/damon/lru_sort.c b/mm/damon/lru_sort.c > index 9de6f00a71c5..5032d59d46e4 100644 > --- a/mm/damon/lru_sort.c > +++ b/mm/damon/lru_sort.c > @@ -13,6 +13,8 @@ > #include > #include > > +#include "ops-common.h" > + > #ifdef MODULE_PARAM_PREFIX > #undef MODULE_PARAM_PREFIX > #endif > @@ -257,39 +259,6 @@ module_param(nr_cold_quota_exceeds, ulong, 0400); > static struct damon_ctx *ctx; > static struct damon_target *target; > > -struct damon_lru_sort_ram_walk_arg { > - unsigned long start; > - unsigned long end; > -}; > - > -static int walk_system_ram(struct resource *res, void *arg) > -{ > - struct damon_lru_sort_ram_walk_arg *a = arg; > - > - if (a->end - a->start < resource_size(res)) { > - a->start = res->start; > - a->end = res->end; > - } > - return 0; > -} > - > -/* > - * Find biggest 'System RAM' resource and store its start and end address in > - * @start and @end, respectively. If no System RAM is found, returns false. > - */ > -static bool get_monitoring_region(unsigned long *start, unsigned long *end) > -{ > - struct damon_lru_sort_ram_walk_arg arg = {}; > - > - walk_system_ram_res(0, ULONG_MAX, &arg, walk_system_ram); > - if (arg.end <= arg.start) > - return false; > - > - *start = arg.start; > - *end = arg.end; > - return true; > -} > - > /* Create a DAMON-based operation scheme for hot memory regions */ > static struct damos *damon_lru_sort_new_hot_scheme(unsigned int hot_thres) > { > diff --git a/mm/damon/ops-common.c b/mm/damon/ops-common.c > index b1335de200e7..01938f33038d 100644 > --- a/mm/damon/ops-common.c > +++ b/mm/damon/ops-common.c > @@ -172,3 +172,31 @@ int damon_hot_score(struct damon_ctx *c, struct damon_region *r, > > return hotness; > } > + > +static inline int walk_system_ram(struct resource *res, void *arg) > +{ > + struct damon_addr_range *a = arg; > + > + if (a->end - a->start < resource_size(res)) { > + a->start = res->start; > + a->end = res->end; > + } > + return 0; > +} > + > +/* > + * Find biggest 'System RAM' resource and store its start and end address in > + * @start and @end, respectively. If no System RAM is found, returns false. > + */ > +bool get_monitoring_region(unsigned long *start, unsigned long *end) > +{ > + struct damon_addr_range arg = {}; > + > + walk_system_ram_res(0, ULONG_MAX, &arg, walk_system_ram); > + if (arg.end <= arg.start) > + return false; > + > + *start = arg.start; > + *end = arg.end; > + return true; > +} 'ops-common.c' is for code that common in monitoring operations implementations. I'd prefer to have yet another source file for the DAMON modules including reclaim and lru_sort, say, 'modules-common.c'. Also, as 'get_monitoring_region()' is not a 'static' function anymore, let's have a prefix to distinguish with other functions, say, 'damon_modules_'? > diff --git a/mm/damon/ops-common.h b/mm/damon/ops-common.h > index 52329ff361cd..e6f1c9b48042 100644 > --- a/mm/damon/ops-common.h > +++ b/mm/damon/ops-common.h > @@ -16,3 +16,4 @@ int damon_pageout_score(struct damon_ctx *c, struct damon_region *r, > struct damos *s); > int damon_hot_score(struct damon_ctx *c, struct damon_region *r, > struct damos *s); > +bool get_monitoring_region(unsigned long *start, unsigned long *end); Let's move it to a dedicated source file, say, 'modules-common.h' > diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c > index a7faf51b4bd4..20e83eee3c7d 100644 > --- a/mm/damon/reclaim.c > +++ b/mm/damon/reclaim.c > @@ -13,6 +13,8 @@ > #include > #include > > +#include "ops-common.h" > + > #ifdef MODULE_PARAM_PREFIX > #undef MODULE_PARAM_PREFIX > #endif > @@ -229,39 +231,6 @@ module_param(nr_quota_exceeds, ulong, 0400); > static struct damon_ctx *ctx; > static struct damon_target *target; > > -struct damon_reclaim_ram_walk_arg { > - unsigned long start; > - unsigned long end; > -}; > - > -static int walk_system_ram(struct resource *res, void *arg) > -{ > - struct damon_reclaim_ram_walk_arg *a = arg; > - > - if (a->end - a->start < resource_size(res)) { > - a->start = res->start; > - a->end = res->end; > - } > - return 0; > -} > - > -/* > - * Find biggest 'System RAM' resource and store its start and end address in > - * @start and @end, respectively. If no System RAM is found, returns false. > - */ > -static bool get_monitoring_region(unsigned long *start, unsigned long *end) > -{ > - struct damon_reclaim_ram_walk_arg arg = {}; > - > - walk_system_ram_res(0, ULONG_MAX, &arg, walk_system_ram); > - if (arg.end <= arg.start) > - return false; > - > - *start = arg.start; > - *end = arg.end; > - return true; > -} > - > static struct damos *damon_reclaim_new_scheme(void) > { > struct damos_watermarks wmarks = { > -- > 2.31.0 Thanks, SJ